feedc0de/homeassistant-core
1
0
Fork 0
forked from home-assistant/core
Code Pull Requests Activity

Fix Sonos favorites race condition v2 (#50575)

Browse Source
This commit is contained in:
jjlawren
2021-05-13 22:32:34 -05:00
committed by GitHub
parent 421e1b9956
commit c52a33478e
1 changed files with 6 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
homeassistant/components/sonos/media_player.py
View File

@@ -440,6 +440,11 @@ class SonosMediaPlayerEntity(SonosEntity, MediaPlayerEntity):
self._media_position = None self._media_position = None
self._media_position_updated_at = None self._media_position_updated_at = None
async def async_set_favorites(self) -> None:
"""Wrap favorites update method with an async lock."""
async with self.data.topology_condition:
await self.hass.async_add_executor_job(self._set_favorites)
def _set_favorites(self) -> None: def _set_favorites(self) -> None:
"""Set available favorites.""" """Set available favorites."""
self._favorites = [] self._favorites = []
@@ -741,7 +746,7 @@ class SonosMediaPlayerEntity(SonosEntity, MediaPlayerEntity):
def async_update_content(self, event: SonosEvent | None = None) -> None: def async_update_content(self, event: SonosEvent | None = None) -> None:
"""Update information about available content.""" """Update information about available content."""
if event and "favorites_update_id" in event.variables: if event and "favorites_update_id" in event.variables:
self.hass.async_add_job(self._set_favorites) self.hass.async_add_job(self.async_set_favorites)
self.async_write_ha_state() self.async_write_ha_state()
@property @property