feedc0de/homeassistant-core
1
0
Fork 0
forked from home-assistant/core
Code Pull Requests Activity

Return empty when listing statistic_ids for unsupported statistic (#52954)

Browse Source
This commit is contained in:
Erik Montnemery
2021-07-13 10:35:55 +02:00
committed by GitHub
parent 9cbf88d944
commit c5556a091e
2 changed files with 4 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
homeassistant/components/recorder/statistics.py
View File

@@ -145,8 +145,10 @@ def _get_metadata(hass, session, statistic_ids, statistic_type):
) )
if statistic_type == "mean": if statistic_type == "mean":
baked_query += lambda q: q.filter(StatisticsMeta.has_mean.isnot(False)) baked_query += lambda q: q.filter(StatisticsMeta.has_mean.isnot(False))
if statistic_type == "sum": elif statistic_type == "sum":
baked_query += lambda q: q.filter(StatisticsMeta.has_sum.isnot(False)) baked_query += lambda q: q.filter(StatisticsMeta.has_sum.isnot(False))
elif statistic_type is not None:
return {}
result = execute(baked_query(session).params(statistic_ids=statistic_ids)) result = execute(baked_query(session).params(statistic_ids=statistic_ids))
metadata_ids = [metadata[0] for metadata in result] metadata_ids = [metadata[0] for metadata in result]

4
tests/components/history/test_init.py
View File

@@ -1015,9 +1015,7 @@ async def test_list_statistic_ids(hass, hass_ws_client, units, attributes, unit)
) )
response = await client.receive_json() response = await client.receive_json()
assert response["success"] assert response["success"]
assert response["result"] == [ assert response["result"] == []
{"statistic_id": "sensor.test", "unit_of_measurement": unit}
]
await client.send_json( await client.send_json(
{"id": 4, "type": "history/list_statistic_ids", "statistic_type": "mean"} {"id": 4, "type": "history/list_statistic_ids", "statistic_type": "mean"}