feedc0de/homeassistant-core
1
0
Fork 0
forked from home-assistant/core
Code Pull Requests Activity
79,346 Commits 190 Branches 1,466 Tags
a8bf671663a00aad825d122ff3d2f19fe196828f
Commit Graph

37 Commits

Author SHA1 Message Date
Sid b456d97e65 Replace pylint protected-access with Ruff SLF001 (#115735) 2024-05-06 20:33:26 +02:00
Michael 50d83bbdbf Fix error handling in Shell Command integration (#116409) 
* raise proper HomeAssistantError on command timeout

* raise proper HomeAssistantError on non-utf8 command output

* add error translation and test it

* Update homeassistant/components/shell_command/strings.json

* Update tests/components/shell_command/test_init.py

---------

Co-authored-by: G Johansson <goran.johansson@shiftit.se>
 2024-04-29 20:19:14 +02:00
Sid 6587ee20db Enable Ruff TRY300 (#114437) 
* Enable Ruff TRY300

* Update validation.py

* Address review comments
 2024-03-30 10:37:59 +01:00
Sid a5b609f081 Enable ruff TRY401 (#114395) 
* Enable ruff TRY401

* fix tests
 2024-03-29 07:20:36 +01:00
Sid ccd2e989c3 Enable ruff RUF005 and fix occurrences (#113589) 2024-03-16 07:37:20 -10:00
Marc Mueller 930a396712 Add empty line after module docstring [s] (#112704) 2024-03-08 14:33:51 +01:00
Marc Mueller 438d3b01b9 Use builtin TimeoutError [o-s] (#109682) 2024-02-05 12:14:37 +01:00
Marc Mueller 063ce9159d Use asyncio.timeout [o-s] (#98451) 2023-08-15 17:21:49 +02:00
RoboMagus f0e9dccb58 Only handle shell commands output when return_response requested (#97777) 2023-08-10 18:11:15 +02:00
RoboMagus c433b251fa Shell command response (#96695) 
* Add service response to shell_commands

* Add shell_command response tests

* Fix mypy

* Return empty dict instead of None on error

* Improved response type hint

* Cleanup after removing type cast

* Raise exceptions i.s.o. returning

* Fix ruff
 2023-07-20 11:53:57 +02:00
Erik Montnemery 2a18d0a764 Do not include stack trace when shell_command service times out (#96833) 2023-07-18 13:37:17 +02:00
J. Nick Koston e54eb7e2c8 Switch shell_command to use async_timeout instead of asyncio.wait_for (#88573) 
This avoids creating a task every time
 2023-02-21 21:11:54 -05:00
J. Nick Koston 03eea7bd3f Avoid subprocess memory copy when c library supports posix_spawn (#87958) 
* use posix spawn on alpine

* Avoid subprocess memory copy when c library supports posix_spawn

By default python 3.10 will use the fork() which has to
copy all the memory of the parent process (in our case
this can be huge since Home Assistant core can use
hundreds of megabytes of RAM). By using posix_spawn
this is avoided.

In python 3.11 vfork will also be available
https://github.com/python/cpython/issues/80004#issuecomment-1093810689
https://github.com/python/cpython/pull/11671 but we won't
always be able to use it and posix_spawn is considered safer
https://bugzilla.kernel.org/show_bug.cgi?id=215813#c14

The subprocess library doesn't know about musl though
even though it supports posix_spawn https://git.musl-libc.org/cgit/musl/log/src/process/posix_spawn.c
so we have to teach it since it only has checks for glibc
https://github.com/python/cpython/blob/1b736838e6ae1b4ef42cdd27c2708face908f92c/Lib/subprocess.py#L745

The constant is documented as being able to be flipped here:
https://docs.python.org/3/library/subprocess.html#disabling-use-of-vfork-or-posix-spawn

* Avoid subprocess memory copy when c library supports posix_spawn

By default python 3.10 will use the fork() which has to
copy memory of the parent process (in our case
this can be huge since Home Assistant core can use
hundreds of megabytes of RAM). By using posix_spawn
this is avoided and subprocess creation does not
get discernibly slow the larger the Home Assistant
python process grows.

In python 3.11 vfork will also be available
https://github.com/python/cpython/issues/80004#issuecomment-1093810689
https://github.com/python/cpython/pull/11671 but we won't
always be able to use it and posix_spawn is considered safer
https://bugzilla.kernel.org/show_bug.cgi?id=215813#c14

The subprocess library doesn't know about musl though
even though it supports posix_spawn https://git.musl-libc.org/cgit/musl/log/src/process/posix_spawn.c
so we have to teach it since it only has checks for glibc
https://github.com/python/cpython/blob/1b736838e6ae1b4ef42cdd27c2708face908f92c/Lib/subprocess.py#L745

The constant is documented as being able to be flipped here:
https://docs.python.org/3/library/subprocess.html#disabling-use-of-vfork-or-posix-spawn

* missed some

* adjust more tests

* coverage
 2023-02-13 09:02:51 -05:00
Erik Montnemery 23fa500406 Sort manifests 9 (#87030) 2023-02-08 20:22:30 +01:00
Franck Nijhof 79b52a2b41 Stricter pylint message control (#86154) 2023-01-20 13:47:55 +01:00
Jan Bouwhuis 23bc39b7f4 Add type hints on Template().__init__() (#82574) 2022-11-23 20:26:55 +01:00
Marc Mueller 46c3495ae0 Update pylint to 2.9.5 (#53496) 2021-07-26 16:17:15 +02:00
Shay Levy 6fc5a6a065 Fix CI failing due to Shell Command exception (#52483) 2021-07-05 10:38:55 +02:00
Dermot Duffy e8446cb4d9 Fix types for shell command (#50004) 2021-05-03 10:43:23 +02:00
jan iversen c351098f04 HomeAssistantType —> HomeAssistant for Integrations p* - s* (#49558) 2021-04-22 19:58:02 +02:00
Franck Nijhof 055cdc64c0 Add support for IoT class in manifest (#46935) 2021-04-15 10:21:38 +02:00
Franck Nijhof 6932cf9534 Use contextlib.suppress where possible (#48189) 2021-03-23 14:36:43 +01:00
springstan a967f689c7 Remove unnecessary instances of dict.keys() (#42518) 2020-10-28 20:43:48 +01:00
Franck Nijhof 45aba9bdf2 Allow skip parsing template result (#42401) 2020-10-26 16:01:09 +01:00
J. Nick Koston dddcb8e299 Add a 60s timeout to shell_command to prevent processes from building up (#38491) 
If a process never ended, there was not timeout and they would
build up in the background until Home Assistant crashed.
 2020-08-04 16:59:19 -10:00
Paulus Schoutsen 8f9467492d Remove some passings of loop (#34995) 2020-04-30 21:34:51 -07:00
Paulus Schoutsen f1d3c0d19b Remove unused manifest fields (#33595) 2020-04-03 12:58:19 -07:00
Franck Nijhof bfa0edaf92 Migrate Integration Quality Scale from docs to manifest: internal (#30551) 2020-01-07 20:58:49 +01:00
Franck Nijhof 22760a0bee Correct names in manifests (Q-S) (#30543) 2020-01-07 08:19:44 -05:00
Franck Nijhof a84741392b Format all manifests with prettier (#30521) 2020-01-06 21:28:23 +01:00
Bas Nijholt 23b92b2a56 Sort imports according to PEP8 for components starting with "S" (#29777) 2019-12-09 14:38:01 +01:00
Franck Nijhof c7da781efc Update documentation link URL for integrations in all manifests (#27114) 2019-10-02 09:25:44 -07:00
Paulus Schoutsen 4de97abc3a Black 2019-07-31 12:25:30 -07:00
Alok Saboo 4be30f7c88 create services.yaml for shell_command (#23210) 2019-04-18 13:10:10 -07:00
Paulus Schoutsen cfe4cf30ad Add manifests (#22699) 
* Add manifests

* Update auto name

* Update codeowners

* Add requirements from platforms

* Minor cleanup

* Incorporate changes from awarecan PR
 2019-04-03 21:14:45 -07:00
Fabian Affolter 127c55e0c1 Update file header (#21023) 
* Update file header

* Update file header

* Update file header

* Update file header

* Update file header

* Fix lint issues
 2019-02-13 21:21:14 +01:00
Paulus Schoutsen b8cc547fa3 Move components to folders (#20774) 
* Move all components into folders

* Move component tests into folders

* Fix init moving

* Move tests

* Lint

* Update coverage

* Fix service descriptions

* Update CODEOWNERS
 2019-02-05 19:31:15 -08:00