From 086e62c80cd28c9013fe855c698e57ffab3b9c5f Mon Sep 17 00:00:00 2001
From: Yves Delley <delleyves@gmx.ch>
Date: Fri, 10 May 2024 22:23:52 +0200
Subject: [PATCH] suggestions from review

---
 src/core/include/mp-units/math.h | 15 ++++++---------
 1 file changed, 6 insertions(+), 9 deletions(-)

diff --git a/src/core/include/mp-units/math.h b/src/core/include/mp-units/math.h
index 2eabeca4..e6957201 100644
--- a/src/core/include/mp-units/math.h
+++ b/src/core/include/mp-units/math.h
@@ -151,11 +151,10 @@ template<auto R, typename Rep>
  * @return bool: Whether the quantity point is finite or not.
  */
 template<auto R, auto PO, typename Rep>
-  requires requires(Rep v) { isfinite(v); } || requires(Rep v) { std::isfinite(v); }
+  requires requires(quantity<R, Rep> q) { isfinite(q); }
 [[nodiscard]] constexpr bool isfinite(const quantity_point<R, PO, Rep>& a) noexcept
 {
-  using std::isfinite;
-  return isfinite(a.quantity_ref_from(a.point_origin).numerical_value_ref_in(a.unit));
+  return isfinite(a.quantity_ref_from(a.point_origin));
 }
 
 /**
@@ -179,11 +178,10 @@ template<auto R, typename Rep>
  * @return bool: Whether the quantity point is infinite or not.
  */
 template<auto R, auto PO, typename Rep>
-  requires requires(Rep v) { isinf(v); } || requires(Rep v) { std::isinf(v); }
+  requires requires(quantity<R, Rep> q) { isinf(q); }
 [[nodiscard]] constexpr bool isinf(const quantity_point<R, PO, Rep>& a) noexcept
 {
-  using std::isinf;
-  return isinf(a.quantity_ref_from(a.point_origin).numerical_value_ref_in(a.unit));
+  return isinf(a.quantity_ref_from(a.point_origin));
 }
 
 
@@ -209,11 +207,10 @@ template<auto R, typename Rep>
  * @return bool: Whether the quantity point is a NaN or not.
  */
 template<auto R, auto PO, typename Rep>
-  requires requires(Rep v) { isnan(v); } || requires(Rep v) { std::isnan(v); }
+  requires requires(quantity<R, Rep> q) { isnan(q); }
 [[nodiscard]] constexpr bool isnan(const quantity_point<R, PO, Rep>& a) noexcept
 {
-  using std::isnan;
-  return isnan(a.quantity_ref_from(a.point_origin).numerical_value_ref_in(a.unit));
+  return isnan(a.quantity_ref_from(a.point_origin));
 }
 
 /**