From 360eb85d095d989722ea8ff2a320544c11c743a3 Mon Sep 17 00:00:00 2001
From: Mateusz Pusz <mateusz.pusz@gmail.com>
Date: Thu, 4 Jul 2024 15:03:58 +0100
Subject: [PATCH] docs: TODO note changed in the `unit_symbol` and
 `dimension_symbol`

---
 src/core/include/mp-units/framework/dimension.h | 3 ++-
 src/core/include/mp-units/framework/unit.h      | 3 ++-
 2 files changed, 4 insertions(+), 2 deletions(-)

diff --git a/src/core/include/mp-units/framework/dimension.h b/src/core/include/mp-units/framework/dimension.h
index 7155a740..cbd3609d 100644
--- a/src/core/include/mp-units/framework/dimension.h
+++ b/src/core/include/mp-units/framework/dimension.h
@@ -312,7 +312,8 @@ MP_UNITS_EXPORT template<dimension_symbol_formatting fmt = dimension_symbol_form
 #endif
 {
   constexpr auto oversized_symbol_text = []() consteval {
-    detail::inplace_vector<CharT, 128> text;  // TODO can we improve here?
+    // std::basic_string<CharT> text;  // TODO uncomment when https://wg21.link/P3032 is supported
+    detail::inplace_vector<CharT, 128> text;
     dimension_symbol_to<CharT>(std::back_inserter(text), D{}, fmt);
     return text;
   }();
diff --git a/src/core/include/mp-units/framework/unit.h b/src/core/include/mp-units/framework/unit.h
index 73655ef2..f32f4b40 100644
--- a/src/core/include/mp-units/framework/unit.h
+++ b/src/core/include/mp-units/framework/unit.h
@@ -823,7 +823,8 @@ MP_UNITS_EXPORT template<unit_symbol_formatting fmt = unit_symbol_formatting{},
 #endif
 {
   constexpr auto oversized_symbol_text = []() consteval {
-    detail::inplace_vector<CharT, 128> text;  // TODO can we improve here?
+    // std::basic_string<CharT> text;  // TODO uncomment when https://wg21.link/P3032 is supported
+    detail::inplace_vector<CharT, 128> text;
     unit_symbol_to<CharT>(std::back_inserter(text), U{}, fmt);
     return text;
   }();