feedc0de/mp-units
1
0
Fork 0
forked from mpusz/mp-units
Code Pull Requests Activity

'todo' -> 'TODO' refactoring

Browse Source
This commit is contained in:
Mateusz Pusz
2019-10-15 19:05:40 +02:00
parent d31d2cf439
commit 5082aaaf70
4 changed files with 4 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
src/include/units/dimension.h
View File

@@ -181,7 +181,7 @@ namespace units {
template<BaseDimension D, int Num1, int Den1, int Num2, int Den2, typename... ERest> template<BaseDimension D, int Num1, int Den1, int Num2, int Den2, typename... ERest>
struct dim_consolidate<dimension<exp<D, Num1, Den1>, exp<D, Num2, Den2>, ERest...>> { struct dim_consolidate<dimension<exp<D, Num1, Den1>, exp<D, Num2, Den2>, ERest...>> {
// todo: provide custom implementation for ratio_add // TODO: provide custom implementation for ratio_add
using r1 = std::ratio<Num1, Den1>; using r1 = std::ratio<Num1, Den1>;
using r2 = std::ratio<Num2, Den2>; using r2 = std::ratio<Num2, Den2>;
using r = std::ratio_add<r1, r2>; using r = std::ratio_add<r1, r2>;

2
src/include/units/dimensions/temperature.h
View File

@@ -38,7 +38,7 @@ namespace units {
// K // K
constexpr auto operator""K(unsigned long long l) { return quantity<kelvin, std::int64_t>(l); } constexpr auto operator""K(unsigned long long l) { return quantity<kelvin, std::int64_t>(l); }
constexpr auto operator""_K(long double l) { return quantity<kelvin, long double>(l); } // todo: conflicts with gcc GNU extension constexpr auto operator""_K(long double l) { return quantity<kelvin, long double>(l); } // TODO: conflicts with gcc GNU extension
} // namespace literals } // namespace literals

2
src/include/units/ratio.h
View File

@@ -183,7 +183,7 @@ namespace units {
namespace detail { namespace detail {
// todo: simplified // TODO: simplified
template<typename R1, typename R2> template<typename R1, typename R2>
struct common_ratio_impl { struct common_ratio_impl {
static constexpr std::intmax_t gcd_num = std::gcd(R1::num, R2::num); static constexpr std::intmax_t gcd_num = std::gcd(R1::num, R2::num);

2
test/unit_test/static/custom_unit_test.cpp
View File

@@ -67,7 +67,7 @@ namespace {
// amplitude spectral density // amplitude spectral density
struct amplitude_spectral_density : derived_dimension<amplitude_spectral_density, units::exp<voltage, 1>, units::exp<frequency, -1, 2>> {}; struct amplitude_spectral_density : derived_dimension<amplitude_spectral_density, units::exp<voltage, 1>, units::exp<frequency, -1, 2>> {};
// todo: add support for derived_unit // TODO: add support for derived_unit
//struct volt_per_sq_hertz : derived_unit<volt_per_sq_hertz, amplitude_spectral_density, volt, hertz> {}; //struct volt_per_sq_hertz : derived_unit<volt_per_sq_hertz, amplitude_spectral_density, volt, hertz> {};
struct volt_per_sqrt_hertz : derived_unit<volt_per_sqrt_hertz, decltype("V/Hz^(1/2)"_fs), amplitude_spectral_density> {}; struct volt_per_sqrt_hertz : derived_unit<volt_per_sqrt_hertz, decltype("V/Hz^(1/2)"_fs), amplitude_spectral_density> {};
} }