refactor: code refactored to comply with clang-tidy

This commit is contained in:
Mateusz Pusz
2024-05-08 11:12:38 +02:00
parent 901b5e5394
commit 75f719add7
46 changed files with 489 additions and 380 deletions
+3 -8
View File
@@ -84,20 +84,14 @@ template<class CharT, class Traits, typename T>
std::basic_ostream<CharT, Traits>& operator<<(std::basic_ostream<CharT, Traits>& os, const latitude<T>& lat)
{
const auto& q = lat.quantity_ref_from(geographic::equator);
if (is_gteq_zero(q))
return os << q << " N";
else
return os << -q << " S";
return (is_gteq_zero(q)) ? (os << q << " N") : (os << -q << " S");
}
template<class CharT, class Traits, typename T>
std::basic_ostream<CharT, Traits>& operator<<(std::basic_ostream<CharT, Traits>& os, const longitude<T>& lon)
{
const auto& q = lon.quantity_ref_from(geographic::prime_meridian);
if (is_gteq_zero(q))
return os << q << " E";
else
return os << -q << " W";
return (is_gteq_zero(q)) ? (os << q << " E") : (os << -q << " W");
}
inline namespace literals {
@@ -174,6 +168,7 @@ struct position {
};
template<typename T>
// NOLINTNEXTLINE(bugprone-easily-swappable-parameters)
distance spherical_distance(position<T> from, position<T> to)
{
using namespace mp_units;
+7 -6
View File
@@ -32,7 +32,6 @@
import mp_units.core;
#else
#include <mp-units/bits/fmt.h>
#include <mp-units/bits/hacks.h>
#include <mp-units/framework/customization_points.h>
#endif
@@ -82,12 +81,14 @@ public:
#else
// NOLINTNEXTLINE(google-explicit-constructor, hicpp-explicit-conversions)
constexpr explicit(false) operator T() const& noexcept(std::is_nothrow_copy_constructible_v<T>)
requires std::copyable<T>
{
return value_;
}
// NOLINTNEXTLINE(google-explicit-constructor, hicpp-explicit-conversions)
constexpr explicit(false) operator T() && noexcept(std::is_nothrow_move_constructible_v<T>)
{
return std::move(value_);
@@ -96,14 +97,14 @@ public:
#endif
constexpr T& value() & noexcept = delete;
constexpr const T& value() const& noexcept { return value_; }
constexpr T&& value() && noexcept { return std::move(value_); }
constexpr const T&& value() const&& noexcept { return std::move(value_); }
[[nodiscard]] constexpr const T& value() const& noexcept { return value_; }
[[nodiscard]] constexpr T&& value() && noexcept { return std::move(value_); }
[[nodiscard]] constexpr const T&& value() const&& noexcept { return std::move(value_); }
bool operator==(const validated_type&) const
[[nodiscard]] bool operator==(const validated_type&) const
requires std::equality_comparable<T>
= default;
auto operator<=>(const validated_type&) const
[[nodiscard]] auto operator<=>(const validated_type&) const
requires std::three_way_comparable<T>
= default;
};