From c758cb37e628bb17148d797c0e20623aa9349506 Mon Sep 17 00:00:00 2001
From: jvocht <joern.seaman_bp@mailbox.org>
Date: Sat, 4 Jan 2025 16:32:30 +0100
Subject: [PATCH 1/3] Add static tests for concept DimensionOf

---
 test/static/concepts_test.cpp | 17 ++++++++++++++++-
 1 file changed, 16 insertions(+), 1 deletion(-)

diff --git a/test/static/concepts_test.cpp b/test/static/concepts_test.cpp
index 154e8352..7ae6c077 100644
--- a/test/static/concepts_test.cpp
+++ b/test/static/concepts_test.cpp
@@ -82,7 +82,22 @@ static_assert(!Dimension<struct si::metre>);
 static_assert(!Dimension<int>);
 
 // DimensionOf
-// TODO add tests
+inline constexpr struct isq::dim_length tdimlength;
+inline constexpr struct isq::dim_time tdimtime;
+inline constexpr struct isq::length tlength;
+inline constexpr struct isq::time ttime;
+static_assert(DimensionOf<struct isq::dim_length, tdimlength>);
+static_assert(!DimensionOf<struct isq::dim_length, tdimtime>);
+static_assert(!DimensionOf<struct isq::dim_length, tlength>);
+static_assert(!DimensionOf<struct isq::dim_length, ttime>);
+static_assert(!DimensionOf<struct isq::dim_time, tdimlength>);
+static_assert(!DimensionOf<struct isq::dim_time, tlength>);
+static_assert(!DimensionOf<struct isq::length, tdimlength>);
+static_assert(!DimensionOf<struct isq::length, tdimtime>);
+static_assert(!DimensionOf<struct isq::length, tlength>);
+static_assert(!DimensionOf<struct isq::length, ttime>);
+static_assert(!DimensionOf<struct isq::time, tdimlength>);
+static_assert(!DimensionOf<struct isq::time, tlength>);
 
 // QuantitySpec
 inline constexpr auto speed = isq::length / isq::time;

From f6940e224c16312bf3251ca3b04962fc6e10fb05 Mon Sep 17 00:00:00 2001
From: jvocht <joern.seaman_bp@mailbox.org>
Date: Sat, 11 Jan 2025 17:31:03 +0100
Subject: [PATCH 2/3] Add new tests for base dimension of quanties of the same
 kind and for derived dimensions. Remove temporary helper objects.

---
 test/static/concepts_test.cpp | 33 +++++++++++++++++----------------
 1 file changed, 17 insertions(+), 16 deletions(-)

diff --git a/test/static/concepts_test.cpp b/test/static/concepts_test.cpp
index 7ae6c077..3ce96bcc 100644
--- a/test/static/concepts_test.cpp
+++ b/test/static/concepts_test.cpp
@@ -82,22 +82,23 @@ static_assert(!Dimension<struct si::metre>);
 static_assert(!Dimension<int>);
 
 // DimensionOf
-inline constexpr struct isq::dim_length tdimlength;
-inline constexpr struct isq::dim_time tdimtime;
-inline constexpr struct isq::length tlength;
-inline constexpr struct isq::time ttime;
-static_assert(DimensionOf<struct isq::dim_length, tdimlength>);
-static_assert(!DimensionOf<struct isq::dim_length, tdimtime>);
-static_assert(!DimensionOf<struct isq::dim_length, tlength>);
-static_assert(!DimensionOf<struct isq::dim_length, ttime>);
-static_assert(!DimensionOf<struct isq::dim_time, tdimlength>);
-static_assert(!DimensionOf<struct isq::dim_time, tlength>);
-static_assert(!DimensionOf<struct isq::length, tdimlength>);
-static_assert(!DimensionOf<struct isq::length, tdimtime>);
-static_assert(!DimensionOf<struct isq::length, tlength>);
-static_assert(!DimensionOf<struct isq::length, ttime>);
-static_assert(!DimensionOf<struct isq::time, tdimlength>);
-static_assert(!DimensionOf<struct isq::time, tlength>);
+static_assert(DimensionOf<struct isq::dim_length, isq::dim_length>);
+static_assert(DimensionOf<struct isq::dim_length, isq::height.dimension>);
+static_assert(DimensionOf<struct isq::dim_length, isq::radius.dimension>);
+static_assert(!DimensionOf<struct isq::dim_length, isq::length>);
+static_assert(!DimensionOf<struct isq::length, isq::dim_length>);
+static_assert(!DimensionOf<struct isq::length, isq::length>);
+static_assert(!DimensionOf<struct isq::dim_length, isq::dim_time>);
+static_assert(!DimensionOf<struct isq::dim_length, isq::time>);
+static_assert(!DimensionOf<struct isq::dim_time, isq::dim_length>);
+static_assert(!DimensionOf<struct isq::dim_time, isq::length>);
+static_assert(!DimensionOf<struct isq::length, isq::dim_time>);
+static_assert(!DimensionOf<struct isq::length, isq::time>);
+static_assert(!DimensionOf<struct isq::time, isq::dim_length>);
+static_assert(!DimensionOf<struct isq::time, isq::length>);
+static_assert(DimensionOf<decltype(isq::dim_length / isq::dim_time), isq::speed.dimension>);
+static_assert(DimensionOf<decltype(isq::force.dimension * isq::time.dimension), isq::impulse.dimension>);
+static_assert(DimensionOf<decltype(isq::angular_momentum.dimension / isq::angular_velocity.dimension), isq::moment_of_inertia.dimension>);
 
 // QuantitySpec
 inline constexpr auto speed = isq::length / isq::time;

From 44cbf820126d25586623fcd8bb8047474b062efb Mon Sep 17 00:00:00 2001
From: jvocht <joern.seaman_bp@mailbox.org>
Date: Sat, 11 Jan 2025 17:41:56 +0100
Subject: [PATCH 3/3] Fix clang-format error caused by missing to run
 pre-commit.

---
 test/static/concepts_test.cpp | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/test/static/concepts_test.cpp b/test/static/concepts_test.cpp
index 3ce96bcc..268d19cc 100644
--- a/test/static/concepts_test.cpp
+++ b/test/static/concepts_test.cpp
@@ -98,7 +98,8 @@ static_assert(!DimensionOf<struct isq::time, isq::dim_length>);
 static_assert(!DimensionOf<struct isq::time, isq::length>);
 static_assert(DimensionOf<decltype(isq::dim_length / isq::dim_time), isq::speed.dimension>);
 static_assert(DimensionOf<decltype(isq::force.dimension * isq::time.dimension), isq::impulse.dimension>);
-static_assert(DimensionOf<decltype(isq::angular_momentum.dimension / isq::angular_velocity.dimension), isq::moment_of_inertia.dimension>);
+static_assert(DimensionOf<decltype(isq::angular_momentum.dimension / isq::angular_velocity.dimension),
+                          isq::moment_of_inertia.dimension>);
 
 // QuantitySpec
 inline constexpr auto speed = isq::length / isq::time;