feedc0de/mp-units
1
0
Fork 0
forked from mpusz/mp-units
Code Pull Requests Activity

fabs() removed as abs() is enough

Browse Source
This commit is contained in:
Mateusz Pusz
2020-05-06 18:17:49 +02:00
parent a8ca425e2d
commit ac0f10184c
2 changed files with 21 additions and 17 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
src/include/units/math.h
View File

@@ -59,12 +59,6 @@ constexpr Quantity AUTO abs(const quantity<D, U, Rep>& q) noexcept
return quantity<D, U, Rep>(std::abs(q.count())); return quantity<D, U, Rep>(std::abs(q.count()));
} }
template<typename D, typename U, typename Rep>
constexpr Quantity AUTO fabs(const quantity<D, U, Rep>& q) noexcept
{
return quantity<D, U, Rep>(std::fabs(q.count()));
}
template<Quantity Q> template<Quantity Q>
constexpr Quantity AUTO epsilon() noexcept constexpr Quantity AUTO epsilon() noexcept
{ {

24
test/unit_test/runtime/math_test.cpp
View File

@@ -56,20 +56,30 @@ TEST_CASE("'sqrt()' on quantity changes the value and the dimension accordingly"
TEST_CASE("absolute functions on quantity returns the absolute value", "[math][abs][fabs]") TEST_CASE("absolute functions on quantity returns the absolute value", "[math][abs][fabs]")
{ {
SECTION ("'abs()' on a negative quantity returns the abs") { SECTION ("'abs()' on a negative quantity returns the abs")
{
SECTION ("integral representation")
{
REQUIRE(abs(-1q_m) == 1q_m); REQUIRE(abs(-1q_m) == 1q_m);
} }
SECTION ("'abs()' on a positive quantity returns the abs") { SECTION ("floating-point representation")
{
REQUIRE(abs(-1.q_m) == 1q_m);
}
}
SECTION ("'abs()' on a positive quantity returns the abs")
{
SECTION ("integral representation")
{
REQUIRE(abs(1q_m) == 1q_m); REQUIRE(abs(1q_m) == 1q_m);
} }
SECTION ("'fabs()' on a negative quantity returns the abs") { SECTION ("floating-point representation")
REQUIRE(fabs(-1.q_m) == 1.q_m); {
REQUIRE(abs(1.q_m) == 1q_m);
} }
SECTION ("'fabs()' on a positive quantity returns the abs") {
REQUIRE(fabs(1.q_m) == 1.q_m);
} }
} }