feedc0de/mp-units
1
0
Fork 0
forked from mpusz/mp-units
Code Pull Requests Activity

Remove redundant inline specifiers

Browse Source 
`static constexpr` implies `inline`; see:
https://stackoverflow.com/a/57407675
This commit is contained in:
Chip Hogg
2021-12-31 09:54:10 -05:00
parent 998266e780
commit cef01ba67c
1 changed files with 6 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
src/core/include/units/magnitude.h
View File

@@ -42,7 +42,7 @@ namespace units::mag
template<typename Base, ratio Power = ratio{1}> template<typename Base, ratio Power = ratio{1}>
struct base_power { struct base_power {
using base = Base; using base = Base;
static inline constexpr ratio power = Power; static constexpr ratio power = Power;
}; };
/** /**
@@ -147,7 +147,7 @@ constexpr auto make_base_power() {
* @brief A base to represent pi. * @brief A base to represent pi.
*/ */
struct pi { struct pi {
static inline constexpr long double value = std::numbers::pi_v<long double>; static constexpr long double value = std::numbers::pi_v<long double>;
}; };
//////////////////////////////////////////////////////////////////////////////////////////////////////////////////////// ////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////
@@ -261,7 +261,7 @@ struct product<magnitude<base_power<Base, Pow1>, Tail1...>,
magnitude<base_power<Base, Pow2>, Tail2...>> magnitude<base_power<Base, Pow2>, Tail2...>>
{ {
using tail_product = product_t<magnitude<Tail1...>, magnitude<Tail2...>>; using tail_product = product_t<magnitude<Tail1...>, magnitude<Tail2...>>;
static inline constexpr auto Pow = Pow1 + Pow2; static constexpr auto Pow = Pow1 + Pow2;
using type = std::conditional_t< using type = std::conditional_t<
Pow.num == 0, Pow.num == 0,
tail_product, tail_product,
@@ -318,9 +318,9 @@ template<std::intmax_t N>
struct prime_factorization { struct prime_factorization {
static_assert(N > 1, "Can only factor positive integers."); static_assert(N > 1, "Can only factor positive integers.");
static inline constexpr std::intmax_t first_base = find_first_factor(N); static constexpr std::intmax_t first_base = find_first_factor(N);
static inline constexpr std::intmax_t first_power = multiplicity(first_base, N); static constexpr std::intmax_t first_power = multiplicity(first_base, N);
static inline constexpr std::intmax_t remainder = remove_power(first_base, first_power, N); static constexpr std::intmax_t remainder = remove_power(first_base, first_power, N);
using type = product_t< using type = product_t<
magnitude<base_power<prime_base<first_base>, ratio{first_power}>>, prime_factorization_t<remainder>>; magnitude<base_power<prime_base<first_base>, ratio{first_power}>>, prime_factorization_t<remainder>>;