feedc0de/mp-units
1
0
Fork 0
forked from mpusz/mp-units
Code Pull Requests Activity

Attempt to satisfy MSVC 14

Browse Source 
```
test\unit_test\runtime\magnitude_test.cpp(143): error C2672:
'units::check_same_type_and_value': no matching overloaded function
found
```

Maybe it's confused by accessing the static member variable template
using dot-notation on an _instance_?  If so, let's see how it likes the
member-function syntax.
This commit is contained in:
Chip Hogg
2022-01-28 22:42:23 +00:00
parent 811b6ba53d
commit d6eb25f07a
2 changed files with 23 additions and 18 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
src/core/include/units/magnitude.h
View File

@@ -339,6 +339,11 @@ struct magnitude {
requires (std::is_floating_point_v<T> || (detail::is_integral(BPs) && ...)) requires (std::is_floating_point_v<T> || (detail::is_integral(BPs) && ...))
static constexpr T value = detail::checked_static_cast<T>( static constexpr T value = detail::checked_static_cast<T>(
(detail::compute_base_power<T>(BPs) * ...)); (detail::compute_base_power<T>(BPs) * ...));
// Trying to satisfy MSVC 14...
template<typename T>
requires (std::is_floating_point_v<T> || (detail::is_integral(BPs) && ...))
constexpr T get_value() const { return magnitude::value<T>; }
}; };
// Implementation for Magnitude concept (below). // Implementation for Magnitude concept (below).

36
test/unit_test/runtime/magnitude_test.cpp
View File

@@ -140,25 +140,25 @@ TEST_CASE("magnitude converts to numerical value")
SECTION("Positive integer powers of integer bases give integer values") SECTION("Positive integer powers of integer bases give integer values")
{ {
constexpr auto mag_412 = as_magnitude<412>(); constexpr auto mag_412 = as_magnitude<412>();
check_same_type_and_value(mag_412.value<int>, 412); check_same_type_and_value(mag_412.get_value<int>(), 412);
check_same_type_and_value(mag_412.value<std::size_t>, std::size_t{412}); check_same_type_and_value(mag_412.get_value<std::size_t>(), std::size_t{412});
check_same_type_and_value(mag_412.value<float>, 412.0f); check_same_type_and_value(mag_412.get_value<float>(), 412.0f);
check_same_type_and_value(mag_412.value<double>, 412.0); check_same_type_and_value(mag_412.get_value<double>(), 412.0);
} }
SECTION("Negative integer powers of integer bases compute correct values") SECTION("Negative integer powers of integer bases compute correct values")
{ {
constexpr auto mag_0p125 = as_magnitude<ratio{1, 8}>(); constexpr auto mag_0p125 = as_magnitude<ratio{1, 8}>();
check_same_type_and_value(mag_0p125.value<float>, 0.125f); check_same_type_and_value(mag_0p125.get_value<float>(), 0.125f);
check_same_type_and_value(mag_0p125.value<double>, 0.125); check_same_type_and_value(mag_0p125.get_value<double>(), 0.125);
} }
SECTION("pi to the 1 supplies correct values") SECTION("pi to the 1 supplies correct values")
{ {
constexpr auto pi = pi_to_the<1>(); constexpr auto pi = pi_to_the<1>();
check_same_type_and_value(pi.value<float>, std::numbers::pi_v<float>); check_same_type_and_value(pi.get_value<float>(), std::numbers::pi_v<float>);
check_same_type_and_value(pi.value<double>, std::numbers::pi_v<double>); check_same_type_and_value(pi.get_value<double>(), std::numbers::pi_v<double>);
check_same_type_and_value(pi.value<long double>, std::numbers::pi_v<long double>); check_same_type_and_value(pi.get_value<long double>(), std::numbers::pi_v<long double>);
} }
SECTION("pi to arbitrary power performs computations in most accurate type at compile time") SECTION("pi to arbitrary power performs computations in most accurate type at compile time")
@@ -170,7 +170,7 @@ TEST_CASE("magnitude converts to numerical value")
constexpr auto via_float = cube(std::numbers::pi_v<float>); constexpr auto via_float = cube(std::numbers::pi_v<float>);
constexpr auto via_long_double = static_cast<float>(cube(std::numbers::pi_v<long double>)); constexpr auto via_long_double = static_cast<float>(cube(std::numbers::pi_v<long double>));
constexpr auto pi_cubed_value = pi_cubed.value<float>; constexpr auto pi_cubed_value = pi_cubed.get_value<float>();
REQUIRE(pi_cubed_value != via_float); REQUIRE(pi_cubed_value != via_float);
CHECK(pi_cubed_value == via_long_double); CHECK(pi_cubed_value == via_long_double);
} }
@@ -181,22 +181,22 @@ TEST_CASE("magnitude converts to numerical value")
// Naturally, we cannot actually write a test to verify a compiler error. But any of these can // Naturally, we cannot actually write a test to verify a compiler error. But any of these can
// be uncommented if desired to verify that it breaks the build. // be uncommented if desired to verify that it breaks the build.
// (void)as_magnitude<412>().value<int8_t>; // (void)as_magnitude<412>().get_value<int8_t>();
// Would work for pow<62>: // Would work for pow<62>:
// (void)pow<63>(as_magnitude<2>()).value<int64_t>; // (void)pow<63>(as_magnitude<2>()).get_value<int64_t>();
// Would work for pow<63>: // Would work for pow<63>:
// (void)pow<64>(as_magnitude<2>()).value<uint64_t>; // (void)pow<64>(as_magnitude<2>()).get_value<uint64_t>();
(void)pow<308>(as_magnitude<10>()).value<double>; // Compiles, correctly. (void)pow<308>(as_magnitude<10>()).get_value<double>(); // Compiles, correctly.
// (void)pow<309>(as_magnitude<10>()).value<double>; // (void)pow<309>(as_magnitude<10>()).get_value<double>();
// (void)pow<3099>(as_magnitude<10>()).value<double>; // (void)pow<3099>(as_magnitude<10>()).get_value<double>();
// (void)pow<3099999>(as_magnitude<10>()).value<double>; // (void)pow<3099999>(as_magnitude<10>()).get_value<double>();
auto sqrt_2 = pow<ratio{1, 2}>(as_magnitude<2>()); auto sqrt_2 = pow<ratio{1, 2}>(as_magnitude<2>());
CHECK(!is_integral(sqrt_2)); CHECK(!is_integral(sqrt_2));
// (void)sqrt_2.value<int>; // (void)sqrt_2.get_value<int>();
} }
} }