feedc0de/mp-units
1
0
Fork 0
forked from mpusz/mp-units
Code Pull Requests Activity

Use in_range for integer case

Browse Source
This commit is contained in:
Chip Hogg
2022-01-28 20:32:47 +00:00
parent e3a790667d
commit f2ba3cc18a
1 changed files with 1 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
src/core/include/units/magnitude.h
View File

@@ -196,8 +196,7 @@ constexpr To checked_static_cast(From x) {
// This function should only ever be called at compile time. The purpose of these exceptions is // This function should only ever be called at compile time. The purpose of these exceptions is
// to produce compiler errors, because we cannot `static_assert` on function arguments. // to produce compiler errors, because we cannot `static_assert` on function arguments.
if constexpr (std::is_integral_v<To>) { if constexpr (std::is_integral_v<To>) {
if (std::cmp_less(x, std::numeric_limits<To>::min()) || if (!std::in_range<To>(x)) {
std::cmp_greater(x, std::numeric_limits<To>::max())) {
throw std::invalid_argument{"Cannot represent magnitude in this type"}; throw std::invalid_argument{"Cannot represent magnitude in this type"};
} }
} else { } else {