From 9f053ca4e19f6cb8afc9880e52f7c02b9eb4fa69 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?S=C3=A9bastien=20Han?= Date: Fri, 18 Oct 2019 15:41:46 +0200 Subject: [PATCH] ceph: osd remove --conf flag MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Even legacy osds were still running with this flag. In my previous patch I was trying to minimize the impact of the change and was afraid the config file was holding important information but that appears not to be true. The only option in the config could have the keyring path, but it's passed in the CLI startup line. Closes: https://github.com/rook/rook/issues/4063 Signed-off-by: Sébastien Han --- pkg/operator/ceph/cluster/osd/spec.go | 1 - 1 file changed, 1 deletion(-) diff --git a/pkg/operator/ceph/cluster/osd/spec.go b/pkg/operator/ceph/cluster/osd/spec.go index cbb1dda79..e2a66e60c 100644 --- a/pkg/operator/ceph/cluster/osd/spec.go +++ b/pkg/operator/ceph/cluster/osd/spec.go @@ -181,7 +181,6 @@ func (c *Cluster) makeDeployment(osdProps osdProperties, osd OSDInfo) (*apps.Dep defaultArgs := []string{ "--foreground", "--id", osdID, - "--conf", osd.Config, "--osd-data", osd.DataPath, "--keyring", osd.KeyringPath, "--cluster", osd.Cluster,