From 206e45facdd0d374eafb57053059b74a49e84bc3 Mon Sep 17 00:00:00 2001 From: Satoru Takeuchi Date: Wed, 27 May 2020 05:20:24 +0900 Subject: [PATCH] ceph: fix the wrong condition in the cluster health check There are the following problems in the cluster health check. - If the cluster is healthy: Unnecessary long time before exiting from the health check loop. The test succeeds thanks to the succeeding assertion by luck. - If the cluster is unhealthy: Exit from the health check loop immediately. The test fails in the succeeding assertion by luck too. It's a regression that is introduced in the following commit. https://github.com/rook/rook/commit/c0c0dc4ed977a6b373b1884c5b76c9588f0be077 Signed-off-by: Satoru Takeuchi --- tests/integration/ceph_base_deploy_test.go | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/integration/ceph_base_deploy_test.go b/tests/integration/ceph_base_deploy_test.go index 84271e7e9..41125dab2 100644 --- a/tests/integration/ceph_base_deploy_test.go +++ b/tests/integration/ceph_base_deploy_test.go @@ -74,7 +74,7 @@ func checkIfRookClusterIsHealthy(s suite.Suite, testClient *clients.TestClient, retryCount := 0 for retryCount < utils.RetryLoop { healthy, err := clients.IsClusterHealthy(testClient, clusterNamespace) - if !healthy { + if healthy { logger.Infof("cluster %s is healthy", clusterNamespace) return }