ci: fix shellcheck issues in composite actions
actionlint only understands workflow files, so the .github/actionlint.yaml
ignore keeps the composite action definitions out of `make lint.workflows`.
Apply the same shellcheck fixes there anyway, found by running shellcheck over
their run: blocks directly:
- quote unquoted variable expansions (SC2086): the $GITHUB_ENV writes in
collect-logs, tmate_debug and upterm_debug, and ${ARCH} in the cri-dockerd
install in integration-test-setup-cluster-resources
- split `export BLOCK=$(...)` into a separate assignment and export so a
failing command substitution is not masked (SC2155) in
encryption-pvc-kms-ibm-kp
Signed-off-by: Joshua Hoblitt <josh@hoblitt.com>
(cherry picked from commit 48dacb1894)
This commit is contained in:
1 parent
046d907dbb
commit
2f99677dee
5 files changed
+8
-7
No files matched your search
@@ -28,9 +28,9 @@ runs:
|
||||
ARCH=$(go env GOARCH)
|
||||
# --fail so an HTTP error page is not saved as the .deb (dpkg then fails on the
|
||||
# corrupt archive), and retry transient download errors
|
||||
curl -fLO --retry 5 --retry-all-errors --retry-delay 10 https://github.com/Mirantis/cri-dockerd/releases/download/v0.3.21/cri-dockerd_0.3.21.3-0.ubuntu-focal_${ARCH}.deb
|
||||
sudo dpkg -i cri-dockerd_0.3.21.3-0.ubuntu-focal_${ARCH}.deb
|
||||
rm -f cri-dockerd_0.3.21.3-0.ubuntu-focal_${ARCH}.deb
|
||||
curl -fLO --retry 5 --retry-all-errors --retry-delay 10 https://github.com/Mirantis/cri-dockerd/releases/download/v0.3.21/cri-dockerd_0.3.21.3-0.ubuntu-focal_"${ARCH}".deb
|
||||
sudo dpkg -i cri-dockerd_0.3.21.3-0.ubuntu-focal_"${ARCH}".deb
|
||||
rm -f cri-dockerd_0.3.21.3-0.ubuntu-focal_"${ARCH}".deb
|
||||
|
||||
- name: Setup Minikube
|
||||
uses: medyagh/setup-minikube@latest
|
||||
|
||||
Reference in new issue
Block a user