Merge pull request #10699 from subhamkrai/upgrade-to-ubuntu22.04

ci: ubuntu 18.04 is deprecated upgrade to ubuntu 20.04

.github/workflows/build.yml

@@ -90,7 +90,7 @@ jobs:
         timeout-minutes: 60
 
   linux-build-all:
-    runs-on: ubuntu-18.04
+    runs-on: ubuntu-20.04
     if: "!contains(github.event.pull_request.labels.*.name, 'skip-ci')"
     strategy:
       fail-fast: false

.github/workflows/canary-test-config/action.yaml

@@ -14,9 +14,9 @@ runs:
         go-version: 1.18
 
     - name: setup minikube
-      uses: manusa/actions-setup-minikube@v2.6.0
+      uses: manusa/actions-setup-minikube@v2.7.0
       with:
-        minikube version: "v1.24.0"
+        minikube version: "v1.26.1"
         kubernetes version: "v1.23.0"
         start args: --memory 6g --cpus=2 --addons ingress --cni=calico
         github token: ${{ inputs.github-token }}

.github/workflows/codegen.yml

@@ -26,25 +26,25 @@ permissions:
 
 jobs:
   codegen:
-    runs-on: ubuntu-18.04
+    runs-on: ubuntu-20.04
     if: "!contains(github.event.pull_request.labels.*.name, 'skip-ci')"
     steps:
-    - uses: actions/setup-go@v2
-      with:
-        go-version: 1.19
+      - uses: actions/setup-go@v2
+        with:
+          go-version: 1.19
 
-    - name: checkout
-      uses: actions/checkout@v2
-      with:
-        fetch-depth: 0
+      - name: checkout
+        uses: actions/checkout@v2
+        with:
+          fetch-depth: 0
 
-    - name: copy working directory to GOPATH
-      run: sudo mkdir -p /home/runner/go/src/github.com && sudo cp -a /home/runner/work/rook /home/runner/go/src/github.com/
+      - name: copy working directory to GOPATH
+        run: sudo mkdir -p /home/runner/go/src/github.com && sudo cp -a /home/runner/work/rook /home/runner/go/src/github.com/
 
-    - name: run codegen
-      working-directory: /home/runner/go/src/github.com/rook/rook
-      run: GOPATH=$(go env GOPATH) make codegen
+      - name: run codegen
+        working-directory: /home/runner/go/src/github.com/rook/rook
+        run: GOPATH=$(go env GOPATH) make codegen
 
-    - name: validate codegen
-      working-directory: /home/runner/go/src/github.com/rook/rook
-      run: tests/scripts/validate_modified_files.sh codegen
+      - name: validate codegen
+        working-directory: /home/runner/go/src/github.com/rook/rook
+        run: tests/scripts/validate_modified_files.sh codegen

.github/workflows/codespell.yaml

@@ -22,7 +22,7 @@ permissions:
 jobs:
   codespell:
     name: codespell
-    runs-on: ubuntu-18.04
+    runs-on: ubuntu-20.04
     steps:
       - uses: actions/checkout@v2
         with:

.github/workflows/commitlint.yml

@@ -18,7 +18,7 @@ concurrency:
 
 jobs:
   lint:
-    runs-on: ubuntu-18.04
+    runs-on: ubuntu-20.04
     env:
       GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
     steps:

.github/workflows/crds-gen.yml

@@ -26,24 +26,24 @@ permissions:
 
 jobs:
   crds-gen:
-    runs-on: ubuntu-18.04
+    runs-on: ubuntu-20.04
     steps:
-    - uses: actions/setup-go@v2
-      with:
-        go-version: 1.18
+      - uses: actions/setup-go@v2
+        with:
+          go-version: 1.18
 
-    - name: checkout
-      uses: actions/checkout@v2
-      with:
-        fetch-depth: 0
+      - name: checkout
+        uses: actions/checkout@v2
+        with:
+          fetch-depth: 0
 
-    - name: copy working directory to GOPATH
-      run: sudo mkdir -p /home/runner/go/src/github.com && sudo cp -a /home/runner/work/rook /home/runner/go/src/github.com/
+      - name: copy working directory to GOPATH
+        run: sudo mkdir -p /home/runner/go/src/github.com && sudo cp -a /home/runner/work/rook /home/runner/go/src/github.com/
 
-    - name: run crds-gen
-      working-directory: /home/runner/go/src/github.com/rook/rook
-      run: GOPATH=$(go env GOPATH) make crds
+      - name: run crds-gen
+        working-directory: /home/runner/go/src/github.com/rook/rook
+        run: GOPATH=$(go env GOPATH) make crds
 
-    - name: validate crds-gen
-      working-directory: /home/runner/go/src/github.com/rook/rook
-      run: tests/scripts/validate_modified_files.sh crd
+      - name: validate crds-gen
+        working-directory: /home/runner/go/src/github.com/rook/rook
+        run: tests/scripts/validate_modified_files.sh crd

.github/workflows/create-tag.yaml

@@ -3,7 +3,7 @@ on:
   workflow_dispatch:
     inputs:
       version:
-        description: 'Release version (e.g. v1.7.0)'
+        description: "Release version (e.g. v1.7.0)"
         required: true
 
 defaults:
@@ -13,7 +13,7 @@ defaults:
 
 jobs:
   Create-Tag:
-    runs-on: ubuntu-18.04
+    runs-on: ubuntu-20.04
     if: github.repository == 'rook/rook' && contains('travisn,leseb,BlaineEXE,jbw976,galexrt,satoru-takeuchi', github.actor)
     steps:
       - name: checkout

.github/workflows/daily-nightly-jobs.yml

@@ -91,7 +91,7 @@ jobs:
 
   smoke-suite-pacific-devel:
     if: github.repository == 'rook/rook'
-    runs-on: ubuntu-18.04
+    runs-on: ubuntu-20.04
     steps:
       - name: checkout
         uses: actions/checkout@v2
@@ -99,7 +99,7 @@ jobs:
           fetch-depth: 0
 
       - name: setup cluster resources
-        uses: ./.github/workflows/integration-test-config
+        uses: ./.github/workflows/integration-test-config-latest-k8s
         with:
           github-token: ${{ secrets.GITHUB_TOKEN }}
           kubernetes-version: "1.24.1"
@@ -126,7 +126,7 @@ jobs:
 
   smoke-suite-quincy-devel:
     if: github.repository == 'rook/rook'
-    runs-on: ubuntu-18.04
+    runs-on: ubuntu-20.04
     steps:
       - name: checkout
         uses: actions/checkout@v2
@@ -134,7 +134,7 @@ jobs:
           fetch-depth: 0
 
       - name: setup cluster resources
-        uses: ./.github/workflows/integration-test-config
+        uses: ./.github/workflows/integration-test-config-latest-k8s
         with:
           github-token: ${{ secrets.GITHUB_TOKEN }}
           kubernetes-version: "1.24.1"
@@ -161,7 +161,7 @@ jobs:
 
   smoke-suite-ceph-master:
     if: github.repository == 'rook/rook'
-    runs-on: ubuntu-18.04
+    runs-on: ubuntu-20.04
     steps:
       - name: checkout
         uses: actions/checkout@v2
@@ -169,7 +169,7 @@ jobs:
           fetch-depth: 0
 
       - name: setup cluster resources
-        uses: ./.github/workflows/integration-test-config
+        uses: ./.github/workflows/integration-test-config-latest-k8s
         with:
           github-token: ${{ secrets.GITHUB_TOKEN }}
           kubernetes-version: "1.24.1"
@@ -196,7 +196,7 @@ jobs:
 
   object-suite-pacific-devel:
     if: github.repository == 'rook/rook'
-    runs-on: ubuntu-18.04
+    runs-on: ubuntu-20.04
     steps:
       - name: checkout
         uses: actions/checkout@v2
@@ -204,7 +204,7 @@ jobs:
           fetch-depth: 0
 
       - name: setup cluster resources
-        uses: ./.github/workflows/integration-test-config
+        uses: ./.github/workflows/integration-test-config-latest-k8s
         with:
           github-token: ${{ secrets.GITHUB_TOKEN }}
           kubernetes-version: "1.24.1"
@@ -231,7 +231,7 @@ jobs:
 
   object-suite-master:
     if: github.repository == 'rook/rook'
-    runs-on: ubuntu-18.04
+    runs-on: ubuntu-20.04
     steps:
       - name: checkout
         uses: actions/checkout@v2
@@ -239,7 +239,7 @@ jobs:
           fetch-depth: 0
 
       - name: setup cluster resources
-        uses: ./.github/workflows/integration-test-config
+        uses: ./.github/workflows/integration-test-config-latest-k8s
         with:
           github-token: ${{ secrets.GITHUB_TOKEN }}
           kubernetes-version: "1.24.1"
@@ -266,7 +266,7 @@ jobs:
 
   upgrade-from-pacific-stable-to-pacific-devel:
     if: github.repository == 'rook/rook'
-    runs-on: ubuntu-18.04
+    runs-on: ubuntu-20.04
     steps:
       - name: checkout
         uses: actions/checkout@v2
@@ -274,7 +274,7 @@ jobs:
           fetch-depth: 0
 
       - name: setup cluster resources
-        uses: ./.github/workflows/integration-test-config
+        uses: ./.github/workflows/integration-test-config-latest-k8s
         with:
           github-token: ${{ secrets.GITHUB_TOKEN }}
           kubernetes-version: "1.24.1"
@@ -301,7 +301,7 @@ jobs:
 
   upgrade-from-quincy-stable-to-quincy-devel:
     if: github.repository == 'rook/rook'
-    runs-on: ubuntu-18.04
+    runs-on: ubuntu-20.04
     steps:
       - name: checkout
         uses: actions/checkout@v2
@@ -309,7 +309,7 @@ jobs:
           fetch-depth: 0
 
       - name: setup cluster resources
-        uses: ./.github/workflows/integration-test-config
+        uses: ./.github/workflows/integration-test-config-latest-k8s
         with:
           github-token: ${{ secrets.GITHUB_TOKEN }}
           kubernetes-version: "1.24.1"
@@ -336,15 +336,11 @@ jobs:
 
   rgw-multisite-test-with-ceph-devel:
     if: github.repository == 'rook/rook'
-    runs-on: ubuntu-18.04
+    runs-on: ubuntu-20.04
     strategy:
       matrix:
         ceph-image-tag:
-          [
-            "latest-master-devel",
-            "latest-quincy-devel",
-            "latest-pacific-devel",
-          ]
+          ["latest-master-devel", "latest-quincy-devel", "latest-pacific-devel"]
 
     steps:
       - uses: actions/checkout@v2
@@ -366,7 +362,7 @@ jobs:
 
   encryption-pvc-kms-ibm-kp:
     if: github.repository == 'rook/rook'
-    runs-on: ubuntu-18.04
+    runs-on: ubuntu-20.04
     steps:
       - uses: actions/checkout@v2
         with:

.github/workflows/docs-check.yml

@@ -19,7 +19,7 @@ concurrency:
 jobs:
   docs-check:
     name: docs-check
-    runs-on: ubuntu-18.04
+    runs-on: ubuntu-20.04
     steps:
       - uses: actions/checkout@v2
         with:

.github/workflows/golangci-lint.yaml

@@ -22,7 +22,7 @@ permissions:
 jobs:
   golangci:
     name: golangci-lint
-    runs-on: ubuntu-18.04
+    runs-on: ubuntu-20.04
     steps:
       - uses: actions/setup-go@v2
         with:

.github/workflows/integration-test-config-latest-k8s/action.yaml

@@ -0,0 +1,38 @@
+name: Cluster Setup
+description: Cluster setup for integration test
+inputs:
+  kubernetes-version:
+    description: kubernetes version to use for the workflow
+    required: true
+  github-token:
+    description: GITHUB_TOKEN from the calling workflow
+    required: true
+
+runs:
+  using: "composite"
+  steps:
+    - name: setup golang
+      uses: actions/setup-go@v2
+      with:
+        go-version: 1.18
+
+    - name: setup minikube
+      uses: manusa/actions-setup-minikube@v2.7.0
+      with:
+        minikube version: "v1.26.1"
+        kubernetes version: ${{ inputs.kubernetes-version }}
+        start args: --memory 6g --cpus=2 --addons ingress
+        github token: ${{ inputs.github-token }}
+
+    - name: print k8s cluster status
+      shell: bash --noprofile --norc -eo pipefail -x {0}
+      run: tests/scripts/github-action-helper.sh print_k8s_cluster_status
+
+    # This step is required for all the integration tests except the canary tests
+    - name: use local disk
+      shell: bash --noprofile --norc -eo pipefail -x {0}
+      run: tests/scripts/github-action-helper.sh use_local_disk_for_integration_test
+
+    - name: build rook
+      shell: bash --noprofile --norc -eo pipefail -x {0}
+      run: tests/scripts/github-action-helper.sh build_rook

.github/workflows/integration-test-config-older-k8s/action.yaml

@@ -0,0 +1,38 @@
+name: Cluster Setup
+description: Cluster setup for integration test
+inputs:
+  kubernetes-version:
+    description: kubernetes version to use for the workflow
+    required: true
+  github-token:
+    description: GITHUB_TOKEN from the calling workflow
+    required: true
+
+runs:
+  using: "composite"
+  steps:
+    - name: setup golang
+      uses: actions/setup-go@v2
+      with:
+        go-version: 1.18
+
+    - name: setup minikube
+      uses: manusa/actions-setup-minikube@v2.6.1
+      with:
+        minikube version: "v1.24.0"
+        kubernetes version: ${{ inputs.kubernetes-version }}
+        start args: --memory 6g --cpus=2 --addons ingress
+        github token: ${{ inputs.github-token }}
+
+    - name: print k8s cluster status
+      shell: bash --noprofile --norc -eo pipefail -x {0}
+      run: tests/scripts/github-action-helper.sh print_k8s_cluster_status
+
+    # This step is required for all the integration tests except the canary tests
+    - name: use local disk
+      shell: bash --noprofile --norc -eo pipefail -x {0}
+      run: tests/scripts/github-action-helper.sh use_local_disk_for_integration_test
+
+    - name: build rook
+      shell: bash --noprofile --norc -eo pipefail -x {0}
+      run: tests/scripts/github-action-helper.sh build_rook

.github/workflows/integration-test-config/action.yaml

@@ -1,38 +0,0 @@
-name: Cluster Setup
-description: Cluster setup for integration test
-inputs:
-  kubernetes-version:
-    description: kubernetes version to use for the workflow
-    required: true
-  github-token:
-    description: GITHUB_TOKEN from the calling workflow
-    required: true
-
-runs:
-  using: "composite"
-  steps:
-  - name: setup golang
-    uses: actions/setup-go@v2
-    with:
-      go-version: 1.18
-
-  - name: setup minikube
-    uses: manusa/actions-setup-minikube@v2.6.0
-    with:
-      minikube version: "v1.26.0"
-      kubernetes version: ${{ inputs.kubernetes-version }}
-      start args: --memory 6g --cpus=2 --addons ingress
-      github token: ${{ inputs.github-token }}
-
-  - name: print k8s cluster status
-    shell: bash --noprofile --norc -eo pipefail -x {0}
-    run: tests/scripts/github-action-helper.sh print_k8s_cluster_status
-
-  # This step is required for all the integration tests except the canary tests
-  - name: use local disk
-    shell: bash --noprofile --norc -eo pipefail -x {0}
-    run: tests/scripts/github-action-helper.sh use_local_disk_for_integration_test
-
-  - name: build rook
-    shell: bash --noprofile --norc -eo pipefail -x {0}
-    run: tests/scripts/github-action-helper.sh build_rook

.github/workflows/integration-test-helm-suite.yaml

@@ -18,58 +18,76 @@ concurrency:
 jobs:
   TestCephHelmSuite:
     if: ${{ github.event_name == 'pull_request' && github.ref != 'refs/heads/master' && !contains(github.event.pull_request.labels.*.name, 'skip-ci') }}
-    runs-on: ubuntu-18.04
+    runs-on: ubuntu-20.04
     strategy:
       fail-fast: false
       matrix:
-        kubernetes-versions : ['v1.17.17', 'v1.24.1']
+        kubernetes-versions: ["v1.17.17", "v1.24.1"]
     steps:
-    - name: checkout
-      uses: actions/checkout@v2
-      with:
-        fetch-depth: 0
+      - name: checkout
+        uses: actions/checkout@v2
+        with:
+          fetch-depth: 0
 
-    - name: setup cluster resources
-      uses: ./.github/workflows/integration-test-config
-      with:
-        github-token: ${{ secrets.GITHUB_TOKEN }}
-        kubernetes-version: ${{ matrix.kubernetes-versions }}
+      - name: check matrix k8s version
+        run: |
+          echo USE_K8S=$(echo ${{ matrix.kubernetes-versions }})
+          if [ $(echo ${{ matrix.kubernetes-versions }}) == "v1.17.17" ]; then
+            echo "OLDER_K8S=true" >> $GITHUB_ENV
+          else
+            echo "OLDER_K8S=false" >> $GITHUB_ENV
+          fi
+          echo env.OLDER_K8S
 
-    - name: remove read permission from kube config file
-      run: sudo chmod go-r ~/.kube/config
+      - name: setup latest cluster resources
+        if: ${{ env.OLDER_K8S == 'false' }}
+        uses: ./.github/workflows/integration-test-config-latest-k8s
+        with:
+          github-token: ${{ secrets.GITHUB_TOKEN }}
+          kubernetes-version: ${{ matrix.kubernetes-versions }}
 
-    - name: TestCephHelmSuite
-      run: |
-        tests/scripts/github-action-helper.sh collect_udev_logs_in_background
-        tests/scripts/github-action-helper.sh create_helm_tag
-        tests/scripts/helm.sh up
-        export DEVICE_FILTER=$(lsblk|awk '/14G/ {print $1}'| head -1)
-        SKIP_TEST_CLEANUP=false SKIP_CLEANUP_POLICY=false go test -v -timeout 1800s -failfast -run CephHelmSuite github.com/rook/rook/tests/integration
+      - name: setup older cluster resources
+        if: ${{ env.OLDER_K8S == 'true' }}
+        uses: ./.github/workflows/integration-test-config-older-k8s
+        with:
+          github-token: ${{ secrets.GITHUB_TOKEN }}
+          kubernetes-version: ${{ matrix.kubernetes-versions }}
 
-    - name: collect common logs
-      if: always()
-      run: |
-        export LOG_DIR="/home/runner/work/rook/rook/tests/integration/_output/tests/"
-        export CLUSTER_NAMESPACE="helm-ns"
-        export OPERATOR_NAMESPACE="helm-ns-system"
-        tests/scripts/collect-logs.sh
+      - name: remove read permission from kube config file
+        run: sudo chmod go-r ~/.kube/config
 
-    - name: Artifact
-      uses: actions/upload-artifact@v2
-      if: failure()
-      with:
-        name: ceph-helm-suite-artifact-${{ matrix.kubernetes-versions }}
-        path: /home/runner/work/rook/rook/tests/integration/_output/tests/
+      - name: TestCephHelmSuite
+        run: |
+          tests/scripts/github-action-helper.sh collect_udev_logs_in_background
+          tests/scripts/github-action-helper.sh create_helm_tag
+          tests/scripts/helm.sh up
+          export DEVICE_FILTER=$(lsblk|awk '/14G/ {print $1}'| head -1)
+          SKIP_TEST_CLEANUP=false SKIP_CLEANUP_POLICY=false go test -v -timeout 1800s -failfast -run CephHelmSuite github.com/rook/rook/tests/integration
 
-    - name: consider debugging
-      if: failure() && github.event_name == 'pull_request'
-      run: |
-        # Enable tmate only in the Rook fork, where the USE_TMATE secret is set in the repo, or if the action is re-run
-        if [ "$GITHUB_REPOSITORY_OWNER" = "rook" ] || [ -n "${{ secrets.USE_TMATE }}" ] || [ "$GITHUB_RUN_ATTEMPT" -gt 1 ]; then
-          echo USE_TMATE=1 >> $GITHUB_ENV
-        fi
+      - name: collect common logs
+        if: always()
+        run: |
+          export LOG_DIR="/home/runner/work/rook/rook/tests/integration/_output/tests/"
+          export CLUSTER_NAMESPACE="helm-ns"
+          export OPERATOR_NAMESPACE="helm-ns-system"
+          tests/scripts/collect-logs.sh
 
-    - name: set up tmate session for debugging
-      if: failure() && env.USE_TMATE
-      uses: mxschmitt/action-tmate@v3
-      timeout-minutes: 60
+      - name: Artifact
+        uses: actions/upload-artifact@v2
+        if: failure()
+        with:
+          name: ceph-helm-suite-artifact-${{ matrix.kubernetes-versions }}
+          path: /home/runner/work/rook/rook/tests/integration/_output/tests/
+
+      - name: consider debugging
+        if: failure() && github.event_name == 'pull_request'
+        run: |
+          # Enable tmate only in the Rook fork, where the USE_TMATE secret is set in the repo, or if the action is re-run
+          if [ "$GITHUB_REPOSITORY_OWNER" = "rook" ] || [ -n "${{ secrets.USE_TMATE }}" ] || [ "$GITHUB_RUN_ATTEMPT" -gt 1 ]; then
+            echo USE_TMATE=1 >> $GITHUB_ENV
+          fi
+
+      - name: set up tmate session for debugging
+        if: failure() && env.USE_TMATE
+        uses: mxschmitt/action-tmate@v3
+        timeout-minutes: 60

.github/workflows/integration-test-mgr-suite.yaml

@@ -16,54 +16,54 @@ concurrency:
 
 jobs:
   TestCephMgrSuite:
-    runs-on: ubuntu-18.04
+    runs-on: ubuntu-20.04
     if: "contains(github.event.pull_request.labels.*.name, 'run-mgr-suite')"
     strategy:
       fail-fast: false
       matrix:
-        kubernetes-versions : ['v1.24.1']
+        kubernetes-versions: ["v1.24.1"]
     steps:
-    - name: checkout
-      uses: actions/checkout@v2
-      with:
-        fetch-depth: 0
+      - name: checkout
+        uses: actions/checkout@v2
+        with:
+          fetch-depth: 0
 
-    - name: setup cluster resources
-      uses: ./.github/workflows/integration-test-config
-      with:
-        github-token: ${{ secrets.GITHUB_TOKEN }}
-        kubernetes-version: ${{ matrix.kubernetes-versions }}
+      - name: setup cluster resources
+        uses: ./.github/workflows/integration-test-config-latest-k8s
+        with:
+          github-token: ${{ secrets.GITHUB_TOKEN }}
+          kubernetes-version: ${{ matrix.kubernetes-versions }}
 
-    - name: TestCephMgrSuite
-      run: |
-        tests/scripts/github-action-helper.sh collect_udev_logs_in_background
-        export DEVICE_FILTER=$(lsblk|awk '/14G/ {print $1}'| head -1)
-        go test -v -timeout 1800s -failfast -run CephMgrSuite github.com/rook/rook/tests/integration
+      - name: TestCephMgrSuite
+        run: |
+          tests/scripts/github-action-helper.sh collect_udev_logs_in_background
+          export DEVICE_FILTER=$(lsblk|awk '/14G/ {print $1}'| head -1)
+          go test -v -timeout 1800s -failfast -run CephMgrSuite github.com/rook/rook/tests/integration
 
-    - name: collect common logs
-      if: always()
-      run: |
-        export LOG_DIR="/home/runner/work/rook/rook/tests/integration/_output/tests/"
-        export CLUSTER_NAMESPACE="mgr-ns"
-        export OPERATOR_NAMESPACE="mgr-ns-system"
-        tests/scripts/collect-logs.sh
+      - name: collect common logs
+        if: always()
+        run: |
+          export LOG_DIR="/home/runner/work/rook/rook/tests/integration/_output/tests/"
+          export CLUSTER_NAMESPACE="mgr-ns"
+          export OPERATOR_NAMESPACE="mgr-ns-system"
+          tests/scripts/collect-logs.sh
 
-    - name: Artifact
-      uses: actions/upload-artifact@v2
-      if: failure()
-      with:
-        name: ceph-mgr-suite-artifact-${{ matrix.kubernetes-versions }}
-        path: /home/runner/work/rook/rook/tests/integration/_output/tests/
+      - name: Artifact
+        uses: actions/upload-artifact@v2
+        if: failure()
+        with:
+          name: ceph-mgr-suite-artifact-${{ matrix.kubernetes-versions }}
+          path: /home/runner/work/rook/rook/tests/integration/_output/tests/
 
-    - name: consider debugging
-      if: failure() && github.event_name == 'pull_request'
-      run: |
-        # Enable tmate only in the Rook fork, where the USE_TMATE secret is set in the repo, or if the action is re-run
-        if [ "$GITHUB_REPOSITORY_OWNER" = "rook" ] || [ -n "${{ secrets.USE_TMATE }}" ] || [ "$GITHUB_RUN_ATTEMPT" -gt 1 ]; then
-          echo USE_TMATE=1 >> $GITHUB_ENV
-        fi
+      - name: consider debugging
+        if: failure() && github.event_name == 'pull_request'
+        run: |
+          # Enable tmate only in the Rook fork, where the USE_TMATE secret is set in the repo, or if the action is re-run
+          if [ "$GITHUB_REPOSITORY_OWNER" = "rook" ] || [ -n "${{ secrets.USE_TMATE }}" ] || [ "$GITHUB_RUN_ATTEMPT" -gt 1 ]; then
+            echo USE_TMATE=1 >> $GITHUB_ENV
+          fi
 
-    - name: set up tmate session for debugging
-      if: failure() && env.USE_TMATE
-      uses: mxschmitt/action-tmate@v3
-      timeout-minutes: 60
+      - name: set up tmate session for debugging
+        if: failure() && env.USE_TMATE
+        uses: mxschmitt/action-tmate@v3
+        timeout-minutes: 60

.github/workflows/integration-test-multi-cluster-suite.yaml

@@ -18,54 +18,54 @@ concurrency:
 jobs:
   TestCephMultiClusterDeploySuite:
     if: ${{ github.event_name == 'pull_request' && github.ref != 'refs/heads/master' && !contains(github.event.pull_request.labels.*.name, 'skip-ci') }}
-    runs-on: ubuntu-18.04
+    runs-on: ubuntu-20.04
     strategy:
       fail-fast: false
       matrix:
-        kubernetes-versions : ['v1.24.1']
+        kubernetes-versions: ["v1.24.1"]
     steps:
-    - name: checkout
-      uses: actions/checkout@v2
-      with:
-        fetch-depth: 0
+      - name: checkout
+        uses: actions/checkout@v2
+        with:
+          fetch-depth: 0
 
-    - name: setup cluster resources
-      uses: ./.github/workflows/integration-test-config
-      with:
-        github-token: ${{ secrets.GITHUB_TOKEN }}
-        kubernetes-version: ${{ matrix.kubernetes-versions }}
+      - name: setup cluster resources
+        uses: ./.github/workflows/integration-test-config-latest-k8s
+        with:
+          github-token: ${{ secrets.GITHUB_TOKEN }}
+          kubernetes-version: ${{ matrix.kubernetes-versions }}
 
-    - name: TestCephMultiClusterDeploySuite
-      run: |
-        tests/scripts/github-action-helper.sh collect_udev_logs_in_background
-        export TEST_SCRATCH_DEVICE=$(sudo lsblk --paths|awk '/14G/ {print $1}'| head -1)1
-        export DEVICE_FILTER=$(lsblk|awk '/14G/ {print $1}'| head -1)
-        go test -v -timeout 1800s -failfast -run CephMultiClusterDeploySuite github.com/rook/rook/tests/integration
+      - name: TestCephMultiClusterDeploySuite
+        run: |
+          tests/scripts/github-action-helper.sh collect_udev_logs_in_background
+          export TEST_SCRATCH_DEVICE=$(sudo lsblk --paths|awk '/14G/ {print $1}'| head -1)1
+          export DEVICE_FILTER=$(lsblk|awk '/14G/ {print $1}'| head -1)
+          go test -v -timeout 1800s -failfast -run CephMultiClusterDeploySuite github.com/rook/rook/tests/integration
 
-    - name: collect common logs
-      if: always()
-      run: |
-        export LOG_DIR="/home/runner/work/rook/rook/tests/integration/_output/tests/"
-        export OPERATOR_NAMESPACE="multi-core-system"
-        CLUSTER_NAMESPACE="multi-core" tests/scripts/collect-logs.sh
-        CLUSTER_NAMESPACE="multi-external" tests/scripts/collect-logs.sh
+      - name: collect common logs
+        if: always()
+        run: |
+          export LOG_DIR="/home/runner/work/rook/rook/tests/integration/_output/tests/"
+          export OPERATOR_NAMESPACE="multi-core-system"
+          CLUSTER_NAMESPACE="multi-core" tests/scripts/collect-logs.sh
+          CLUSTER_NAMESPACE="multi-external" tests/scripts/collect-logs.sh
 
-    - name: Artifact
-      uses: actions/upload-artifact@v2
-      if: failure()
-      with:
-        name: ceph-multi-cluster-deploy-suite-artifact-${{ matrix.kubernetes-versions }}
-        path: /home/runner/work/rook/rook/tests/integration/_output/tests/
+      - name: Artifact
+        uses: actions/upload-artifact@v2
+        if: failure()
+        with:
+          name: ceph-multi-cluster-deploy-suite-artifact-${{ matrix.kubernetes-versions }}
+          path: /home/runner/work/rook/rook/tests/integration/_output/tests/
 
-    - name: consider debugging
-      if: failure() && github.event_name == 'pull_request'
-      run: |
-        # Enable tmate only in the Rook fork, where the USE_TMATE secret is set in the repo, or if the action is re-run
-        if [ "$GITHUB_REPOSITORY_OWNER" = "rook" ] || [ -n "${{ secrets.USE_TMATE }}" ] || [ "$GITHUB_RUN_ATTEMPT" -gt 1 ]; then
-          echo USE_TMATE=1 >> $GITHUB_ENV
-        fi
+      - name: consider debugging
+        if: failure() && github.event_name == 'pull_request'
+        run: |
+          # Enable tmate only in the Rook fork, where the USE_TMATE secret is set in the repo, or if the action is re-run
+          if [ "$GITHUB_REPOSITORY_OWNER" = "rook" ] || [ -n "${{ secrets.USE_TMATE }}" ] || [ "$GITHUB_RUN_ATTEMPT" -gt 1 ]; then
+            echo USE_TMATE=1 >> $GITHUB_ENV
+          fi
 
-    - name: set up tmate session for debugging
-      if: failure() && env.USE_TMATE
-      uses: mxschmitt/action-tmate@v3
-      timeout-minutes: 60
+      - name: set up tmate session for debugging
+        if: failure() && env.USE_TMATE
+        uses: mxschmitt/action-tmate@v3
+        timeout-minutes: 60

.github/workflows/integration-test-object-suite.yaml

@@ -18,53 +18,71 @@ concurrency:
 jobs:
   TestCephObjectSuite:
     if: ${{ github.event_name == 'pull_request' && github.ref != 'refs/heads/master' && !contains(github.event.pull_request.labels.*.name, 'skip-ci') }}
-    runs-on: ubuntu-18.04
+    runs-on: ubuntu-20.04
     strategy:
       fail-fast: false
       matrix:
-        kubernetes-versions : ['v1.17.17', 'v1.24.1']
+        kubernetes-versions: ["v1.17.17", "v1.24.1"]
     steps:
-    - name: checkout
-      uses: actions/checkout@v2
-      with:
-        fetch-depth: 0
+      - name: checkout
+        uses: actions/checkout@v2
+        with:
+          fetch-depth: 0
 
-    - name: setup cluster resources
-      uses: ./.github/workflows/integration-test-config
-      with:
-        github-token: ${{ secrets.GITHUB_TOKEN }}
-        kubernetes-version: ${{ matrix.kubernetes-versions }}
+      - name: check matrix k8s version
+        run: |
+          echo USE_K8S=$(echo ${{ matrix.kubernetes-versions }})
+          if [ $(echo ${{ matrix.kubernetes-versions }}) == "v1.17.17" ]; then
+            echo "OLDER_K8S=true" >> $GITHUB_ENV
+          else
+            echo "OLDER_K8S=false" >> $GITHUB_ENV
+          fi
+          echo env.OLDER_K8S
 
-    - name: TestCephObjectSuite
-      run: |
-        tests/scripts/github-action-helper.sh collect_udev_logs_in_background
-        export DEVICE_FILTER=$(lsblk|awk '/14G/ {print $1}'| head -1)
-        SKIP_CLEANUP_POLICY=false go test -v -timeout 1800s -failfast -run CephObjectSuite github.com/rook/rook/tests/integration
+      - name: setup latest cluster resources
+        if: ${{ env.OLDER_K8S == 'false' }}
+        uses: ./.github/workflows/integration-test-config-latest-k8s
+        with:
+          github-token: ${{ secrets.GITHUB_TOKEN }}
+          kubernetes-version: ${{ matrix.kubernetes-versions }}
 
-    - name: collect common logs
-      if: always()
-      run: |
-        export LOG_DIR="/home/runner/work/rook/rook/tests/integration/_output/tests/"
-        export CLUSTER_NAMESPACE="object-ns"
-        export OPERATOR_NAMESPACE="object-ns-system"
-        tests/scripts/collect-logs.sh
+      - name: setup older cluster resources
+        if: ${{ env.OLDER_K8S == 'true' }}
+        uses: ./.github/workflows/integration-test-config-older-k8s
+        with:
+          github-token: ${{ secrets.GITHUB_TOKEN }}
+          kubernetes-version: ${{ matrix.kubernetes-versions }}
 
-    - name: Artifact
-      uses: actions/upload-artifact@v2
-      if: failure()
-      with:
-        name: ceph-object-suite-artifact-${{ matrix.kubernetes-versions }}
-        path: /home/runner/work/rook/rook/tests/integration/_output/tests/
+      - name: TestCephObjectSuite
+        run: |
+          tests/scripts/github-action-helper.sh collect_udev_logs_in_background
+          export DEVICE_FILTER=$(lsblk|awk '/14G/ {print $1}'| head -1)
+          SKIP_CLEANUP_POLICY=false go test -v -timeout 1800s -failfast -run CephObjectSuite github.com/rook/rook/tests/integration
 
-    - name: consider debugging
-      if: failure() && github.event_name == 'pull_request'
-      run: |
-        # Enable tmate only in the Rook fork, where the USE_TMATE secret is set in the repo, or if the action is re-run
-        if [ "$GITHUB_REPOSITORY_OWNER" = "rook" ] || [ -n "${{ secrets.USE_TMATE }}" ] || [ "$GITHUB_RUN_ATTEMPT" -gt 1 ]; then
-          echo USE_TMATE=1 >> $GITHUB_ENV
-        fi
+      - name: collect common logs
+        if: always()
+        run: |
+          export LOG_DIR="/home/runner/work/rook/rook/tests/integration/_output/tests/"
+          export CLUSTER_NAMESPACE="object-ns"
+          export OPERATOR_NAMESPACE="object-ns-system"
+          tests/scripts/collect-logs.sh
 
-    - name: set up tmate session for debugging
-      if: failure() && env.USE_TMATE
-      uses: mxschmitt/action-tmate@v3
-      timeout-minutes: 60
+      - name: Artifact
+        uses: actions/upload-artifact@v2
+        if: failure()
+        with:
+          name: ceph-object-suite-artifact-${{ matrix.kubernetes-versions }}
+          path: /home/runner/work/rook/rook/tests/integration/_output/tests/
+
+      - name: consider debugging
+        if: failure() && github.event_name == 'pull_request'
+        run: |
+          # Enable tmate only in the Rook fork, where the USE_TMATE secret is set in the repo, or if the action is re-run
+          if [ "$GITHUB_REPOSITORY_OWNER" = "rook" ] || [ -n "${{ secrets.USE_TMATE }}" ] || [ "$GITHUB_RUN_ATTEMPT" -gt 1 ]; then
+            echo USE_TMATE=1 >> $GITHUB_ENV
+          fi
+
+      - name: set up tmate session for debugging
+        if: failure() && env.USE_TMATE
+        uses: mxschmitt/action-tmate@v3
+        timeout-minutes: 60

.github/workflows/integration-test-smoke-suite.yaml

@@ -18,53 +18,71 @@ concurrency:
 jobs:
   TestCephSmokeSuite:
     if: ${{ github.event_name == 'pull_request' && github.ref != 'refs/heads/master' && !contains(github.event.pull_request.labels.*.name, 'skip-ci') }}
-    runs-on: ubuntu-18.04
+    runs-on: ubuntu-20.04
     strategy:
       fail-fast: false
       matrix:
-        kubernetes-versions : ['v1.17.17', 'v1.24.1']
+        kubernetes-versions: ["v1.17.17", "v1.24.1"]
     steps:
-    - name: checkout
-      uses: actions/checkout@v2
-      with:
-        fetch-depth: 0
+      - name: checkout
+        uses: actions/checkout@v2
+        with:
+          fetch-depth: 0
 
-    - name: setup cluster resources
-      uses: ./.github/workflows/integration-test-config
-      with:
-        github-token: ${{ secrets.GITHUB_TOKEN }}
-        kubernetes-version: ${{ matrix.kubernetes-versions }}
+      - name: check matrix k8s version
+        run: |
+          echo USE_K8S=$(echo ${{ matrix.kubernetes-versions }})
+          if [ $(echo ${{ matrix.kubernetes-versions }}) == "v1.17.17" ]; then
+            echo "OLDER_K8S=true" >> $GITHUB_ENV
+          else
+            echo "OLDER_K8S=false" >> $GITHUB_ENV
+          fi
+          echo env.OLDER_K8S
 
-    - name: TestCephSmokeSuite
-      run: |
-        tests/scripts/github-action-helper.sh collect_udev_logs_in_background
-        export DEVICE_FILTER=$(lsblk|awk '/14G/ {print $1}'| head -1)
-        SKIP_CLEANUP_POLICY=false go test -v -timeout 1800s -failfast -run CephSmokeSuite github.com/rook/rook/tests/integration
+      - name: setup latest cluster resources
+        if: ${{ env.OLDER_K8S == 'false' }}
+        uses: ./.github/workflows/integration-test-config-latest-k8s
+        with:
+          github-token: ${{ secrets.GITHUB_TOKEN }}
+          kubernetes-version: ${{ matrix.kubernetes-versions }}
 
-    - name: collect common logs
-      if: always()
-      run: |
-        export LOG_DIR="/home/runner/work/rook/rook/tests/integration/_output/tests/"
-        export CLUSTER_NAMESPACE="smoke-ns"
-        export OPERATOR_NAMESPACE="smoke-ns-system"
-        tests/scripts/collect-logs.sh
+      - name: setup older cluster resources
+        if: ${{ env.OLDER_K8S == 'true' }}
+        uses: ./.github/workflows/integration-test-config-older-k8s
+        with:
+          github-token: ${{ secrets.GITHUB_TOKEN }}
+          kubernetes-version: ${{ matrix.kubernetes-versions }}
 
-    - name: Artifact
-      uses: actions/upload-artifact@v2
-      if: failure()
-      with:
-        name: ceph-smoke-suite-artifact-${{ matrix.kubernetes-versions }}
-        path: /home/runner/work/rook/rook/tests/integration/_output/tests/
+      - name: TestCephSmokeSuite
+        run: |
+          tests/scripts/github-action-helper.sh collect_udev_logs_in_background
+          export DEVICE_FILTER=$(lsblk|awk '/14G/ {print $1}'| head -1)
+          SKIP_CLEANUP_POLICY=false go test -v -timeout 1800s -failfast -run CephSmokeSuite github.com/rook/rook/tests/integration
 
-    - name: consider debugging
-      if: failure() && github.event_name == 'pull_request'
-      run: |
-        # Enable tmate only in the Rook fork, where the USE_TMATE secret is set in the repo, or if the action is re-run
-        if [ "$GITHUB_REPOSITORY_OWNER" = "rook" ] || [ -n "${{ secrets.USE_TMATE }}" ] || [ "$GITHUB_RUN_ATTEMPT" -gt 1 ]; then
-          echo USE_TMATE=1 >> $GITHUB_ENV
-        fi
+      - name: collect common logs
+        if: always()
+        run: |
+          export LOG_DIR="/home/runner/work/rook/rook/tests/integration/_output/tests/"
+          export CLUSTER_NAMESPACE="smoke-ns"
+          export OPERATOR_NAMESPACE="smoke-ns-system"
+          tests/scripts/collect-logs.sh
 
-    - name: set up tmate session for debugging
-      if: failure() && env.USE_TMATE
-      uses: mxschmitt/action-tmate@v3
-      timeout-minutes: 60
+      - name: Artifact
+        uses: actions/upload-artifact@v2
+        if: failure()
+        with:
+          name: ceph-smoke-suite-artifact-${{ matrix.kubernetes-versions }}
+          path: /home/runner/work/rook/rook/tests/integration/_output/tests/
+
+      - name: consider debugging
+        if: failure() && github.event_name == 'pull_request'
+        run: |
+          # Enable tmate only in the Rook fork, where the USE_TMATE secret is set in the repo, or if the action is re-run
+          if [ "$GITHUB_REPOSITORY_OWNER" = "rook" ] || [ -n "${{ secrets.USE_TMATE }}" ] || [ "$GITHUB_RUN_ATTEMPT" -gt 1 ]; then
+            echo USE_TMATE=1 >> $GITHUB_ENV
+          fi
+
+      - name: set up tmate session for debugging
+        if: failure() && env.USE_TMATE
+        uses: mxschmitt/action-tmate@v3
+        timeout-minutes: 60

.github/workflows/integration-test-upgrade-suite.yaml

@@ -18,101 +18,119 @@ concurrency:
 jobs:
   TestCephUpgradeSuite:
     if: ${{ github.event_name == 'pull_request' && github.ref != 'refs/heads/master' && !contains(github.event.pull_request.labels.*.name, 'skip-ci') }}
-    runs-on: ubuntu-18.04
+    runs-on: ubuntu-20.04
     strategy:
       fail-fast: false
       matrix:
-        kubernetes-versions : ['v1.17.17', 'v1.24.1']
+        kubernetes-versions: ["v1.17.17", "v1.24.1"]
     steps:
-    - name: checkout
-      uses: actions/checkout@v2
-      with:
-        fetch-depth: 0
+      - name: checkout
+        uses: actions/checkout@v2
+        with:
+          fetch-depth: 0
 
-    - name: setup cluster resources
-      uses: ./.github/workflows/integration-test-config
-      with:
-        github-token: ${{ secrets.GITHUB_TOKEN }}
-        kubernetes-version: ${{ matrix.kubernetes-versions }}
+      - name: check matrix k8s version
+        run: |
+          echo USE_K8S=$(echo ${{ matrix.kubernetes-versions }})
+          if [ $(echo ${{ matrix.kubernetes-versions }}) == "v1.17.17" ]; then
+            echo "OLDER_K8S=true" >> $GITHUB_ENV
+          else
+            echo "OLDER_K8S=false" >> $GITHUB_ENV
+          fi
+          echo env.OLDER_K8S
 
-    - name: TestCephUpgradeSuite
-      run: |
-        tests/scripts/github-action-helper.sh collect_udev_logs_in_background
-        export DEVICE_FILTER=$(lsblk|awk '/14G/ {print $1}'| head -1)
-        go test -v -timeout 1800s -failfast -run CephUpgradeSuite/TestUpgradeRook github.com/rook/rook/tests/integration
+      - name: setup latest cluster resources
+        if: ${{ env.OLDER_K8S == 'false' }}
+        uses: ./.github/workflows/integration-test-config-latest-k8s
+        with:
+          github-token: ${{ secrets.GITHUB_TOKEN }}
+          kubernetes-version: ${{ matrix.kubernetes-versions }}
 
-    - name: collect common logs
-      if: always()
-      run: |
-        export LOG_DIR="/home/runner/work/rook/rook/tests/integration/_output/tests/"
-        export CLUSTER_NAMESPACE="upgrade"
-        export OPERATOR_NAMESPACE="upgrade-system"
-        tests/scripts/collect-logs.sh
+      - name: setup older cluster resources
+        if: ${{ env.OLDER_K8S == 'true' }}
+        uses: ./.github/workflows/integration-test-config-older-k8s
+        with:
+          github-token: ${{ secrets.GITHUB_TOKEN }}
+          kubernetes-version: ${{ matrix.kubernetes-versions }}
 
-    - name: Artifact
-      uses: actions/upload-artifact@v2
-      if: failure()
-      with:
-        name: ceph-upgrade-suite-artifact-${{ matrix.kubernetes-versions }}
-        path: /home/runner/work/rook/rook/tests/integration/_output/tests/
+      - name: TestCephUpgradeSuite
+        run: |
+          tests/scripts/github-action-helper.sh collect_udev_logs_in_background
+          export DEVICE_FILTER=$(lsblk|awk '/14G/ {print $1}'| head -1)
+          go test -v -timeout 1800s -failfast -run CephUpgradeSuite/TestUpgradeRook github.com/rook/rook/tests/integration
 
-    - name: setup tmate session for debugging when event is PR
-      if: failure() && github.event_name == 'pull_request'
-      uses: mxschmitt/action-tmate@v3
-      timeout-minutes: 60
+      - name: collect common logs
+        if: always()
+        run: |
+          export LOG_DIR="/home/runner/work/rook/rook/tests/integration/_output/tests/"
+          export CLUSTER_NAMESPACE="upgrade"
+          export OPERATOR_NAMESPACE="upgrade-system"
+          tests/scripts/collect-logs.sh
+
+      - name: Artifact
+        uses: actions/upload-artifact@v2
+        if: failure()
+        with:
+          name: ceph-upgrade-suite-artifact-${{ matrix.kubernetes-versions }}
+          path: /home/runner/work/rook/rook/tests/integration/_output/tests/
+
+      - name: setup tmate session for debugging when event is PR
+        if: failure() && github.event_name == 'pull_request'
+        uses: mxschmitt/action-tmate@v3
+        timeout-minutes: 60
 
   TestHelmUpgradeSuite:
     if: ${{ github.event_name == 'pull_request' && github.ref != 'refs/heads/master' && !contains(github.event.pull_request.labels.*.name, 'skip-ci') }}
-    runs-on: ubuntu-18.04
+    runs-on: ubuntu-20.04
     strategy:
       fail-fast: false
       matrix:
-        kubernetes-versions : ['v1.19.16', 'v1.24.1']
+        kubernetes-versions: ["v1.19.16", "v1.24.1"]
     steps:
-    - name: checkout
-      uses: actions/checkout@v2
-      with:
-        fetch-depth: 0
+      - name: checkout
+        uses: actions/checkout@v2
+        with:
+          fetch-depth: 0
 
-    - name: setup cluster resources
-      uses: ./.github/workflows/integration-test-config
-      with:
-        github-token: ${{ secrets.GITHUB_TOKEN }}
-        kubernetes-version: ${{ matrix.kubernetes-versions }}
+      - name: setup cluster resources
+        uses: ./.github/workflows/integration-test-config-latest-k8s
+        with:
+          github-token: ${{ secrets.GITHUB_TOKEN }}
+          kubernetes-version: ${{ matrix.kubernetes-versions }}
 
-    - name: TestHelmUpgradeSuite
-      run: |
-        tests/scripts/github-action-helper.sh create_helm_tag
-        tests/scripts/helm.sh up
+      - name: TestHelmUpgradeSuite
+        run: |
+          tests/scripts/github-action-helper.sh create_helm_tag
+          tests/scripts/helm.sh up
 
-        tests/scripts/github-action-helper.sh collect_udev_logs_in_background
-        export DEVICE_FILTER=$(lsblk|awk '/14G/ {print $1}'| head -1)
-        go test -v -timeout 1800s -failfast -run CephUpgradeSuite/TestUpgradeHelm github.com/rook/rook/tests/integration
+          tests/scripts/github-action-helper.sh collect_udev_logs_in_background
+          export DEVICE_FILTER=$(lsblk|awk '/14G/ {print $1}'| head -1)
+          go test -v -timeout 1800s -failfast -run CephUpgradeSuite/TestUpgradeHelm github.com/rook/rook/tests/integration
 
-    - name: collect common logs
-      if: always()
-      run: |
-        export LOG_DIR="/home/runner/work/rook/rook/tests/integration/_output/tests/"
-        export CLUSTER_NAMESPACE="upgrade"
-        export OPERATOR_NAMESPACE="upgrade-system"
-        tests/scripts/collect-logs.sh
+      - name: collect common logs
+        if: always()
+        run: |
+          export LOG_DIR="/home/runner/work/rook/rook/tests/integration/_output/tests/"
+          export CLUSTER_NAMESPACE="upgrade"
+          export OPERATOR_NAMESPACE="upgrade-system"
+          tests/scripts/collect-logs.sh
 
-    - name: Artifact
-      uses: actions/upload-artifact@v2
-      if: failure()
-      with:
-        name: ceph-upgrade-helm-suite-artifact-${{ matrix.kubernetes-versions }}
-        path: /home/runner/work/rook/rook/tests/integration/_output/tests/
+      - name: Artifact
+        uses: actions/upload-artifact@v2
+        if: failure()
+        with:
+          name: ceph-upgrade-helm-suite-artifact-${{ matrix.kubernetes-versions }}
+          path: /home/runner/work/rook/rook/tests/integration/_output/tests/
 
-    - name: consider debugging
-      if: failure() && github.event_name == 'pull_request'
-      run: |
-        # Enable tmate only in the Rook fork, where the USE_TMATE secret is set in the repo, or if the action is re-run
-        if [ "$GITHUB_REPOSITORY_OWNER" = "rook" ] || [ -n "${{ secrets.USE_TMATE }}" ] || [ "$GITHUB_RUN_ATTEMPT" -gt 1 ]; then
-          echo USE_TMATE=1 >> $GITHUB_ENV
-        fi
+      - name: consider debugging
+        if: failure() && github.event_name == 'pull_request'
+        run: |
+          # Enable tmate only in the Rook fork, where the USE_TMATE secret is set in the repo, or if the action is re-run
+          if [ "$GITHUB_REPOSITORY_OWNER" = "rook" ] || [ -n "${{ secrets.USE_TMATE }}" ] || [ "$GITHUB_RUN_ATTEMPT" -gt 1 ]; then
+            echo USE_TMATE=1 >> $GITHUB_ENV
+          fi
 
-    - name: set up tmate session for debugging
-      if: failure() && env.USE_TMATE
-      uses: mxschmitt/action-tmate@v3
-      timeout-minutes: 60
+      - name: set up tmate session for debugging
+        if: failure() && env.USE_TMATE
+        uses: mxschmitt/action-tmate@v3
+        timeout-minutes: 60

.github/workflows/integration-tests-on-release.yaml

@@ -14,242 +14,337 @@ defaults:
 
 jobs:
   TestCephHelmSuite:
-    runs-on: ubuntu-18.04
+    runs-on: ubuntu-20.04
     strategy:
       fail-fast: false
       matrix:
-        kubernetes-versions : ['v1.17.17','v1.19.16','v1.21.7','v1.24.1']
+        kubernetes-versions: ["v1.17.17", "v1.19.16", "v1.21.7", "v1.24.1"]
     steps:
-    - name: checkout
-      uses: actions/checkout@v2
-      with:
-        fetch-depth: 0
+      - name: checkout
+        uses: actions/checkout@v2
+        with:
+          fetch-depth: 0
 
-    - name: setup cluster resources
-      uses: ./.github/workflows/integration-test-config
-      with:
-        github-token: ${{ secrets.GITHUB_TOKEN }}
-        kubernetes-version: ${{ matrix.kubernetes-versions }}
+      - name: check matrix k8s version
+        run: |
+          echo USE_K8S=$(echo ${{ matrix.kubernetes-versions }})
+          if [ $(echo ${{ matrix.kubernetes-versions }}) == "v1.17.17" ]; then
+            echo "OLDER_K8S=true" >> $GITHUB_ENV
+          else
+            echo "OLDER_K8S=false" >> $GITHUB_ENV
+          fi
+          echo env.OLDER_K8S
 
-    - name: TestCephHelmSuite
-      run: |
-        tests/scripts/github-action-helper.sh collect_udev_logs_in_background
-        tests/scripts/github-action-helper.sh create_helm_tag
-        tests/scripts/helm.sh up
-        export DEVICE_FILTER=$(lsblk|awk '/14G/ {print $1}'| head -1)
-        SKIP_TEST_CLEANUP=false SKIP_CLEANUP_POLICY=false go test -v -timeout 1800s -run CephHelmSuite github.com/rook/rook/tests/integration
+      - name: setup latest cluster resources
+        if: ${{ env.OLDER_K8S == 'false' }}
+        uses: ./.github/workflows/integration-test-config-latest-k8s
+        with:
+          github-token: ${{ secrets.GITHUB_TOKEN }}
+          kubernetes-version: ${{ matrix.kubernetes-versions }}
 
-    - name: collect common logs
-      if: always()
-      run: |
-        export LOG_DIR="/home/runner/work/rook/rook/tests/integration/_output/tests/"
-        export CLUSTER_NAMESPACE="helm-ns"
-        export OPERATOR_NAMESPACE="helm-ns-system"
-        tests/scripts/collect-logs.sh
+      - name: setup older cluster resources
+        if: ${{ env.OLDER_K8S == 'true' }}
+        uses: ./.github/workflows/integration-test-config-older-k8s
+        with:
+          github-token: ${{ secrets.GITHUB_TOKEN }}
+          kubernetes-version: ${{ matrix.kubernetes-versions }}
 
-    - name: Artifact
-      uses: actions/upload-artifact@v2
-      if: failure()
-      with:
-        name: ceph-helm-suite-artifact-${{ matrix.kubernetes-versions }}
-        path: /home/runner/work/rook/rook/tests/integration/_output/tests/
+      - name: TestCephHelmSuite
+        run: |
+          tests/scripts/github-action-helper.sh collect_udev_logs_in_background
+          tests/scripts/github-action-helper.sh create_helm_tag
+          tests/scripts/helm.sh up
+          export DEVICE_FILTER=$(lsblk|awk '/14G/ {print $1}'| head -1)
+          SKIP_TEST_CLEANUP=false SKIP_CLEANUP_POLICY=false go test -v -timeout 1800s -run CephHelmSuite github.com/rook/rook/tests/integration
+
+      - name: collect common logs
+        if: always()
+        run: |
+          export LOG_DIR="/home/runner/work/rook/rook/tests/integration/_output/tests/"
+          export CLUSTER_NAMESPACE="helm-ns"
+          export OPERATOR_NAMESPACE="helm-ns-system"
+          tests/scripts/collect-logs.sh
+
+      - name: Artifact
+        uses: actions/upload-artifact@v2
+        if: failure()
+        with:
+          name: ceph-helm-suite-artifact-${{ matrix.kubernetes-versions }}
+          path: /home/runner/work/rook/rook/tests/integration/_output/tests/
 
   TestCephMultiClusterDeploySuite:
-    runs-on: ubuntu-18.04
+    runs-on: ubuntu-20.04
     strategy:
       fail-fast: false
       matrix:
-        kubernetes-versions : ['v1.17.17','v1.19.16','v1.21.7','v1.24.1']
+        kubernetes-versions: ["v1.17.17", "v1.19.16", "v1.21.7", "v1.24.1"]
     steps:
-    - name: checkout
-      uses: actions/checkout@v2
-      with:
-        fetch-depth: 0
+      - name: checkout
+        uses: actions/checkout@v2
+        with:
+          fetch-depth: 0
 
-    - name: setup cluster resources
-      uses: ./.github/workflows/integration-test-config
-      with:
-        github-token: ${{ secrets.GITHUB_TOKEN }}
-        kubernetes-version: ${{ matrix.kubernetes-versions }}
+      - name: check matrix k8s version
+        run: |
+          echo USE_K8S=$(echo ${{ matrix.kubernetes-versions }})
+          if [ $(echo ${{ matrix.kubernetes-versions }}) == "v1.17.17" ]; then
+            echo "OLDER_K8S=true" >> $GITHUB_ENV
+          else
+            echo "OLDER_K8S=false" >> $GITHUB_ENV
+          fi
+          echo env.OLDER_K8S
 
-    - name: TestCephMultiClusterDeploySuite
-      run: |
-        tests/scripts/github-action-helper.sh collect_udev_logs_in_background
-        export TEST_SCRATCH_DEVICE=$(sudo lsblk --paths|awk '/14G/ {print $1}'| head -1)1
-        export DEVICE_FILTER=$(lsblk|awk '/14G/ {print $1}'| head -1)
-        go test -v -timeout 1800s -run CephMultiClusterDeploySuite github.com/rook/rook/tests/integration
+      - name: setup latest cluster resources
+        if: ${{ env.OLDER_K8S == 'false' }}
+        uses: ./.github/workflows/integration-test-config-latest-k8s
+        with:
+          github-token: ${{ secrets.GITHUB_TOKEN }}
+          kubernetes-version: ${{ matrix.kubernetes-versions }}
 
-    - name: collect common logs
-      if: always()
-      run: |
-        export LOG_DIR="/home/runner/work/rook/rook/tests/integration/_output/tests/"
-        export OPERATOR_NAMESPACE="multi-core-system"
-        CLUSTER_NAMESPACE="multi-core" tests/scripts/collect-logs.sh
-        CLUSTER_NAMESPACE="multi-external" tests/scripts/collect-logs.sh
+      - name: setup older cluster resources
+        if: ${{ env.OLDER_K8S == 'true' }}
+        uses: ./.github/workflows/integration-test-config-older-k8s
+        with:
+          github-token: ${{ secrets.GITHUB_TOKEN }}
+          kubernetes-version: ${{ matrix.kubernetes-versions }}
 
-    - name: Artifact
-      uses: actions/upload-artifact@v2
-      if: failure()
-      with:
-        name: ceph-multi-cluster-deploy-suite-artifact-${{ matrix.kubernetes-versions }}
-        path: /home/runner/work/rook/rook/tests/integration/_output/tests/
+      - name: TestCephMultiClusterDeploySuite
+        run: |
+          tests/scripts/github-action-helper.sh collect_udev_logs_in_background
+          export TEST_SCRATCH_DEVICE=$(sudo lsblk --paths|awk '/14G/ {print $1}'| head -1)1
+          export DEVICE_FILTER=$(lsblk|awk '/14G/ {print $1}'| head -1)
+          go test -v -timeout 1800s -run CephMultiClusterDeploySuite github.com/rook/rook/tests/integration
+
+      - name: collect common logs
+        if: always()
+        run: |
+          export LOG_DIR="/home/runner/work/rook/rook/tests/integration/_output/tests/"
+          export OPERATOR_NAMESPACE="multi-core-system"
+          CLUSTER_NAMESPACE="multi-core" tests/scripts/collect-logs.sh
+          CLUSTER_NAMESPACE="multi-external" tests/scripts/collect-logs.sh
+
+      - name: Artifact
+        uses: actions/upload-artifact@v2
+        if: failure()
+        with:
+          name: ceph-multi-cluster-deploy-suite-artifact-${{ matrix.kubernetes-versions }}
+          path: /home/runner/work/rook/rook/tests/integration/_output/tests/
 
   TestCephSmokeSuite:
-    runs-on: ubuntu-18.04
+    runs-on: ubuntu-20.04
     strategy:
       fail-fast: false
       matrix:
-        kubernetes-versions : ['v1.17.17','v1.19.16','v1.21.7','v1.24.1']
+        kubernetes-versions: ["v1.17.17", "v1.19.16", "v1.21.7", "v1.24.1"]
     steps:
-    - name: checkout
-      uses: actions/checkout@v2
-      with:
-        fetch-depth: 0
+      - name: checkout
+        uses: actions/checkout@v2
+        with:
+          fetch-depth: 0
 
-    - name: setup cluster resources
-      uses: ./.github/workflows/integration-test-config
-      with:
-        github-token: ${{ secrets.GITHUB_TOKEN }}
-        kubernetes-version: ${{ matrix.kubernetes-versions }}
+      - name: check matrix k8s version
+        run: |
+          echo USE_K8S=$(echo ${{ matrix.kubernetes-versions }})
+          if [ $(echo ${{ matrix.kubernetes-versions }}) == "v1.17.17" ]; then
+            echo "OLDER_K8S=true" >> $GITHUB_ENV
+          else
+            echo "OLDER_K8S=false" >> $GITHUB_ENV
+          fi
+          echo env.OLDER_K8S
 
-    - name: TestCephSmokeSuite
-      run: |
-        tests/scripts/github-action-helper.sh collect_udev_logs_in_background
-        export DEVICE_FILTER=$(lsblk|awk '/14G/ {print $1}'| head -1)
-        SKIP_CLEANUP_POLICY=false go test -v -timeout 1800s -run CephSmokeSuite github.com/rook/rook/tests/integration
+      - name: setup latest cluster resources
+        if: ${{ env.OLDER_K8S == 'false' }}
+        uses: ./.github/workflows/integration-test-config-latest-k8s
+        with:
+          github-token: ${{ secrets.GITHUB_TOKEN }}
+          kubernetes-version: ${{ matrix.kubernetes-versions }}
 
-    - name: collect common logs
-      if: always()
-      run: |
-        export LOG_DIR="/home/runner/work/rook/rook/tests/integration/_output/tests/"
-        export CLUSTER_NAMESPACE="smoke-ns"
-        export OPERATOR_NAMESPACE="smoke-ns-system"
-        tests/scripts/collect-logs.sh
+      - name: setup older cluster resources
+        if: ${{ env.OLDER_K8S == 'true' }}
+        uses: ./.github/workflows/integration-test-config-older-k8s
+        with:
+          github-token: ${{ secrets.GITHUB_TOKEN }}
+          kubernetes-version: ${{ matrix.kubernetes-versions }}
 
-    - name: Artifact
-      uses: actions/upload-artifact@v2
-      if: failure()
-      with:
-        name: ceph-smoke-suite-artifact-${{ matrix.kubernetes-versions }}
-        path: /home/runner/work/rook/rook/tests/integration/_output/tests/
+      - name: TestCephSmokeSuite
+        run: |
+          tests/scripts/github-action-helper.sh collect_udev_logs_in_background
+          export DEVICE_FILTER=$(lsblk|awk '/14G/ {print $1}'| head -1)
+          SKIP_CLEANUP_POLICY=false go test -v -timeout 1800s -run CephSmokeSuite github.com/rook/rook/tests/integration
+
+      - name: collect common logs
+        if: always()
+        run: |
+          export LOG_DIR="/home/runner/work/rook/rook/tests/integration/_output/tests/"
+          export CLUSTER_NAMESPACE="smoke-ns"
+          export OPERATOR_NAMESPACE="smoke-ns-system"
+          tests/scripts/collect-logs.sh
+
+      - name: Artifact
+        uses: actions/upload-artifact@v2
+        if: failure()
+        with:
+          name: ceph-smoke-suite-artifact-${{ matrix.kubernetes-versions }}
+          path: /home/runner/work/rook/rook/tests/integration/_output/tests/
 
   TestCephUpgradeSuite:
-    runs-on: ubuntu-18.04
+    runs-on: ubuntu-20.04
     strategy:
       fail-fast: false
       matrix:
-        kubernetes-versions : ['v1.17.17','v1.19.16','v1.21.7','v1.24.1']
+        kubernetes-versions: ["v1.17.17", "v1.19.16", "v1.21.7", "v1.24.1"]
     steps:
-    - name: checkout
-      uses: actions/checkout@v2
-      with:
-        fetch-depth: 0
+      - name: checkout
+        uses: actions/checkout@v2
+        with:
+          fetch-depth: 0
 
-    - name: setup cluster resources
-      uses: ./.github/workflows/integration-test-config
-      with:
-        github-token: ${{ secrets.GITHUB_TOKEN }}
-        kubernetes-version: ${{ matrix.kubernetes-versions }}
+      - name: check matrix k8s version
+        run: |
+          echo USE_K8S=$(echo ${{ matrix.kubernetes-versions }})
+          if [ $(echo ${{ matrix.kubernetes-versions }}) == "v1.17.17" ]; then
+            echo "OLDER_K8S=true" >> $GITHUB_ENV
+          else
+            echo "OLDER_K8S=false" >> $GITHUB_ENV
+          fi
+          echo env.OLDER_K8S
 
-    - name: TestCephUpgradeSuite
-      run: |
-        tests/scripts/github-action-helper.sh collect_udev_logs_in_background
-        export DEVICE_FILTER=$(lsblk|awk '/14G/ {print $1}'| head -1)
-        go test -v -timeout 1800s -run CephUpgradeSuite/TestUpgradeRook github.com/rook/rook/tests/integration
+      - name: setup latest cluster resources
+        if: ${{ env.OLDER_K8S == 'false' }}
+        uses: ./.github/workflows/integration-test-config-latest-k8s
+        with:
+          github-token: ${{ secrets.GITHUB_TOKEN }}
+          kubernetes-version: ${{ matrix.kubernetes-versions }}
 
-    - name: collect common logs
-      if: always()
-      run: |
-        export LOG_DIR="/home/runner/work/rook/rook/tests/integration/_output/tests/"
-        export CLUSTER_NAMESPACE="upgrade"
-        export OPERATOR_NAMESPACE="upgrade-system"
-        tests/scripts/collect-logs.sh
+      - name: setup older cluster resources
+        if: ${{ env.OLDER_K8S == 'true' }}
+        uses: ./.github/workflows/integration-test-config-older-k8s
+        with:
+          github-token: ${{ secrets.GITHUB_TOKEN }}
+          kubernetes-version: ${{ matrix.kubernetes-versions }}
 
-    - name: Artifact
-      uses: actions/upload-artifact@v2
-      if: failure()
-      with:
-        name: ceph-upgrade-suite-artifact-${{ matrix.kubernetes-versions }}
-        path: /home/runner/work/rook/rook/tests/integration/_output/tests/
+      - name: TestCephUpgradeSuite
+        run: |
+          tests/scripts/github-action-helper.sh collect_udev_logs_in_background
+          export DEVICE_FILTER=$(lsblk|awk '/14G/ {print $1}'| head -1)
+          go test -v -timeout 1800s -run CephUpgradeSuite/TestUpgradeRook github.com/rook/rook/tests/integration
+
+      - name: collect common logs
+        if: always()
+        run: |
+          export LOG_DIR="/home/runner/work/rook/rook/tests/integration/_output/tests/"
+          export CLUSTER_NAMESPACE="upgrade"
+          export OPERATOR_NAMESPACE="upgrade-system"
+          tests/scripts/collect-logs.sh
+
+      - name: Artifact
+        uses: actions/upload-artifact@v2
+        if: failure()
+        with:
+          name: ceph-upgrade-suite-artifact-${{ matrix.kubernetes-versions }}
+          path: /home/runner/work/rook/rook/tests/integration/_output/tests/
 
   TestHelmUpgradeSuite:
-    runs-on: ubuntu-18.04
+    runs-on: ubuntu-20.04
     strategy:
       fail-fast: false
       matrix:
-        kubernetes-versions : ['v1.19.16','v1.21.7', 'v1.24.1']
+        kubernetes-versions: ["v1.19.16", "v1.21.7", "v1.24.1"]
     steps:
-    - name: checkout
-      uses: actions/checkout@v2
-      with:
-        fetch-depth: 0
+      - name: checkout
+        uses: actions/checkout@v2
+        with:
+          fetch-depth: 0
 
-    - name: setup cluster resources
-      uses: ./.github/workflows/integration-test-config
-      with:
-        github-token: ${{ secrets.GITHUB_TOKEN }}
-        kubernetes-version: ${{ matrix.kubernetes-versions }}
+      - name: setup latest cluster resources
+        if: ${{ matrix.kubernetes-versions }} != "v1.24.1"
+        uses: ./.github/workflows/integration-test-config-latest-k8s
+        with:
+          github-token: ${{ secrets.GITHUB_TOKEN }}
+          kubernetes-version: ${{ matrix.kubernetes-versions }}
 
-    - name: TestHelmUpgradeSuite
-      run: |
-        tests/scripts/github-action-helper.sh create_helm_tag
-        tests/scripts/helm.sh up
+      - name: setup older cluster resources
+        if: ${{ matrix.kubernetes-versions }} == "v1.17.17"
+        uses: ./.github/workflows/integration-test-config-older-k8s
 
-        tests/scripts/github-action-helper.sh collect_udev_logs_in_background
-        export DEVICE_FILTER=$(lsblk|awk '/14G/ {print $1}'| head -1)
-        go test -v -timeout 1800s -run CephUpgradeSuite/TestUpgradeHelm github.com/rook/rook/tests/integration
+      - name: TestHelmUpgradeSuite
+        run: |
+          tests/scripts/github-action-helper.sh create_helm_tag
+          tests/scripts/helm.sh up
 
-    - name: collect common logs
-      if: always()
-      run: |
-        export LOG_DIR="/home/runner/work/rook/rook/tests/integration/_output/tests/"
-        export CLUSTER_NAMESPACE="upgrade"
-        export OPERATOR_NAMESPACE="upgrade-system"
-        tests/scripts/collect-logs.sh
+          tests/scripts/github-action-helper.sh collect_udev_logs_in_background
+          export DEVICE_FILTER=$(lsblk|awk '/14G/ {print $1}'| head -1)
+          go test -v -timeout 1800s -run CephUpgradeSuite/TestUpgradeHelm github.com/rook/rook/tests/integration
 
-    - name: Artifact
-      uses: actions/upload-artifact@v2
-      if: failure()
-      with:
-        name: ceph-upgrade-suite-artifact-${{ matrix.kubernetes-versions }}
-        path: /home/runner/work/rook/rook/tests/integration/_output/tests/
+      - name: collect common logs
+        if: always()
+        run: |
+          export LOG_DIR="/home/runner/work/rook/rook/tests/integration/_output/tests/"
+          export CLUSTER_NAMESPACE="upgrade"
+          export OPERATOR_NAMESPACE="upgrade-system"
+          tests/scripts/collect-logs.sh
+
+      - name: Artifact
+        uses: actions/upload-artifact@v2
+        if: failure()
+        with:
+          name: ceph-upgrade-suite-artifact-${{ matrix.kubernetes-versions }}
+          path: /home/runner/work/rook/rook/tests/integration/_output/tests/
 
   TestCephObjectSuite:
     if: ${{ github.event_name == 'pull_request' && github.ref != 'refs/heads/master' && !contains(github.event.pull_request.labels.*.name, 'skip-ci') }}
-    runs-on: ubuntu-18.04
+    runs-on: ubuntu-20.04
     strategy:
       fail-fast: false
       matrix:
-        kubernetes-versions : ['v1.17.17', 'v1.24.1']
+        kubernetes-versions: ["v1.17.17", "v1.24.1"]
     steps:
-    - name: checkout
-      uses: actions/checkout@v2
-      with:
-        fetch-depth: 0
+      - name: checkout
+        uses: actions/checkout@v2
+        with:
+          fetch-depth: 0
 
-    - name: setup cluster resources
-      uses: ./.github/workflows/integration-test-config
-      with:
-        github-token: ${{ secrets.GITHUB_TOKEN }}
-        kubernetes-version: ${{ matrix.kubernetes-versions }}
+      - name: check matrix k8s version
+        run: |
+          echo USE_K8S=$(echo ${{ matrix.kubernetes-versions }})
+          if [ $(echo ${{ matrix.kubernetes-versions }}) == "v1.17.17" ]; then
+            echo "OLDER_K8S=true" >> $GITHUB_ENV
+          else
+            echo "OLDER_K8S=false" >> $GITHUB_ENV
+          fi
+          echo env.OLDER_K8S
 
-    - name: TestCephObjectSuite
-      run: |
-        tests/scripts/github-action-helper.sh collect_udev_logs_in_background
-        export DEVICE_FILTER=$(lsblk|awk '/14G/ {print $1}'| head -1)
-        SKIP_CLEANUP_POLICY=false go test -v -timeout 1800s -failfast -run CephObjectSuite github.com/rook/rook/tests/integration
+      - name: setup latest cluster resources
+        if: ${{ env.OLDER_K8S == 'false' }}
+        uses: ./.github/workflows/integration-test-config-latest-k8s
+        with:
+          github-token: ${{ secrets.GITHUB_TOKEN }}
+          kubernetes-version: ${{ matrix.kubernetes-versions }}
 
-    - name: collect common logs
-      if: always()
-      run: |
-        export LOG_DIR="/home/runner/work/rook/rook/tests/integration/_output/tests/"
-        export CLUSTER_NAMESPACE="object-ns"
-        export OPERATOR_NAMESPACE="object-ns-system"
-        tests/scripts/collect-logs.sh
+      - name: setup older cluster resources
+        if: ${{ env.OLDER_K8S == 'true' }}
+        uses: ./.github/workflows/integration-test-config-older-k8s
+        with:
+          github-token: ${{ secrets.GITHUB_TOKEN }}
+          kubernetes-version: ${{ matrix.kubernetes-versions }}
 
-    - name: Artifact
-      uses: actions/upload-artifact@v2
-      if: failure()
-      with:
-        name: ceph-object-suite-artifact-${{ matrix.kubernetes-versions }}
-        path: /home/runner/work/rook/rook/tests/integration/_output/tests/
+      - name: TestCephObjectSuite
+        run: |
+          tests/scripts/github-action-helper.sh collect_udev_logs_in_background
+          export DEVICE_FILTER=$(lsblk|awk '/14G/ {print $1}'| head -1)
+          SKIP_CLEANUP_POLICY=false go test -v -timeout 1800s -failfast -run CephObjectSuite github.com/rook/rook/tests/integration
+
+      - name: collect common logs
+        if: always()
+        run: |
+          export LOG_DIR="/home/runner/work/rook/rook/tests/integration/_output/tests/"
+          export CLUSTER_NAMESPACE="object-ns"
+          export OPERATOR_NAMESPACE="object-ns-system"
+          tests/scripts/collect-logs.sh
+
+      - name: Artifact
+        uses: actions/upload-artifact@v2
+        if: failure()
+        with:
+          name: ceph-object-suite-artifact-${{ matrix.kubernetes-versions }}
+          path: /home/runner/work/rook/rook/tests/integration/_output/tests/

.github/workflows/mod-check.yml

@@ -26,19 +26,19 @@ permissions:
 
 jobs:
   modcheck:
-    runs-on: ubuntu-18.04
+    runs-on: ubuntu-20.04
     steps:
-    - name: checkout
-      uses: actions/checkout@v2
-      with:
-        fetch-depth: 0
+      - name: checkout
+        uses: actions/checkout@v2
+        with:
+          fetch-depth: 0
 
-    - uses: actions/setup-go@v2
-      with:
-        go-version: 1.18
+      - uses: actions/setup-go@v2
+        with:
+          go-version: 1.18
 
-    - name: run mod check
-      run: GOPATH=$(go env GOPATH) make -j $(nproc) mod.check
+      - name: run mod check
+        run: GOPATH=$(go env GOPATH) make -j $(nproc) mod.check
 
-    - name: validate modcheck
-      run: tests/scripts/validate_modified_files.sh modcheck
+      - name: validate modcheck
+        run: tests/scripts/validate_modified_files.sh modcheck

.github/workflows/push-build.yaml

@@ -17,7 +17,7 @@ permissions:
 
 jobs:
   push-image-to-container-registry:
-    runs-on: ubuntu-18.04
+    runs-on: ubuntu-20.04
     if: github.repository == 'rook/rook'
     steps:
       - name: checkout

.github/workflows/rbac-gen.yaml

@@ -26,24 +26,24 @@ permissions:
 
 jobs:
   gen-rbac:
-    runs-on: ubuntu-18.04
+    runs-on: ubuntu-20.04
     steps:
-    - uses: actions/setup-go@v2
-      with:
-        go-version: 1.18
+      - uses: actions/setup-go@v2
+        with:
+          go-version: 1.18
 
-    - name: checkout
-      uses: actions/checkout@v2
-      with:
-        fetch-depth: 0
+      - name: checkout
+        uses: actions/checkout@v2
+        with:
+          fetch-depth: 0
 
-    - name: copy working directory to GOPATH
-      run: sudo mkdir -p /home/runner/go/src/github.com && sudo cp -a /home/runner/work/rook /home/runner/go/src/github.com/
+      - name: copy working directory to GOPATH
+        run: sudo mkdir -p /home/runner/go/src/github.com && sudo cp -a /home/runner/work/rook /home/runner/go/src/github.com/
 
-    - name: run gen-rbac
-      working-directory: /home/runner/go/src/github.com/rook/rook
-      run: GOPATH=$(go env GOPATH) make gen-rbac
+      - name: run gen-rbac
+        working-directory: /home/runner/go/src/github.com/rook/rook
+        run: GOPATH=$(go env GOPATH) make gen-rbac
 
-    - name: validate gen-rbac
-      working-directory: /home/runner/go/src/github.com/rook/rook
-      run: tests/scripts/validate_modified_files.sh gen-rbac
+      - name: validate gen-rbac
+        working-directory: /home/runner/go/src/github.com/rook/rook
+        run: tests/scripts/validate_modified_files.sh gen-rbac

.github/workflows/stale.yaml

@@ -1,8 +1,8 @@
 name: "Mark or close stale issues and PRs"
 on:
   schedule:
-  # Run the stalebot every day at 8pm UTC
-  - cron: "00 20 * * *"
+    # Run the stalebot every day at 8pm UTC
+    - cron: "00 20 * * *"
 
 permissions:
   contents: read
@@ -10,33 +10,33 @@ permissions:
 jobs:
   stale:
     permissions:
-      issues: write  # for actions/stale to close stale issues
-      pull-requests: write  # for actions/stale to close stale PRs
-    runs-on: ubuntu-18.04
+      issues: write # for actions/stale to close stale issues
+      pull-requests: write # for actions/stale to close stale PRs
+    runs-on: ubuntu-20.04
     if: github.repository == 'rook/rook'
     steps:
-    - uses: actions/stale@v4
-      with:
-        repo-token: ${{ secrets.GITHUB_TOKEN }}
-        days-before-issue-stale: 60
-        days-before-pr-stale: 30
-        days-before-close: 7
-        days-before-pr-close: 14
-        stale-issue-message: >
-          This issue has been automatically marked as stale because it has not had recent activity.
-          It will be closed in a week if no further activity occurs.
-          Thank you for your contributions.
-        stale-pr-message: >
-          This pull request has been automatically marked as stale because it has not had
-          recent activity. It will be closed in two weeks if no further activity occurs.
-          Thank you for your contributions.
-        close-issue-message: >
-          This issue has been automatically closed due to inactivity.
-          Please re-open if this still requires investigation.
-        close-pr-message: >
-          This pull request has been automatically closed due to inactivity.
-          Please re-open if these changes are still required.
-        stale-pr-label: "stale"
-        stale-issue-label: "wontfix"
-        exempt-issue-labels: "keepalive,security,reliability"
-        exempt-pr-labels: "keepalive,security,reliability"
+      - uses: actions/stale@v4
+        with:
+          repo-token: ${{ secrets.GITHUB_TOKEN }}
+          days-before-issue-stale: 60
+          days-before-pr-stale: 30
+          days-before-close: 7
+          days-before-pr-close: 14
+          stale-issue-message: >
+            This issue has been automatically marked as stale because it has not had recent activity.
+            It will be closed in a week if no further activity occurs.
+            Thank you for your contributions.
+          stale-pr-message: >
+            This pull request has been automatically marked as stale because it has not had
+            recent activity. It will be closed in two weeks if no further activity occurs.
+            Thank you for your contributions.
+          close-issue-message: >
+            This issue has been automatically closed due to inactivity.
+            Please re-open if this still requires investigation.
+          close-pr-message: >
+            This pull request has been automatically closed due to inactivity.
+            Please re-open if these changes are still required.
+          stale-pr-label: "stale"
+          stale-issue-label: "wontfix"
+          exempt-issue-labels: "keepalive,security,reliability"
+          exempt-pr-labels: "keepalive,security,reliability"

.github/workflows/unit-test.yml

@@ -26,21 +26,21 @@ permissions:
 
 jobs:
   unittests:
-    runs-on: ubuntu-18.04
+    runs-on: ubuntu-20.04
     if: "!contains(github.event.pull_request.labels.*.name, 'skip-ci')"
     steps:
-    - name: checkout
-      uses: actions/checkout@v2
-      with:
-        fetch-depth: 0
+      - name: checkout
+        uses: actions/checkout@v2
+        with:
+          fetch-depth: 0
 
-    - uses: actions/setup-go@v2
-      with:
-        go-version: 1.18
+      - uses: actions/setup-go@v2
+        with:
+          go-version: 1.18
 
-    - name: copy working directory to GOPATH
-      run: sudo mkdir -p /home/runner/go/src/github.com && sudo cp -a /home/runner/work/rook /home/runner/go/src/github.com/
+      - name: copy working directory to GOPATH
+        run: sudo mkdir -p /home/runner/go/src/github.com && sudo cp -a /home/runner/work/rook /home/runner/go/src/github.com/
 
-    - name: run unit tests
-      working-directory: /home/runner/go/src/github.com/rook/rook
-      run: GOPATH=$(go env GOPATH) make -j $(nproc) test
+      - name: run unit tests
+        working-directory: /home/runner/go/src/github.com/rook/rook
+        run: GOPATH=$(go env GOPATH) make -j $(nproc) test