From 459c4bebe90b0caefd9b2d829e7e9de3795b0bbf Mon Sep 17 00:00:00 2001 From: Joshua Hoblitt Date: Thu, 11 Jun 2026 19:39:53 -0700 Subject: [PATCH] external: add timeout to rgw admin ops api request The rgw endpoint validation issued an HTTP request to the admin ops api without a timeout. If the RGW is accepting connections but slow to respond, for example right after the object store was created, the script hangs indefinitely instead of reporting a validation error that the caller could retry on. Signed-off-by: Joshua Hoblitt --- deploy/examples/create-external-cluster-resources.py | 2 ++ 1 file changed, 2 insertions(+) diff --git a/deploy/examples/create-external-cluster-resources.py b/deploy/examples/create-external-cluster-resources.py index c6c17c697..6b513b983 100644 --- a/deploy/examples/create-external-cluster-resources.py +++ b/deploy/examples/create-external-cluster-resources.py @@ -1432,10 +1432,12 @@ class RadosJSON: request_url = base_url + urlencode(params) try: + # requests.get without a timeout could hang forever on an unresponsive endpoint r = requests.get( request_url, auth=S3Auth(access_key, secret_key, rgw_endpoint), verify=verify, + timeout=30, ) except requests.exceptions.Timeout: sys.stderr.write(