From 5bf2d71ed82a2441dc5ff164cb62a47a1a7fe90d Mon Sep 17 00:00:00 2001 From: Niels de Vos Date: Fri, 2 Aug 2019 12:38:32 +0200 Subject: [PATCH] ceph-csi: pass --pidlimit option to provisioners The Ceph-CSI provisioners can hit a resource limit that is configured by the container runtime (CRI-O restrict the number of processes/threads in a container to 1024 by default). When there are spikes in the provisioning, it is possible that the provisioners or helper executables are not able to start new child processes, causing delays in the volume creation or deletion. A new --pidlimit command flag has been introduced with ceph/ceph-csi#517 and can be used to prevent the resource restrictions. This makes it possible for the provisioners to stay responsive during spikes in the requests. The PID limit is configured to 'max' (value -1), but this can be adapted to a (large) static value if needed. See-also: https://github.com/ceph/ceph-csi/pull/517 Signed-off-by: Niels de Vos --- .../ceph/csi/template/cephfs/csi-cephfsplugin-provisioner.yaml | 1 + .../ceph/csi/template/rbd/csi-rbdplugin-provisioner.yaml | 1 + tests/framework/installer/ceph_csi_templates.go | 2 ++ 3 files changed, 4 insertions(+) diff --git a/cluster/examples/kubernetes/ceph/csi/template/cephfs/csi-cephfsplugin-provisioner.yaml b/cluster/examples/kubernetes/ceph/csi/template/cephfs/csi-cephfsplugin-provisioner.yaml index 3f2f4ffa6..8d5185469 100644 --- a/cluster/examples/kubernetes/ceph/csi/template/cephfs/csi-cephfsplugin-provisioner.yaml +++ b/cluster/examples/kubernetes/ceph/csi/template/cephfs/csi-cephfsplugin-provisioner.yaml @@ -55,6 +55,7 @@ spec: - "--v=5" - "--drivername=cephfs.csi.ceph.com" - "--metadatastorage=k8s_configmap" + - "--pidlimit=-1" env: - name: NODE_ID valueFrom: diff --git a/cluster/examples/kubernetes/ceph/csi/template/rbd/csi-rbdplugin-provisioner.yaml b/cluster/examples/kubernetes/ceph/csi/template/rbd/csi-rbdplugin-provisioner.yaml index 757386fdd..ef45fbc8d 100644 --- a/cluster/examples/kubernetes/ceph/csi/template/rbd/csi-rbdplugin-provisioner.yaml +++ b/cluster/examples/kubernetes/ceph/csi/template/rbd/csi-rbdplugin-provisioner.yaml @@ -70,6 +70,7 @@ spec: - "--type=rbd" - "--drivername=rbd.csi.ceph.com" - "--containerized=true" + - "--pidlimit=-1" env: - name: HOST_ROOTFS value: "/rootfs" diff --git a/tests/framework/installer/ceph_csi_templates.go b/tests/framework/installer/ceph_csi_templates.go index d57f62459..7f8cb00ec 100644 --- a/tests/framework/installer/ceph_csi_templates.go +++ b/tests/framework/installer/ceph_csi_templates.go @@ -92,6 +92,7 @@ const ( - "--drivername=rbd.csi.ceph.com" - "--containerized=true" - "--metadatastorage=k8s_configmap" + - "--pidlimit=-1" env: - name: HOST_ROOTFS value: "/rootfs" @@ -321,6 +322,7 @@ const ( - "--type=cephfs" - "--drivername=cephfs.csi.ceph.com" - "--metadatastorage=k8s_configmap" + - "--pidlimit=-1" env: - name: NODE_ID valueFrom: