From 62e3ffb2ba2977f5cdc13c386749ccd3a18fbff3 Mon Sep 17 00:00:00 2001 From: parth-gr Date: Mon, 7 Aug 2023 17:27:19 +0530 Subject: [PATCH] helm: install rook in openshift cluster The sccs were missing in the helm installation, added it Closes: https://github.com/rook/rook/issues/12280 Signed-off-by: parth-gr --- .../Getting-Started/ceph-openshift.md | 4 + .../templates/securityContextConstraints.yaml | 44 ++++++++++ .../rook-ceph/templates/deployment.yaml | 5 ++ .../templates/securityContextConstraints.yaml | 87 +++++++++++++++++++ 4 files changed, 140 insertions(+) create mode 100644 deploy/charts/rook-ceph-cluster/templates/securityContextConstraints.yaml create mode 100644 deploy/charts/rook-ceph/templates/securityContextConstraints.yaml diff --git a/Documentation/Getting-Started/ceph-openshift.md b/Documentation/Getting-Started/ceph-openshift.md index 28ea0296b..a2e23a0d0 100644 --- a/Documentation/Getting-Started/ceph-openshift.md +++ b/Documentation/Getting-Started/ceph-openshift.md @@ -21,6 +21,10 @@ oc create -f operator-openshift.yaml oc create -f cluster.yaml ``` +## Helm Installation + +Configuration required for Openshift is automatically created by the Helm charts, such as the SecurityContextConstraints. See the [Rook Helm Charts](../Helm-Charts/helm-charts.md). + ## Rook Privileges To orchestrate the storage platform, Rook requires the following access in the cluster: diff --git a/deploy/charts/rook-ceph-cluster/templates/securityContextConstraints.yaml b/deploy/charts/rook-ceph-cluster/templates/securityContextConstraints.yaml new file mode 100644 index 000000000..893350a9b --- /dev/null +++ b/deploy/charts/rook-ceph-cluster/templates/securityContextConstraints.yaml @@ -0,0 +1,44 @@ +# scc for the Rook and Ceph daemons +# for creating cluster in openshift +{{- if .Capabilities.APIVersions.Has "security.openshift.io/v1" }} +kind: SecurityContextConstraints +apiVersion: security.openshift.io/v1 +metadata: + name: rook-cluster-{{ .Release.Namespace }} +allowPrivilegedContainer: true +allowHostDirVolumePlugin: true +allowHostPID: false +# set to true if running rook with host networking enabled +allowHostNetwork: false +# set to true if running rook with the provider as host +allowHostPorts: false +priority: +allowedCapabilities: ["MKNOD"] +allowHostIPC: true +readOnlyRootFilesystem: false +# drop all default privileges +requiredDropCapabilities: ["All"] +defaultAddCapabilities: [] +runAsUser: + type: RunAsAny +seLinuxContext: + type: MustRunAs +fsGroup: + type: MustRunAs +supplementalGroups: + type: RunAsAny +volumes: + - configMap + - downwardAPI + - emptyDir + - hostPath + - persistentVolumeClaim + - projected + - secret +users: + # A user needs to be added for each rook service account. + - system:serviceaccount:{{ .Release.Namespace }}:default + - system:serviceaccount:{{ .Release.Namespace }}:rook-ceph-mgr + - system:serviceaccount:{{ .Release.Namespace }}:rook-ceph-osd + - system:serviceaccount:{{ .Release.Namespace }}:rook-ceph-rgw +{{- end }} diff --git a/deploy/charts/rook-ceph/templates/deployment.yaml b/deploy/charts/rook-ceph/templates/deployment.yaml index 2bc7ca2e8..05ae321f9 100644 --- a/deploy/charts/rook-ceph/templates/deployment.yaml +++ b/deploy/charts/rook-ceph/templates/deployment.yaml @@ -79,8 +79,13 @@ spec: value: {{ .Values.discover.resources }} {{- end }} {{- end }} +{{- if .Capabilities.APIVersions.Has "security.openshift.io/v1" }} + - name: ROOK_HOSTPATH_REQUIRES_PRIVILEGED + value: "true" +{{- else }} - name: ROOK_HOSTPATH_REQUIRES_PRIVILEGED value: "{{ .Values.hostpathRequiresPrivileged }}" +{{- end }} - name: ROOK_DISABLE_DEVICE_HOTPLUG value: "{{ .Values.disableDeviceHotplug }}" - name: DISCOVER_DAEMON_UDEV_BLACKLIST diff --git a/deploy/charts/rook-ceph/templates/securityContextConstraints.yaml b/deploy/charts/rook-ceph/templates/securityContextConstraints.yaml new file mode 100644 index 000000000..b18ea33a8 --- /dev/null +++ b/deploy/charts/rook-ceph/templates/securityContextConstraints.yaml @@ -0,0 +1,87 @@ +# scc for the Rook and Ceph daemons +# for creating cluster in openshift +{{- if .Capabilities.APIVersions.Has "security.openshift.io/v1" }} +kind: SecurityContextConstraints +apiVersion: security.openshift.io/v1 +metadata: + name: rook-ceph +allowPrivilegedContainer: true +allowHostDirVolumePlugin: true +allowHostPID: false +# set to true if running rook with host networking enabled +allowHostNetwork: false +# set to true if running rook with the provider as host +allowHostPorts: false +priority: +allowedCapabilities: ["MKNOD"] +allowHostIPC: true +readOnlyRootFilesystem: false +# drop all default privileges +requiredDropCapabilities: ["All"] +defaultAddCapabilities: [] +runAsUser: + type: RunAsAny +seLinuxContext: + type: MustRunAs +fsGroup: + type: MustRunAs +supplementalGroups: + type: RunAsAny +volumes: + - configMap + - downwardAPI + - emptyDir + - hostPath + - persistentVolumeClaim + - projected + - secret +users: + # A user needs to be added for each rook service account. + - system:serviceaccount:{{ .Release.Namespace }}:rook-ceph-system +--- +# scc for the CSI driver +kind: SecurityContextConstraints +apiVersion: security.openshift.io/v1 +metadata: + name: rook-ceph-csi +# To allow running privilegedContainers +allowPrivilegedContainer: true +# CSI daemonset pod needs hostnetworking +allowHostNetwork: true +# This need to be set to true as we use HostPath +allowHostDirVolumePlugin: true +priority: +# SYS_ADMIN is needed for rbd to execute rbd map command +allowedCapabilities: ["SYS_ADMIN"] +# Needed as we run liveness container on daemonset pods +allowHostPorts: true +# Needed as we are setting this in RBD plugin pod +allowHostPID: true +# Required for encryption +allowHostIPC: true +# Set to false as we write to RootFilesystem inside csi containers +readOnlyRootFilesystem: false +runAsUser: + type: RunAsAny +seLinuxContext: + type: RunAsAny +fsGroup: + type: RunAsAny +supplementalGroups: + type: RunAsAny +# The type of volumes which are mounted to csi pods +volumes: + - configMap + - projected + - emptyDir + - hostPath +users: + # A user needs to be added for each rook service account. + - system:serviceaccount:{{ .Release.Namespace }}:rook-csi-rbd-plugin-sa + - system:serviceaccount:{{ .Release.Namespace }}:rook-csi-rbd-provisioner-sa + - system:serviceaccount:{{ .Release.Namespace }}:rook-csi-cephfs-plugin-sa + - system:serviceaccount:{{ .Release.Namespace }}:rook-csi-cephfs-provisioner-sa + - system:serviceaccount:{{ .Release.Namespace }}:rook-csi-nfs-plugin-sa + - system:serviceaccount:{{ .Release.Namespace }}:rook-csi-nfs-provisioner-sa +--- +{{- end }}