From 64fe9f7685a8f55dd8a199f168c5dfc2cac2d5e9 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?S=C3=A9bastien=20Han?= Date: Thu, 5 Nov 2020 18:24:06 +0100 Subject: [PATCH] ceph: introduced unsupported releases MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit These are a collection of unstable ceph release that are not recommended for production. It is recommended to rollback to the previous or upgrading to the next one if possible. Signed-off-by: Sébastien Han --- pkg/operator/ceph/cluster/version.go | 4 +++ pkg/operator/ceph/version/version.go | 23 +++++++++++++-- pkg/operator/ceph/version/version_test.go | 36 +++++++++++++++++++++-- 3 files changed, 58 insertions(+), 5 deletions(-) diff --git a/pkg/operator/ceph/cluster/version.go b/pkg/operator/ceph/cluster/version.go index 6610b2a67..564f943d2 100644 --- a/pkg/operator/ceph/cluster/version.go +++ b/pkg/operator/ceph/cluster/version.go @@ -164,6 +164,10 @@ func (c *cluster) validateCephVersion(version *cephver.CephVersion) error { } logger.Warningf("unsupported ceph version detected: %q, pursuing", version) } + + if version.Unsupported() { + logger.Errorf("UNSUPPORTED: ceph version %q detected, it is recommended to rollback to the previous pin-point stable release, pursuing anyways", version) + } } // The following tries to determine if the operator can proceed with an upgrade because we come from an OnAdd() call diff --git a/pkg/operator/ceph/version/version.go b/pkg/operator/ceph/version/version.go index d873a7363..7b684f7a9 100644 --- a/pkg/operator/ceph/version/version.go +++ b/pkg/operator/ceph/version/version.go @@ -47,9 +47,14 @@ var ( // Pacific Ceph version Pacific = CephVersion{16, 0, 0, 0} + // cephVolumeLVMDiskSortingCephVersion introduced a major regression in c-v and thus is not suitable for production + cephVolumeLVMDiskSortingCephVersion = CephVersion{Major: 14, Minor: 2, Extra: 13} + // supportedVersions are production-ready versions that rook supports - supportedVersions = []CephVersion{Nautilus, Octopus} - unsupportedVersions = []CephVersion{Pacific} + supportedVersions = []CephVersion{Nautilus, Octopus} + + // unsupportedVersions are possibly Ceph pin-point release that introduced breaking changes and not recommended + unsupportedVersions = []CephVersion{cephVolumeLVMDiskSortingCephVersion} // for parsing the output of `ceph --version` versionPattern = regexp.MustCompile(`ceph version (\d+)\.(\d+)\.(\d+)`) @@ -130,10 +135,24 @@ func (v *CephVersion) Supported() bool { return false } +// Unsupported checks if a given release is supported +func (v *CephVersion) Unsupported() bool { + for _, sv := range unsupportedVersions { + if v.isExactly(sv) { + return true + } + } + return false +} + func (v *CephVersion) isRelease(other CephVersion) bool { return v.Major == other.Major } +func (v *CephVersion) isExactly(other CephVersion) bool { + return v.Major == other.Major && v.Minor == other.Minor && v.Extra == other.Extra +} + // IsNautilus checks if the Ceph version is Nautilus func (v *CephVersion) IsNautilus() bool { return v.isRelease(Nautilus) diff --git a/pkg/operator/ceph/version/version_test.go b/pkg/operator/ceph/version/version_test.go index 5c8e17681..88c0840fa 100644 --- a/pkg/operator/ceph/version/version_test.go +++ b/pkg/operator/ceph/version/version_test.go @@ -97,9 +97,6 @@ func TestSupported(t *testing.T) { for _, v := range supportedVersions { assert.True(t, v.Supported()) } - for _, v := range unsupportedVersions { - assert.False(t, v.Supported()) - } } func TestIsRelease(t *testing.T) { @@ -203,3 +200,36 @@ func TestValidateCephVersionsBetweenLocalAndExternalClusters(t *testing.T) { err = ValidateCephVersionsBetweenLocalAndExternalClusters(localCephVersion, externalCephVersion) assert.NoError(t, err) } + +func TestCephVersion_Unsupported(t *testing.T) { + type fields struct { + Major int + Minor int + Extra int + Build int + } + tests := []struct { + name string + fields fields + want bool + }{ + {"supported", fields{Major: 14, Minor: 2, Extra: 1, Build: 0}, false}, + {"supported", fields{Major: 14, Minor: 2, Extra: 12, Build: 0}, false}, + {"supported", fields{Major: 15, Minor: 2, Extra: 1, Build: 0}, false}, + {"supported", fields{Major: 15, Minor: 2, Extra: 6, Build: 0}, false}, + {"unsupported", fields{Major: 14, Minor: 2, Extra: 13, Build: 0}, true}, + } + for _, tt := range tests { + t.Run(tt.name, func(t *testing.T) { + v := &CephVersion{ + Major: tt.fields.Major, + Minor: tt.fields.Minor, + Extra: tt.fields.Extra, + Build: tt.fields.Build, + } + if got := v.Unsupported(); got != tt.want { + t.Errorf("CephVersion.Unsupported() = %v, want %v", got, tt.want) + } + }) + } +}