From 67925c9bbee6fcd0bef006a103c2fa05630c78cb Mon Sep 17 00:00:00 2001 From: Oded Viner Date: Wed, 16 Jul 2025 12:13:10 +0300 Subject: [PATCH] core: update rook to go 1.24.3 update rook to go 1.24.3 Signed-off-by: Oded Viner --- .github/workflows/build.yml | 4 ++-- .github/workflows/codegen.yml | 2 +- .github/workflows/crds-gen.yml | 2 +- .github/workflows/daily-nightly-jobs.yml | 2 +- .github/workflows/docs-check.yml | 2 +- .github/workflows/golangci-lint.yaml | 4 ++-- .../workflows/integration-test-config-latest-k8s/action.yaml | 2 +- .github/workflows/mod-check.yml | 2 +- .github/workflows/multus.yaml | 2 +- .github/workflows/push-build.yaml | 2 +- .github/workflows/rbac-gen.yaml | 2 +- .github/workflows/unit-test.yml | 2 +- build/makelib/golang.mk | 2 +- go.mod | 4 +--- pkg/apis/go.mod | 4 +--- 15 files changed, 17 insertions(+), 21 deletions(-) diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml index 2b7cdaa49..0797e3f41 100644 --- a/.github/workflows/build.yml +++ b/.github/workflows/build.yml @@ -27,7 +27,7 @@ jobs: - uses: actions/setup-go@d35c59abb061a4a6fb18e82ac0862c26744d6ab5 # v5.5.0 with: - go-version: "1.23" + go-version: "1.24" - name: Set up Helm uses: azure/setup-helm@b9e51907a09c216f16ebe8536097933489208112 # v4.3.0 @@ -71,7 +71,7 @@ jobs: strategy: fail-fast: false matrix: - go-version: ["1.23", "1.24"] + go-version: ["1.24"] steps: - name: checkout uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4.2.2 diff --git a/.github/workflows/codegen.yml b/.github/workflows/codegen.yml index 507c5158b..83309b29a 100644 --- a/.github/workflows/codegen.yml +++ b/.github/workflows/codegen.yml @@ -36,7 +36,7 @@ jobs: - uses: actions/setup-go@d35c59abb061a4a6fb18e82ac0862c26744d6ab5 # v5.5.0 with: - go-version: "1.23" + go-version: "1.24" - name: run codegen run: GOPATH=$(go env GOPATH) make codegen diff --git a/.github/workflows/crds-gen.yml b/.github/workflows/crds-gen.yml index 4059f270a..d7236843a 100644 --- a/.github/workflows/crds-gen.yml +++ b/.github/workflows/crds-gen.yml @@ -35,7 +35,7 @@ jobs: - uses: actions/setup-go@d35c59abb061a4a6fb18e82ac0862c26744d6ab5 # v5.5.0 with: - go-version: "1.23" + go-version: "1.24" - name: run crds-gen run: GOPATH=$(go env GOPATH) make crds diff --git a/.github/workflows/daily-nightly-jobs.yml b/.github/workflows/daily-nightly-jobs.yml index 232f225fb..949d074ec 100644 --- a/.github/workflows/daily-nightly-jobs.yml +++ b/.github/workflows/daily-nightly-jobs.yml @@ -31,7 +31,7 @@ jobs: - name: setup golang uses: actions/setup-go@d35c59abb061a4a6fb18e82ac0862c26744d6ab5 # v5.5.0 with: - go-version: "1.23" + go-version: "1.24" - name: Install Docker run: | diff --git a/.github/workflows/docs-check.yml b/.github/workflows/docs-check.yml index 30b48c8ff..85548c424 100644 --- a/.github/workflows/docs-check.yml +++ b/.github/workflows/docs-check.yml @@ -30,7 +30,7 @@ jobs: - uses: actions/setup-go@d35c59abb061a4a6fb18e82ac0862c26744d6ab5 # v5.5.0 with: - go-version: "1.23" + go-version: "1.24" - uses: actions/setup-python@a26af69be951a213d495a4c3e4e4022e16d87065 # v5.6.0 with: diff --git a/.github/workflows/golangci-lint.yaml b/.github/workflows/golangci-lint.yaml index 1cae7a72b..f654b1329 100644 --- a/.github/workflows/golangci-lint.yaml +++ b/.github/workflows/golangci-lint.yaml @@ -29,7 +29,7 @@ jobs: fetch-depth: 0 - uses: actions/setup-go@d35c59abb061a4a6fb18e82ac0862c26744d6ab5 # v5.5.0 with: - go-version: "1.23" + go-version: "1.24" - name: golangci-lint uses: golangci/golangci-lint-action@4afd733a84b1f43292c63897423277bb7f4313a9 # v8.0.0 with: @@ -45,7 +45,7 @@ jobs: steps: - uses: actions/setup-go@d35c59abb061a4a6fb18e82ac0862c26744d6ab5 # v5.5.0 with: - go-version: "1.23" + go-version: "1.24" check-latest: true - name: govulncheck uses: golang/govulncheck-action@b625fbe08f3bccbe446d94fbf87fcc875a4f50ee # v1.0.4 diff --git a/.github/workflows/integration-test-config-latest-k8s/action.yaml b/.github/workflows/integration-test-config-latest-k8s/action.yaml index 34a956a19..ff0f3aa4c 100644 --- a/.github/workflows/integration-test-config-latest-k8s/action.yaml +++ b/.github/workflows/integration-test-config-latest-k8s/action.yaml @@ -20,7 +20,7 @@ runs: - name: setup golang uses: actions/setup-go@v5 with: - go-version: "1.23" + go-version: "1.24" - name: Setup Minikube shell: bash --noprofile --norc -eo pipefail -x {0} diff --git a/.github/workflows/mod-check.yml b/.github/workflows/mod-check.yml index cda09502d..39c7e3e72 100644 --- a/.github/workflows/mod-check.yml +++ b/.github/workflows/mod-check.yml @@ -35,7 +35,7 @@ jobs: - uses: actions/setup-go@d35c59abb061a4a6fb18e82ac0862c26744d6ab5 # v5.5.0 with: - go-version: "1.23" + go-version: "1.24" - name: run mod check run: GOPATH=$(go env GOPATH) make -j $(nproc) mod.check diff --git a/.github/workflows/multus.yaml b/.github/workflows/multus.yaml index df556d692..2beaab13d 100644 --- a/.github/workflows/multus.yaml +++ b/.github/workflows/multus.yaml @@ -43,7 +43,7 @@ jobs: - name: Set up Go version uses: actions/setup-go@d35c59abb061a4a6fb18e82ac0862c26744d6ab5 # v5.5.0 with: - go-version: "1.23" + go-version: "1.24" - name: Create KinD Cluster uses: helm/kind-action@a1b0e391336a6ee6713a0583f8c6240d70863de3 # v1.12.0 diff --git a/.github/workflows/push-build.yaml b/.github/workflows/push-build.yaml index 96af11cb9..283425741 100644 --- a/.github/workflows/push-build.yaml +++ b/.github/workflows/push-build.yaml @@ -28,7 +28,7 @@ jobs: - uses: actions/setup-go@d35c59abb061a4a6fb18e82ac0862c26744d6ab5 # v5.5.0 with: - go-version: "1.23" + go-version: "1.24" # docker/setup-qemu action installs QEMU static binaries, which are used to run builders for architectures other than the host. - name: set up QEMU diff --git a/.github/workflows/rbac-gen.yaml b/.github/workflows/rbac-gen.yaml index 4eec24a07..735ecc7c7 100644 --- a/.github/workflows/rbac-gen.yaml +++ b/.github/workflows/rbac-gen.yaml @@ -35,7 +35,7 @@ jobs: - uses: actions/setup-go@d35c59abb061a4a6fb18e82ac0862c26744d6ab5 # v5.5.0 with: - go-version: "1.23" + go-version: "1.24" - name: run gen-rbac run: GOPATH=$(go env GOPATH) make gen-rbac diff --git a/.github/workflows/unit-test.yml b/.github/workflows/unit-test.yml index 86aadd022..0c3ffa4fd 100644 --- a/.github/workflows/unit-test.yml +++ b/.github/workflows/unit-test.yml @@ -43,7 +43,7 @@ jobs: - uses: actions/setup-go@d35c59abb061a4a6fb18e82ac0862c26744d6ab5 # v5.5.0 with: - go-version: "1.23" + go-version: "1.24" - name: Setup jq uses: dcarbone/install-jq-action@b7ef57d46ece78760b4019dbc4080a1ba2a40b45 # v3.2.0 diff --git a/build/makelib/golang.mk b/build/makelib/golang.mk index 4b3c77d9c..7c3c610fd 100644 --- a/build/makelib/golang.mk +++ b/build/makelib/golang.mk @@ -48,7 +48,7 @@ GO_TEST_FLAGS ?= # ==================================================================================== # Setup go environment -GO_SUPPORTED_VERSIONS ?= 1.23|1.24 +GO_SUPPORTED_VERSIONS ?= 1.24 GO_PACKAGES := $(foreach t,$(GO_SUBDIRS),$(GO_PROJECT)/$(t)/...) GO_INTEGRATION_TEST_PACKAGES := $(foreach t,$(GO_INTEGRATION_TESTS_SUBDIRS),$(GO_PROJECT)/$(t)/integration) diff --git a/go.mod b/go.mod index 42eb43cac..7941349fe 100644 --- a/go.mod +++ b/go.mod @@ -1,8 +1,6 @@ module github.com/rook/rook -go 1.23.0 - -toolchain go1.23.4 +go 1.24.3 replace ( github.com/googleapis/gnostic => github.com/googleapis/gnostic v0.4.1 diff --git a/pkg/apis/go.mod b/pkg/apis/go.mod index 875ceed40..499790670 100644 --- a/pkg/apis/go.mod +++ b/pkg/apis/go.mod @@ -1,8 +1,6 @@ module github.com/rook/rook/pkg/apis -go 1.23.0 - -toolchain go1.23.4 +go 1.24.3 replace ( github.com/googleapis/gnostic => github.com/googleapis/gnostic v0.4.1