From 73b0ce08ffabe0d018bf9590daf8f3d55b78ed5a Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?S=C3=A9bastien=20Han?= Date: Tue, 3 Aug 2021 11:47:13 +0200 Subject: [PATCH] ceph: do not stack trace on error MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit We should not use %+v when printing errors and wrapping it in the caller. Passing %+v to errors.Wrap() returns a strack trace. See: ``` 2021-08-03 09:42:40.460946 E | ceph-file-controller: failed to reconcile failed to create filesystem "myfs2": failed to start deployment for MDS "a" for filesystem "myfs2": failed to update mds deployment "rook-ceph-mds-myfs2-a": failed to check if deployment "rook-ceph-mds-myfs2-a" can continue: failed to check if we can continue the deployment rook-ceph-mds-myfs2-a: failed to check if rook-ceph-mds-myfs2-a was ok to continue: max retries exceeded, last err: mds myfs2-a is up:creating, bad state github.com/rook/rook/pkg/daemon/ceph/client.MdsActiveOrStandbyReplay /home/leseb/go/src/github.com/rook/rook/pkg/daemon/ceph/client/status.go:286 github.com/rook/rook/pkg/daemon/ceph/client.okToContinueMDSDaemon.func1 /home/leseb/go/src/github.com/rook/rook/pkg/daemon/ceph/client/upgrade.go:215 github.com/rook/rook/pkg/util.Retry /home/leseb/go/src/github.com/rook/rook/pkg/util/retry.go:31 github.com/rook/rook/pkg/daemon/ceph/client.okToContinueMDSDaemon /home/leseb/go/src/github.com/rook/rook/pkg/daemon/ceph/client/upgrade.go:214 github.com/rook/rook/pkg/daemon/ceph/client.OkToContinue /home/leseb/go/src/github.com/rook/rook/pkg/daemon/ceph/client/upgrade.go:181 github.com/rook/rook/pkg/operator/ceph/cluster/mon.UpdateCephDeploymentAndWait.func1 /home/leseb/go/src/github.com/rook/rook/pkg/operator/ceph/cluster/mon/spec.go:370 github.com/rook/rook/pkg/operator/k8sutil.UpdateDeploymentAndWait /home/leseb/go/src/github.com/rook/rook/pkg/operator/k8sutil/deployment.go:113 github.com/rook/rook/pkg/operator/ceph/cluster/mon.UpdateCephDeploymentAndWait /home/leseb/go/src/github.com/rook/rook/pkg/operator/ceph/cluster/mon/spec.go:383 github.com/rook/rook/pkg/operator/ceph/file/mds.(*Cluster).startDeployment /home/leseb/go/src/github.com/rook/rook/pkg/operator/ceph/file/mds/mds.go:216 github.com/rook/rook/pkg/operator/ceph/file/mds.(*Cluster).Start /home/leseb/go/src/github.com/rook/rook/pkg/operator/ceph/file/mds/mds.go:138 github.com/rook/rook/pkg/operator/ceph/file.createFilesystem /home/leseb/go/src/github.com/rook/rook/pkg/operator/ceph/file/filesystem.go:81 github.com/rook/rook/pkg/operator/ceph/file.(*ReconcileCephFilesystem).reconcileCreateFilesystem /home/leseb/go/src/github.com/rook/rook/pkg/operator/ceph/file/controller.go:373 github.com/rook/rook/pkg/operator/ceph/file.(*ReconcileCephFilesystem).reconcile /home/leseb/go/src/github.com/rook/rook/pkg/operator/ceph/file/controller.go:288 github.com/rook/rook/pkg/operator/ceph/file.(*ReconcileCephFilesystem).Reconcile /home/leseb/go/src/github.com/rook/rook/pkg/operator/ceph/file/controller.go:167 sigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).reconcileHandler /home/leseb/go/pkg/mod/sigs.k8s.io/controller-runtime@v0.9.0/pkg/internal/controller/controller.go:298 sigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).processNextWorkItem /home/leseb/go/pkg/mod/sigs.k8s.io/controller-runtime@v0.9.0/pkg/internal/controller/controller.go:253 sigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).Start.func2.2 /home/leseb/go/pkg/mod/sigs.k8s.io/controller-runtime@v0.9.0/pkg/internal/controller/controller.go:214 runtime.goexit /usr/local/go/src/runtime/asm_amd64.s:1371 ``` Signed-off-by: Sébastien Han --- pkg/util/retry.go | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pkg/util/retry.go b/pkg/util/retry.go index 3c15141ea..27622e805 100644 --- a/pkg/util/retry.go +++ b/pkg/util/retry.go @@ -36,7 +36,7 @@ func Retry(maxRetries int, delay time.Duration, f func() error) error { tries++ if tries > maxRetries { - return fmt.Errorf("max retries exceeded, last err: %+v", err) + return fmt.Errorf("max retries exceeded, last err: %v", err) } logger.Infof("retrying after %v, last error: %v", delay, err)