forked from rook/rook
build: introduce a linting target name taxonomy
The linting targets used to mostly have ad-hoc names usually reflecting the linting tool used (like shellcheck, yamllint, and checkmake). This change systematizes the names of the linting targets to follow a pattern of lint.foo where foo usually reflects *what* is linted rather than *how*. so, more idiomatically, the pattern can be described as "action.thing" to indicacte that "action" is to be performed on a "thing". This systematization is achieved by renaming a couple of targets: - shellcheck -> lint.shell - yamllint -> lint.yaml - checkmake -> lint.make 0 helm.lint -> lint.helm - pylint -> lint.python fmt -> lint.fmt Additionally, a new target go.lint is introduced that runs several go linting tools. Finally, two fixing targets are renamed for consistency: * fmt-fix -> fix.fmt * markdownlint.fix -> fix/markdown Signed-off-by: Michael Adam <obnox@samba.org> Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
This commit is contained in:
co-authored by
Copilot Autofix powered by AI
parent
05f1b00b81
commit
74c41f16cc
@@ -31,5 +31,5 @@ jobs:
|
||||
fetch-depth: 0
|
||||
|
||||
|
||||
- name: Run chart-testing (lint)
|
||||
run: make helm.lint
|
||||
- name: Lint the helm charts
|
||||
run: make lint.helm
|
||||
@@ -28,7 +28,7 @@ jobs:
|
||||
fetch-depth: 0
|
||||
|
||||
- name: Lint YAML files
|
||||
run: make yamllint
|
||||
run: make lint.yaml
|
||||
|
||||
pylint:
|
||||
runs-on: ubuntu-latest
|
||||
@@ -49,8 +49,8 @@ jobs:
|
||||
pip install requests
|
||||
pip install pygit2
|
||||
|
||||
- name: Lint Python files
|
||||
run: make pylint
|
||||
- name: Lint Python scripts
|
||||
run: make lint.python
|
||||
|
||||
- name: Setup black for py
|
||||
uses: psf/black@c6755bb741b6481d6b3d3bb563c83fa060db96c9 # stable
|
||||
|
||||
@@ -25,5 +25,5 @@ jobs:
|
||||
runs-on: ubuntu-latest
|
||||
steps:
|
||||
- uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2
|
||||
- name: Run ShellCheck
|
||||
run: make shellcheck
|
||||
- name: Lint shell scripts
|
||||
run: make lint.shell
|
||||
|
||||
Reference in New Issue
Block a user