From 802a86ccd5013da977695b91cc4d9b91db0ca53c Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?S=C3=A9bastien=20Han?= Date: Fri, 21 Jan 2022 10:19:21 +0100 Subject: [PATCH] ci: fix encryption test condition MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit For the "if" to work we need to bring the env in the step with the "env" keyword. Otherwise, the env is never imported and the condition is always false. Signed-off-by: Sébastien Han --- .github/workflows/canary-integration-test.yml | 5 ++++- .github/workflows/daily-nightly-jobs.yml | 3 +++ 2 files changed, 7 insertions(+), 1 deletion(-) diff --git a/.github/workflows/canary-integration-test.yml b/.github/workflows/canary-integration-test.yml index 2111c1a6b..9aa1c7d30 100644 --- a/.github/workflows/canary-integration-test.yml +++ b/.github/workflows/canary-integration-test.yml @@ -838,9 +838,12 @@ jobs: with: fetch-depth: 0 - - name: run Encryption KMS IBM Key Protect + - name: run encryption KMS IBM Key Protect uses: ./.github/workflows/encryption-pvc-kms-ibm-kp if: "env.IBM_KP_SERVICE_INSTANCE_ID != '' && env.IBM_KP_SERVICE_API_KEY != ''" + env: + IBM_KP_SERVICE_INSTANCE_ID: ${{ secrets.IBM_INSTANCE_ID }} + IBM_KP_SERVICE_API_KEY: ${{ secrets.IBM_SERVICE_API_KEY }} with: ibm-instance-id: ${{ secrets.IBM_INSTANCE_ID }} ibm-service-api-key: ${{ secrets.IBM_SERVICE_API_KEY }} diff --git a/.github/workflows/daily-nightly-jobs.yml b/.github/workflows/daily-nightly-jobs.yml index 3458b4391..8318b8278 100644 --- a/.github/workflows/daily-nightly-jobs.yml +++ b/.github/workflows/daily-nightly-jobs.yml @@ -327,6 +327,9 @@ jobs: - name: run Encryption KMS IBM Key Protect uses: ./.github/workflows/encryption-pvc-kms-ibm-kp if: "env.IBM_KP_SERVICE_INSTANCE_ID != '' && env.IBM_KP_SERVICE_API_KEY != ''" + env: + IBM_KP_SERVICE_INSTANCE_ID: ${{ secrets.IBM_INSTANCE_ID }} + IBM_KP_SERVICE_API_KEY: ${{ secrets.IBM_SERVICE_API_KEY }} with: github-token: ${{ secrets.GITHUB_TOKEN }} ibm-instance-id: ${{ secrets.IBM_KP_INSTANCE_ID }}