From 8a80743bf897492e82d8340e825bde205da8d34b Mon Sep 17 00:00:00 2001 From: Michael Adam Date: Wed, 4 Mar 2026 18:46:27 +0100 Subject: [PATCH] build: let checkmake pass locally checkmake was locally still failing despite previous partial fixes, complaining about a duplicate definition of build.common. build.common was duplicate: Once for a target specific variable setting and once for the dependencies and recipe. This change fixes make checkmake locally by adding an extra target build.common.var just for setting the variable. Signed-off-by: Michael Adam --- Makefile | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/Makefile b/Makefile index 39703debd..024c6854b 100644 --- a/Makefile +++ b/Makefile @@ -120,9 +120,12 @@ build.version: @mkdir -p $(OUTPUT_DIR) @echo "$(VERSION)" > $(OUTPUT_DIR)/version +# This target exists only for setting the variable +.PHONY: build.common.var +build.common.var: export SKIP_GEN_CRD_DOCS=true + .PHONY: build.common -build.common: export SKIP_GEN_CRD_DOCS=true -build.common: build.version helm.build mod.check crds gen-rbac +build.common: build.common.var build.version helm.build mod.check crds gen-rbac @$(MAKE) go.init @$(MAKE) go.validate @$(MAKE) -C images/ceph list-image