From b585c357439815850bda1917b80f4dece9c5bea1 Mon Sep 17 00:00:00 2001 From: Satoru Takeuchi Date: Wed, 12 Nov 2025 22:12:58 +0000 Subject: [PATCH] docs: mark overwriting Ceph's configurations as breaking change Mark overwriting Ceph's configurations as breaking changes. This is to avoid troubles caused by such changes on upgrade. ref. https://github.com/rook/rook/discussions/16652 Signed-off-by: Satoru Takeuchi --- .github/PULL_REQUEST_TEMPLATE.md | 1 + 1 file changed, 1 insertion(+) diff --git a/.github/PULL_REQUEST_TEMPLATE.md b/.github/PULL_REQUEST_TEMPLATE.md index 305df966b..52b3b7ade 100644 --- a/.github/PULL_REQUEST_TEMPLATE.md +++ b/.github/PULL_REQUEST_TEMPLATE.md @@ -17,6 +17,7 @@ Resolves # - [ ] **Commit Message Formatting**: Commit titles and messages follow guidelines in the [developer guide](https://rook.io/docs/rook/latest/Contributing/development-flow/#commit-structure). - [ ] Reviewed the developer guide on [Submitting a Pull Request](https://rook.io/docs/rook/latest/Contributing/development-flow/#submitting-a-pull-request) - [ ] [Pending release notes](https://github.com/rook/rook/blob/master/PendingReleaseNotes.md) updated with breaking and/or notable changes for the next minor release. + - Overwriting Ceph's configurations should be marked as breaking changes. - [ ] Documentation has been updated, if necessary. - [ ] Unit tests have been added, if necessary. - [ ] Integration tests have been added, if necessary.