From a84aeebb4d7d889368b1161bb2e556a3cb695b11 Mon Sep 17 00:00:00 2001 From: Anthony D'Atri Date: Thu, 5 Jan 2023 13:01:31 -0500 Subject: [PATCH] docs: add limitRange comment to deploy/charts/rook-ceph-cluster/values.yaml Signed-off-by: Anthony D'Atri --- deploy/charts/rook-ceph-cluster/values.yaml | 10 ++++++++-- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/deploy/charts/rook-ceph-cluster/values.yaml b/deploy/charts/rook-ceph-cluster/values.yaml index fbdba2884..284388d43 100644 --- a/deploy/charts/rook-ceph-cluster/values.yaml +++ b/deploy/charts/rook-ceph-cluster/values.yaml @@ -269,8 +269,14 @@ cephClusterSpec: cpu: "1000m" memory: "4Gi" prepareosd: - # limits: It is not recommended to set limits on the OSD prepare job since it's a one-time burst for memory - # that must be allowed to complete without an OOM kill + # limits: It is not recommended to set limits on the OSD prepare job + # since it's a one-time burst for memory that must be allowed to + # complete without an OOM kill. Note however that if a k8s + # limitRange guardrail is defined external to Rook, the lack of + # a limit here may result in a sync failure, in which case a + # limit should be added. 1200Mi may suffice for up to 15Ti + # OSDs ; for larger devices 2Gi may be required. + # cf. https://github.com/rook/rook/pull/11103 requests: cpu: "500m" memory: "50Mi"