From c628a996c8b83f34d3ca0a454557d0ae24bd9508 Mon Sep 17 00:00:00 2001 From: Satoru Takeuchi Date: Mon, 22 Feb 2021 02:28:11 +0000 Subject: [PATCH] ceph: fix SIGSEGV when failing to get object store user We shouldn't use `user.userID` if `GetUser()` failed. Closes: https://github.com/rook/rook/issues/7278 Signed-off-by: Satoru Takeuchi --- pkg/operator/ceph/object/health.go | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pkg/operator/ceph/object/health.go b/pkg/operator/ceph/object/health.go index 519870c6a..f1ead4032 100644 --- a/pkg/operator/ceph/object/health.go +++ b/pkg/operator/ceph/object/health.go @@ -138,7 +138,7 @@ func (c *bucketChecker) checkObjectStoreHealth() error { if rgwerr == ErrorCodeFileExists { user, _, err = GetUser(c.objContext, userConfig.UserID) if err != nil { - return errors.Wrapf(err, "failed to get details from ceph object user %q for object store %q", user.UserID, c.namespacedName.Name) + return errors.Wrapf(err, "failed to get details from ceph object user %q for object store %q", userConfig.UserID, c.namespacedName.Name) } } else { return errors.Wrapf(err, "failed to create object user %q. error code %d for object store %q", userConfig.UserID, rgwerr, c.namespacedName.Name)