diff --git a/pkg/daemon/ceph/config/info.go b/pkg/daemon/ceph/config/info.go index 771242ad4..a19d7a834 100644 --- a/pkg/daemon/ceph/config/info.go +++ b/pkg/daemon/ceph/config/info.go @@ -63,6 +63,7 @@ func NewMonInfo(name, ip string, port int32) *MonInfo { func (c *ClusterInfo) Log(logger *capnslog.PackageLogger) { mons := []string{} for _, m := range c.Monitors { + // Sprintf formatting is safe as user input isn't being used. Issue https://github.com/rook/rook/issues/4575 mons = append(mons, fmt.Sprintf("{Name: %s, Endpoint: %s}", m.Name, m.Endpoint)) } monsec := "" diff --git a/pkg/operator/edgefs/cluster/utils.go b/pkg/operator/edgefs/cluster/utils.go index 15a79c99d..4ccdee6c9 100644 --- a/pkg/operator/edgefs/cluster/utils.go +++ b/pkg/operator/edgefs/cluster/utils.go @@ -290,6 +290,7 @@ func (c *cluster) AddLabelsToNode(nodeName string, labels map[string]string) err tokens = append(tokens, "\""+k+"\":\""+v+"\"") } labelString := "{" + strings.Join(tokens, ",") + "}" + // Sprintf formatting is safe as user input isn't being used. Issue https://github.com/rook/rook/issues/4575 patch := fmt.Sprintf(`{"metadata":{"labels":%v}}`, labelString) var err error for attempt := 0; attempt < labelingRetries; attempt++ {