From bb23622b72b639ea992613d271ae5ea7b97a3da5 Mon Sep 17 00:00:00 2001 From: parth-gr Date: Tue, 6 Apr 2021 17:24:15 +0530 Subject: [PATCH] core: enhancement in debug logs When DEBUG logging is enabled in the operator, there are a number of overwhelming messages in the log that are very overwhelming and don't seem useful, which makes debug mode difficult to use Updated and Cutted down the messages that are not useful in debug mode Closes: https://github.com/rook/rook/issues/7499 Signed-off-by: parth-gr --- pkg/operator/ceph/cluster/crash/reconcile.go | 1 - pkg/operator/ceph/cluster/predicate.go | 1 - pkg/operator/ceph/config/store.go | 4 ++-- pkg/operator/ceph/controller/predicate.go | 1 - 4 files changed, 2 insertions(+), 5 deletions(-) diff --git a/pkg/operator/ceph/cluster/crash/reconcile.go b/pkg/operator/ceph/cluster/crash/reconcile.go index 1248dd9cf..006dd38de 100644 --- a/pkg/operator/ceph/cluster/crash/reconcile.go +++ b/pkg/operator/ceph/cluster/crash/reconcile.go @@ -167,7 +167,6 @@ func (r *ReconcileNode) reconcile(request reconcile.Request) (reconcile.Result, hasCephPods := false for _, cephPod := range cephPods { if cephPod.Spec.NodeName == request.Name { - logger.Debugf("cephPod.Spec.NodeName is %q and request.Name is %q", cephPod.Spec.NodeName, request.Name) hasCephPods = true for _, podToleration := range cephPod.Spec.Tolerations { // Add toleration to the map diff --git a/pkg/operator/ceph/cluster/predicate.go b/pkg/operator/ceph/cluster/predicate.go index a42ea69c5..1e0afab39 100644 --- a/pkg/operator/ceph/cluster/predicate.go +++ b/pkg/operator/ceph/cluster/predicate.go @@ -116,7 +116,6 @@ func watchControllerPredicate(rookContext *clusterd.Context) predicate.Funcs { return true }, UpdateFunc: func(e event.UpdateEvent) bool { - logger.Debug("update event from a CR") // resource.Quantity has non-exportable fields, so we use its comparator method resourceQtyComparer := cmp.Comparer(func(x, y resource.Quantity) bool { return x.Cmp(y) == 0 }) diff --git a/pkg/operator/ceph/config/store.go b/pkg/operator/ceph/config/store.go index 6ab6c8bfa..5ccfa142c 100644 --- a/pkg/operator/ceph/config/store.go +++ b/pkg/operator/ceph/config/store.go @@ -100,7 +100,7 @@ func (s *Store) createOrUpdateMonHostSecrets(ctx context.Context, clusterInfo *c _, err = clientset.CoreV1().Secrets(s.namespace).Get(ctx, StoreName, metav1.GetOptions{}) if err != nil { if kerrors.IsNotFound(err) { - logger.Debugf("creating config secret %+v", secret) + logger.Debugf("creating config secret %q", secret.Name) if _, err := clientset.CoreV1().Secrets(s.namespace).Create(ctx, secret, metav1.CreateOptions{}); err != nil { return errors.Wrapf(err, "failed to create config secret %+v", secret) } @@ -109,7 +109,7 @@ func (s *Store) createOrUpdateMonHostSecrets(ctx context.Context, clusterInfo *c } } - logger.Debugf("updating config secret %+v", secret) + logger.Debugf("updating config secret %q", secret.Name) if _, err := clientset.CoreV1().Secrets(s.namespace).Update(ctx, secret, metav1.UpdateOptions{}); err != nil { return errors.Wrapf(err, "failed to update config secret %+v", secret) } diff --git a/pkg/operator/ceph/controller/predicate.go b/pkg/operator/ceph/controller/predicate.go index 3b874a3a9..d906d21e5 100644 --- a/pkg/operator/ceph/controller/predicate.go +++ b/pkg/operator/ceph/controller/predicate.go @@ -335,7 +335,6 @@ func WatchCephClusterPredicate() predicate.Funcs { return true }, UpdateFunc: func(e event.UpdateEvent) bool { - logger.Debug("update event from a CR") // resource.Quantity has non-exportable fields, so we use its comparator method resourceQtyComparer := cmp.Comparer(func(x, y resource.Quantity) bool { return x.Cmp(y) == 0 })