From bb770bb0d115b45ad897612cd47d58fa62d81d7d Mon Sep 17 00:00:00 2001
From: Arun Kumar Mohan <arun.iiird@gmail.com>
Date: Wed, 20 May 2020 21:16:23 +0530
Subject: [PATCH] Ceph: A minor fix to 'generate-rook-csv.sh' script

A square bracket check on <shell_command> return status
will not work in an 'if' condition.

Signed-off-by: Arun Kumar Mohan <arun.iiird@gmail.com>
---
 cluster/olm/ceph/generate-rook-csv.sh | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/cluster/olm/ceph/generate-rook-csv.sh b/cluster/olm/ceph/generate-rook-csv.sh
index 47d629810..585bec5a7 100755
--- a/cluster/olm/ceph/generate-rook-csv.sh
+++ b/cluster/olm/ceph/generate-rook-csv.sh
@@ -18,13 +18,13 @@ yq="${YQ_TOOL:-yq}"
 ##########
 # CHECKS #
 ##########
-if [ ! command -v operator-sdk &>/dev/null ] && [ ! -f $operator_sdk ]; then
+if ! command -v "$operator_sdk" >/dev/null && [ ! -f "$operator_sdk" ]; then
     echo "operator-sdk is not installed $operator_sdk"
     echo "follow instructions here: https://github.com/operator-framework/operator-sdk/#quick-start"
     exit 1
 fi
 
-if [ ! command -v yq &>/dev/null ] && [ ! -f $yq ]; then
+if ! command -v "$yq" >/dev/null && [ ! -f "$yq" ]; then
     echo "yq is not installed"
     echo "follow instructions here: https://github.com/mikefarah/yq#install"
     exit 1