From de172b96e874e9cc582f40d7b3965ef221bf64fb Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?S=C3=A9bastien=20Han?= Date: Fri, 8 Nov 2019 16:00:01 +0100 Subject: [PATCH] ceph: add missing errors MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit The current code wasn't returning the full error properly. Signed-off-by: Sébastien Han --- pkg/operator/ceph/disruption/clusterdisruption/location.go | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/pkg/operator/ceph/disruption/clusterdisruption/location.go b/pkg/operator/ceph/disruption/clusterdisruption/location.go index 2b56461a3..548289e04 100644 --- a/pkg/operator/ceph/disruption/clusterdisruption/location.go +++ b/pkg/operator/ceph/disruption/clusterdisruption/location.go @@ -54,18 +54,18 @@ func (r *ReconcileClusterDisruption) getOsdDataList(request reconcile.Request, p } osdIDInt, err := strconv.Atoi(osdID) if err != nil { - return nil, fmt.Errorf("osd id not an int: %s", osdID) + return nil, fmt.Errorf("failed to convert osd id %q in an int. %+v", osdID, err) } crushMeta, err := r.osdCrushLocationMap.Get(request.Namespace, osdIDInt) if err != nil { - return nil, fmt.Errorf("could not fetch info from ceph for osd %s", osdID) + return nil, fmt.Errorf("could not fetch info from ceph for osd %q. %+v", osdID, err) } // bypass the cache if the topology location is not populated in the cache _, failureDomainKnown := crushMeta.Location[poolFailureDomain] if !failureDomainKnown { crushMeta, err = r.osdCrushLocationMap.get(request.Namespace, osdIDInt) if err != nil { - return nil, fmt.Errorf("could not fetch info from ceph for osd %s", osdID) + return nil, fmt.Errorf("could not fetch info from ceph for osd %q. %+v", osdID, err) } }