From 8d89da642368b3e8bce86c2014ba95990ef709c1 Mon Sep 17 00:00:00 2001 From: Bryan Jones Date: Tue, 15 Apr 2025 13:07:35 -0400 Subject: [PATCH 1/2] helm: add labels to ingress resource Signed-off-by: Bryan Jones (cherry picked from commit 41884a19bfc33432c9c35e63f60d3fd4846b2c1b) --- deploy/charts/rook-ceph-cluster/templates/ingress.yaml | 3 +++ 1 file changed, 3 insertions(+) diff --git a/deploy/charts/rook-ceph-cluster/templates/ingress.yaml b/deploy/charts/rook-ceph-cluster/templates/ingress.yaml index ecfb7c470..47746b462 100644 --- a/deploy/charts/rook-ceph-cluster/templates/ingress.yaml +++ b/deploy/charts/rook-ceph-cluster/templates/ingress.yaml @@ -5,6 +5,9 @@ kind: Ingress metadata: name: {{ template "clusterName" . }}-dashboard namespace: {{ .Release.Namespace }} # namespace:cluster + {{- if .Values.ingress.dashboard.labels }} + labels: {{- toYaml .Values.ingress.dashboard.labels | nindent 4 }} + {{- end}} {{- if .Values.ingress.dashboard.annotations }} annotations: {{- toYaml .Values.ingress.dashboard.annotations | nindent 4 }} {{- end }} From 5096b10faf6ffe908195eadc7796cbca228fbbf8 Mon Sep 17 00:00:00 2001 From: Bryan Jones Date: Tue, 15 Apr 2025 13:12:37 -0400 Subject: [PATCH 2/2] helm: add info comments to the chart values Signed-off-by: Bryan Jones (cherry picked from commit 04cc4ee3e4cff7a7fd5f698240b3604cfdd3239e) --- deploy/charts/rook-ceph-cluster/values.yaml | 2 ++ 1 file changed, 2 insertions(+) diff --git a/deploy/charts/rook-ceph-cluster/values.yaml b/deploy/charts/rook-ceph-cluster/values.yaml index 02d9e77a0..3ff95347e 100644 --- a/deploy/charts/rook-ceph-cluster/values.yaml +++ b/deploy/charts/rook-ceph-cluster/values.yaml @@ -417,6 +417,8 @@ ingress: # -- Enable an ingress for the ceph-dashboard dashboard: {} + # labels: + # external-dns/private: "true" # annotations: # external-dns.alpha.kubernetes.io/hostname: dashboard.example.com # nginx.ingress.kubernetes.io/rewrite-target: /ceph-dashboard/$2