From f995cd1efa765f385f4a52a39a080b51f48a33e6 Mon Sep 17 00:00:00 2001 From: parth-gr Date: Mon, 7 Aug 2023 19:30:00 +0530 Subject: [PATCH] ci: improve the canary toolbox operator pod check the wait command is provided by kubernetes so instead of using manually shell hack using the wait command Signed-off-by: parth-gr (cherry picked from commit 64d3df4fcd62a790e54a18340b44de12891e3c96) --- .github/workflows/canary-integration-test.yml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/canary-integration-test.yml b/.github/workflows/canary-integration-test.yml index b8380f8a4..3fdd26703 100644 --- a/.github/workflows/canary-integration-test.yml +++ b/.github/workflows/canary-integration-test.yml @@ -302,8 +302,8 @@ jobs: - name: test toolbox-operator-image pod run: | tests/scripts/github-action-helper.sh create_operator_toolbox - toolbox=$(kubectl get pod -l app=rook-ceph-tools-operator-image -n rook-ceph -o jsonpath='{.items[*].metadata.name}') - timeout 120 sh -c "while kubectl get pod $toolbox -nrook-ceph -o jsonpath='{.items[*].status.phase}'|grep -qE 'Running'; do echo 'waiting for operator toolbox pod to start'; sleep 5; done" + # waiting for toolbox operator image pod to get ready + kubectl -n rook-ceph wait --for=condition=ready pod -l app=rook-ceph-tools-operator-image --timeout=180s - name: check-ownerreferences run: tests/scripts/github-action-helper.sh check_ownerreferences