From fff583b4b350fae1d9ac2cd7aed53c2489a41eb8 Mon Sep 17 00:00:00 2001 From: Travis Nielsen Date: Wed, 1 May 2024 15:06:56 -0600 Subject: [PATCH] mon: remove quincy check since quincy is min version With the removal of Ceph Pacific support, no need to check if Quincy is avaiable to support encryption on the wire. Signed-off-by: Travis Nielsen (cherry picked from commit 25d36c4c75e5c16cd1832549ba11666589cff148) --- pkg/operator/ceph/cluster/cluster.go | 31 ++++++++++++---------------- 1 file changed, 13 insertions(+), 18 deletions(-) diff --git a/pkg/operator/ceph/cluster/cluster.go b/pkg/operator/ceph/cluster/cluster.go index e3e64668d..38cba01bc 100755 --- a/pkg/operator/ceph/cluster/cluster.go +++ b/pkg/operator/ceph/cluster/cluster.go @@ -656,26 +656,21 @@ func (c *cluster) configureMsgr2() error { } } // Set network compression - if c.ClusterInfo.CephVersion.IsAtLeastQuincy() { - if c.Spec.Network.Connections == nil || c.Spec.Network.Connections.Compression == nil || !c.Spec.Network.Connections.Compression.Enabled { - encryptionConfig := []config.Option{ - {Who: "global", Option: "ms_osd_compress_mode"}, - } - if err := monStore.DeleteAll(encryptionConfig...); err != nil { - return errors.Wrap(err, "failed to delete msgr2 compression settings") - } - } else { - globalConfigSettings := map[string]string{ - "ms_osd_compress_mode": "force", - } - logger.Infof("setting msgr2 compression mode to %q", "force") - if err := monStore.SetAll("global", globalConfigSettings); err != nil { - return err - } + if c.Spec.Network.Connections == nil || c.Spec.Network.Connections.Compression == nil || !c.Spec.Network.Connections.Compression.Enabled { + encryptionConfig := []config.Option{ + {Who: "global", Option: "ms_osd_compress_mode"}, + } + if err := monStore.DeleteAll(encryptionConfig...); err != nil { + return errors.Wrap(err, "failed to delete msgr2 compression settings") } - } else { - logger.Warningf("network compression requires Ceph Quincy (v17) or newer, skipping for current ceph %q", c.ClusterInfo.CephVersion.String()) + globalConfigSettings := map[string]string{ + "ms_osd_compress_mode": "force", + } + logger.Infof("setting msgr2 compression mode to %q", "force") + if err := monStore.SetAll("global", globalConfigSettings); err != nil { + return err + } } return nil