feedc0de/my-rook-config
1
0 Fork 0
forked from rook/rook
Code Pull Requests Activity
8,369 Commits 38 Branches 289 Tags
00a4dc19f75b8b73708ac2a4204a7bd4bdee8f61
Commit Graph
16 Commits
Author SHA1 Message Date
vavuthu b9d8df9ec9 core: avoid creating json_out incase of dry-run 
When using dry-run option with external script, out_map dictionary
doesn't contain keys ( ACCESS_KEY and SECRET_KEY ) which leads to KeyError.
This fix to avoid creating json_out incase of dry-run since we will not use
json_out for dry-run.

Signed-off-by: vavuthu <vavuthu@redhat.com>
 2022-03-10 14:25:52 +05:30
vavuthu 149beedf20 core: assign ACCESS_KEY and SECRET_KEY values only in case of actual run 
When using dry-run option with external script, function create_rgw_admin_ops_user
is not returning expected values which leads to TypeError. This fix is to append
values to out_map dictionary only in case of actual run.

Signed-off-by: vavuthu <vavuthu@redhat.com>
 2022-03-10 14:16:13 +05:30
vavuthu ce98b17bf7 core: fix incorrect join command 
Fixing typo in join command
joing -> join

Signed-off-by: vavuthu <vavuthu@redhat.com>
 2022-03-10 13:56:37 +05:30
subhamkrai 3e6aa9e556 core: split external script unit test and main code in diff file 
split the external script main code and unit test in different file.

Closes: https://github.com/rook/rook/issues/9588
Signed-off-by: subhamkrai <srai@redhat.com>
 2022-02-24 18:23:21 +05:30
parth-gr 3e64525b62 csi: make use of common user creation method 
refactor the code so we can use common csi user
creation method

Signed-off-by: parth-gr <paarora@redhat.com>
 2022-02-16 10:29:34 +05:30
parth-gr 9b20b475cf csi: modify upgrade flag in external cluster 
The upgrade function doesn't seem to be that smart
for now so it can update the new auth caps listed
with the existing one, it only compares the value of
the current cap with the MIN_USER_CAP_PERMISSIONS,

Modified the upgrade flag functionality so we can use
this while upgrading the cluster clients

Closes: https://github.com/rook/rook/issues/9589

Signed-off-by: parth-gr <paarora@redhat.com>
 2022-02-16 10:29:34 +05:30
parth-gr 4f43f2d93e csi: make create and get process separate for csi users 
Currently if we run external-script and user already exit,
it fails to create/run same user again if the caps are upgraded,
so we need to check first if user is already present.
And for upgrading user we can do upgrade after this
PR: https://github.com/rook/rook/pull/9609 will get merged.

Closes: https://bugzilla.redhat.com/show_bug.cgi?id=2048458

Signed-off-by: parth-gr <paarora@redhat.com>
 2022-02-04 20:08:31 +05:30
parth-gr 7e851f15c6 csi: add osd blocklist capabilities to the external cephcluster 
The CSI users created by the external script(both for rbd and cephfs)
need the blocklist capability so the CSI pods can execute the
`osd blocklist` commands for metro DR
update the mon caps of csi users with `profile simple-rados-client-with-blocklist`
so they have privileges to run osd blocklist cmds

Closes: https://issues.redhat.com/browse/RHSTOR-2451

Signed-off-by: parth-gr <paarora@redhat.com>
 2022-01-18 18:01:01 +05:30
parth-gr 4a3088c580 security: make cephfs_filesystem_name flag optional 
cephfs_filesystem_name flag isn't mandatory if restricted_auth_permission
is on.

Signed-off-by: parth-gr <paarora@redhat.com>
 2022-01-07 20:27:05 +05:30
parth-gr 6ed7423bac security: update auth permissions for external cluster 
Added a clusterName, poolName , filesystemName, radosNamespace
as a suffix on ceph auth principals for external cluster so
every csi authentication would be unique if
restricted_auth_permission flag is specified.

Closes: https://github.com/rook/rook/issues/9192
Signed-off-by: parth-gr <paarora@redhat.com>
 2022-01-05 13:51:41 +05:30
subhamkrai c891ddb57d security: add dry run mode for external cluster script 
Adding dry run mode for external cluster script.
This will add cli argument `--dry-run`. By default
`dry-run` option will be `False`
which means it will only print something like below.

```
Execute: 'ceph fs ls'
Execute: 'ceph fsid'
Execute: 'ceph quorum_status'
Execute: 'ceph auth get-or-create client.healthchecker mon allow r, allow command quorum_status,
	allow command version mgr allow command config osd allow rwx pool=default.rgw.meta, allow r pool=
	.rgw.root, allow rw pool=default.rgw.control, allow rx pool=default.rgw.log, allow x
	pool=default.rgw.buckets.index'
Execute: 'ceph mgr services'
Execute: 'ceph auth get-or-create client.csi-rbd-node mon profile rbd osd profile rbd'
Execute: 'ceph auth get-or-create client.csi-rbd-provisioner mon profile rbd mgr allow rw osd
	profile rbd'
Execute: 'ceph status'

```

Signed-off-by: subhamkrai <srai@redhat.com>
 2021-12-16 13:05:39 +05:30
Blaine Gardner 24a77d4fa1 Merge pull request #9296 from degorenko/cephfs-datapools 
file: allow to create CephFS dataPools with predefined names
 2021-12-14 11:04:49 -07:00
Denis Egorenko 3ff681e81d file: allow to create CephFS data pools with predefined names 
Add an ability to create data pools for CephFS with predefined
names.

Related-Issue: rook#9295
Signed-off-by: Denis Egorenko <degorenko@mirantis.com>
 2021-12-14 12:52:19 +04:00
subhamkrai 22865815cf pool: add rbd ec pool support in external cluster 
Adding cli agrument `--rbd-metadata-ec-pool-name` to read
rbd ec pool name to support ec pool in external cluster
and also updating the json blob.

Signed-off-by: subhamkrai <srai@redhat.com>
 2021-12-14 12:13:22 +05:30
Lennart Hagemann 7507790375 security: use correct osd tags for restricted caps 
The create-external-cluster-resources.py with
--create-external-cluster-resources set to true
sets a wrong osd application tag. It should use
the fs name and not the fs pools.

Closes: https://github.com/rook/rook/issues/9227
Signed-off-by: Lennart Hagemann <lennart.hagemann@continum.net>
 2021-12-13 15:03:02 +01:00
Sébastien Han c890710b63 core: change directory layout 
As per discussion, proposing a new layout for the charts/yaml/olm files.

./deploy
├── charts
│   ├── rook-ceph
│   │   └── templates
│   └── rook-ceph-cluster
│       └── templates
├── examples
│   ├── csi
│   │   ├── cephfs
│   │   └── rbd
│   ├── flex
│   ├── monitoring
│   ├── pre-k8s-1.16
└── olm
    └── assemble

Signed-off-by: Sébastien Han <seb@redhat.com>
 2021-11-30 09:12:53 +01:00