Some issues should not be closed by the stale bot, whether because an
issue is taking a long time to design, implement, or if we need an
owner for the issue, but we know we need the feature or fix.
The keepalive label will cause the bot to skip closing stale issues.
This label should be used sparingly
Signed-off-by: Travis Nielsen <tnielsen@redhat.com>
The bot should not close issues that are related to reliability.
Rook's reliability is too critical to allow the bot to close
these issues.
Signed-off-by: Travis Nielsen <tnielsen@redhat.com>
Issues are already being closed if there is no activity for 90 days.
Pull requests have not been closed automatically. This change will cause
pull requests to be closed after six months of inactivity. If there is
no further activity, the PR will be closed after one more month.
Signed-off-by: Travis Nielsen <tnielsen@redhat.com>
This is not a recommended workflow but useful if people click on "Don’t
see your issue here? Open a regular issue."
Signed-off-by: Sébastien Han <seb@redhat.com>
The CI only needs to be run for PRs that have code changes.
PRs that are only documentation, yaml, or other files
that are not built should skip the long and tedious
CI process. This makes the [skip ci] flag more discoverable.
Signed-off-by: travisn <tnielsen@redhat.com>
* when submitting code people must be provide unit tests
* when submitting code for a new functionnality, integration tests must
be added so we can get coverage of that feature in the CI.
Signed-off-by: Sébastien Han <seb@redhat.com>
this commit updates dep to version 0.5, and adds a check during
CI runs that enforces that the vendor dependencies have not changed.
There is a now a makefile target `make vendor.check` that performs
this check. Also removed the requirement that PR run make vendor as
this will be done by CI.
Signed-off-by: Bassam Tabbara <bassam@upbound.io>
We want to have good code documentation in the future, and we would like
to slowly develop better documentation for existing code. As a checklist
item for PRs, add a requirement for godoc-style comments when (1) new
code items are added and (2) when existing items are sufficiently
modified.
Signed-off-by: Blaine Gardner <blaine.gardner@suse.com>
This makes use of GitHub's feature to give a selection on issue creation
this splits the issue types in bug report and feature request.
Signed-off-by: Alexander Trost <galexrt@googlemail.com>
Travis Nielsen
Alan
Sébastien Han
Steven Rathbauer
Alexander Trost
Bassam Tabbara
Blaine Gardner