Commit Graph
7 Commits
Author SHA1 Message Date
Angelos Kolaitis f02be9dd79 external: do not enforce need for monitoring endpoint
Add --skip-monitoring-endpoint to create-external-cluster-resources.py
to allow the script to work with Ceph clusters without an enabled
prometheus module.

Document the new flag in external-cluster.md and add relevant unit tests

Signed-off-by: Angelos Kolaitis <neoaggelos@gmail.com>
(cherry picked from commit 9e4a6ddee5)
2023-04-12 22:09:37 +00:00
Sheetal Pamecha 6825beb1b6 external: use f-strings for formatting
Replace the old formatting method with the f-string
and fix few pylint errors

Signed-off-by: Sheetal Pamecha <spamecha@redhat.com>
(cherry picked from commit (6dbbc9d)
Signed-off-by: Sheetal Pamecha <spamecha@redhat.com>
2023-03-21 10:25:18 +05:30
subhamkrai 00f21c0866 external: format python files using tool black
`black` is python formatter tool which
automatically formats python files without
manual changing. just run `black <python-file>`
and done.

Signed-off-by: subhamkrai <srai@redhat.com>
2022-06-06 20:01:27 +05:30
Sébastien Han 9b6143baa7 Merge pull request #10006 from parth-gr/rgw-external
rgw: validate rgw endpoint ip
2022-05-13 14:28:10 +02:00
parth-gr 624400ff93 rgw: support FQDN for RGW endpoint
Now rgw can be pass by FQDN too,
to avoid problems where it is required
The format should be similar to
Ip(<IP>:<PORT> format), <FQDN>:<PORT> format

Signed-off-by: parth-gr <paarora@redhat.com>
2022-05-12 18:31:35 +05:30
parth-gr 09d52511ad rgw: validate rgw endpoint ip
The ceph-external-cluster-details-exporter.py
generates the json output even with
rgw-endpoint IP from different cluster
Added a check validate_rgw_endpoint which will validate
the above rgw_endpoint Ip by matching the cluster fsid

Signed-off-by: parth-gr <paarora@redhat.com>
2022-05-11 19:52:30 +05:30
subhamkrai 3e6aa9e556 core: split external script unit test and main code in diff file
split the external script main code and unit test in different file.

Closes: https://github.com/rook/rook/issues/9588
Signed-off-by: subhamkrai <srai@redhat.com>
2022-02-24 18:23:21 +05:30