Commit Graph
33 Commits
Author SHA1 Message Date
Mateusz Gozdek 8ba3762fa4 docs: fix bunch of typos
Found by running the following command:

codespell -S .git,*.png,*.jpg -L \
aks,keyserver,atleast,dne,ser,ist,files\',ba,dum,iam,te -f -H

Signed-off-by: Mateusz Gozdek <mgozdekof@gmail.com>
2020-11-06 10:01:04 +01:00
Arun Kumar Mohan 0c9bd0fbae ceph: some minor changes
Some cosmetic changes and an extra negative test

Signed-off-by: Arun Kumar Mohan <amohan@redhat.com>
2020-11-05 15:55:59 +05:30
Sébastien Han 671c5f2f25 ceph: lint exporter script file
Listening to what my linter says...

Signed-off-by: Sébastien Han <seb@redhat.com>
2020-11-04 16:49:28 +01:00
Sébastien Han 1ed307cb09 ceph: fail if mgr prometheus is not default
Currently, Rook does not support a prometheus exporter port different
than 9283 so let's fail and force the user to set it to the default.

Signed-off-by: Sébastien Han <seb@redhat.com>
2020-11-04 10:52:58 +01:00
Arun Kumar Mohan b0b8c8222b ceph: fixed monitoring port issue
Fixed an issue where monitoring port, even when set by user, being
overridden by the default value.

Signed-off-by: Arun Kumar Mohan <amohan@redhat.com>
2020-11-03 08:55:13 +05:30
Arun Kumar Mohan bb753caf52 ceph: need to shift 'DummyRados' class to top
As 'DummyRados' object is being used in other parts of the code, had to
shift this to top.

Signed-off-by: Arun Kumar Mohan <amohan@redhat.com>
2020-11-03 08:55:13 +05:30
Arun Kumar Mohan 72a8a6071b ceph: new tests for monitoring endpoints and upgrade user changes added
Signed-off-by: Arun Kumar Mohan <amohan@redhat.com>
2020-11-03 08:55:13 +05:30
Arun Kumar Mohan 7b8da65c81 ceph: fixed existing test cases
Modified / Fixed all the existing tests according to the latest changes.

Signed-off-by: Arun Kumar Mohan <amohan@redhat.com>
2020-11-03 08:55:13 +05:30
Arun Kumar Mohan c1a4ef6455 ceph: added additional checks on accepting monitoring endpoint
Changes related to Monitoring endpoint
a. for any monitoring endpoint and port (either user given through arguments
or internally found), added code to make sure we convert the endpoint
host_name to a proper IP address.
b. checks added to make sure we have a valid and reachable endpoint

Signed-off-by: Arun Kumar Mohan <amohan@redhat.com>
2020-11-03 08:55:13 +05:30
Arun Kumar Mohan fbb8af12e1 ceph: adding '--upgrade' option to external script
An '--upgrade' option is added to the option list, which upgrades the user
permissions (caps) to match newer version. Will try to detect
'rgw-pool-prefix' or user can provide it through the argument.

Segregated the command line arguments into three groups, common, output and
upgrade

Signed-off-by: Arun Kumar Mohan <amohan@redhat.com>
2020-10-09 18:59:25 +05:30
Arun Kumar Mohan 3de87ccd35 ceph: fix to support TLS enabled rgw-endpoint
Signed-off-by: Arun Kumar Mohan <amohan@redhat.com>
2020-09-11 12:14:56 +05:30
Arun Kumar Mohan a5b4020d80 ceph: making rbd / cephs provisioner and nodes optional
Some more optional items in json output.
RBD Provisioner, CSI CephFS node and provisioner are now optional and
will only be populated if they are available.

Signed-off-by: Arun Kumar Mohan <amohan@redhat.com>
2020-08-17 19:32:26 +05:30
Arun Kumar Mohan 940118af82 ceph: a minor refactoring of external cluster resources script
Signed-off-by: Arun Kumar Mohan <amohan@redhat.com>
2020-08-17 18:57:00 +05:30
Sébastien Han 0c8d20ffb4 ceph: do not validate default.rgw.buckets.index
This pool is not present when this is no bucket yet. So we don't need to
validate its presence.

Signed-off-by: Sébastien Han <seb@redhat.com>
2020-08-11 14:49:18 +02:00
Sébastien Han 5c85640037 ceph: fix lint on python script
Signed-off-by: Sébastien Han <seb@redhat.com>
2020-08-11 14:47:35 +02:00
Umanga Chapagain 83d7cdb85c ceph: configure mgr to enable collection of RBD stats
Signed-off-by: Umanga Chapagain <chapagainumanga@gmail.com>
2020-08-06 12:07:21 +05:30
Anmol Sachan 9dfd684ab5 ceph: added rgw poolPrefix on ceph external script output
RGW poolPrefix is required for the UI and alerting, to provide right information about the respective pool in external mode.

Signed-off-by: Anmol Sachan <anmol13694@gmail.com>
2020-08-05 19:35:33 +05:30
Sébastien Han 00bcaa8328 Merge pull request #5949 from leseb/do-not-validate-pool-if-no-ep
ceph: do not validate rgw pool if no endpoint
2020-08-03 17:09:40 +02:00
Sébastien Han 9ebc006391 ceph: do not validate rgw pool if no endpoint
If no endpoint is specified, we don't need to validate the rgw pools.

Signed-off-by: Sébastien Han <seb@redhat.com>
2020-08-03 15:43:56 +02:00
Arun Kumar Mohan cba605a930 ceph: provide storageclass-es if there are valid parameters
'ceph-rgw' storageclass will be provided only if 'rgw_endpoint' exists
'cephfs' storageclass will be provided only if ceph-fs and/or data-pool
parameters are valid.

Signed-off-by: Arun Kumar Mohan <amohan@redhat.com>
2020-07-31 11:13:36 +05:30
Arun Kumar Mohan 18b32023c5 ceph: allowing ceph filesystem argument to be optional
If we are unable to get or infer a default value for ceph filesystem
script won't be throwing an error.

Signed-off-by: Arun Kumar Mohan <amohan@redhat.com>
2020-07-31 11:13:31 +05:30
Arun Kumar Mohan 59a3be6d75 ceph: make 'rgw_endpoint' check/validation also optional
As 'rgw_endpoint' argument itself is optional, making it's check / validation also optional

Signed-off-by: Arun Kumar Mohan <amohan@redhat.com>
2020-07-27 22:31:31 +05:30
Sébastien Han d5aee01ee3 Merge pull request #5901 from leseb/validate-prefix-rgw-pool
ceph: validate pools with prefix
2020-07-27 17:19:45 +02:00
Sébastien Han b35c065db5 ceph: validate pools with prefix
Now the rgw pool with a given prefix will also be checked by the script.

Signed-off-by: Sébastien Han <seb@redhat.com>
2020-07-27 14:55:08 +02:00
Sébastien Han faad0a45ac ceph: make rgw option on external script
Some clusters do not have rgws deployed so let's make it optional.

Signed-off-by: Sébastien Han <seb@redhat.com>
2020-07-27 10:06:31 +02:00
Sébastien Han 34ccb84aa3 ceph: add external prometheus endpoint
We can now connect an external prometheus exporter to Rook to collect
metrics and generate alerts from Prometheus.
Just enable this in the CephCluster CR:

```
spec:
  external:
    enable: true
   monitoring:
    enabled: true
    rulesNamespace: rook-ceph
    externalMgrEndpoints:
    - ip: 192.168.39.182
```

Closes: https://github.com/rook/rook/issues/5516
Signed-off-by: Sébastien Han <seb@redhat.com>
2020-07-17 11:29:48 +02:00
Travis Nielsen e74c7eaef8 ceph: refactor context and clusterInfo passed to the ceph commands
To provide more context for executing commands in a ceph cluster,
the full clusterInfo is now passed to the ceph execution commands.
All information about the cluster will now be available throughout
all the areas of the operator. The namespace, ceph credentials,
mon endpoints, and other info is a core part of that cluster info.

Arguments passed through the controllers are also simplified for
mons, mgr, osds, and other daemons where the parameters had
become too complex.

Signed-off-by: Travis Nielsen <tnielsen@redhat.com>
2020-07-16 15:54:54 -06:00
Sébastien Han 83e1ff102d ceph: add http dial to verify external endpoint
If there is a typo in the rgw endpoint, then the user will be notified
that the gateway is not accessible or does not return the 200 HTTP code.

Signed-off-by: Sébastien Han <seb@redhat.com>
2020-07-15 22:15:42 +02:00
Sébastien Han e4eaa91ede ceph: add rgw endpoint healthcheck
We have introduced a new goroutine to check the state of the rgw
endpoint. It will run every minute and perform operations on a bucket.
The success or failure will be reported as part of the status field of
the CephObjectStore CR.

A good status will look like:

status:
  endpointStatus:
    lastChanged: "2020-06-25T13:47:45Z"
    lastChecked: "2020-06-25T13:48:46Z"
  phase: Connected

A failed status:

status:
  endpointStatus:
    details: |-
      error creating bucket "rook-ceph-internal-s3-bucket-checker": RequestError: send request failed
      caused by: Put http://rook-ceph-rgw-my-store.rook-ceph:8080/rook-ceph-internal-s3-bucket-checker: dial tcp 10.108.189.148:8080: connect: connection refused
    health: ERROR

This check works for both converged and external modes. Note that the
CephObjectStore CRD has a new field called "externalRgwEndpoints" which
allows you to define a list of IP addresses pointing to rgws.

Closes: https://github.com/rook/rook/issues/5692
Signed-off-by: Sébastien Han <seb@redhat.com>
2020-07-02 16:34:10 +02:00
Sébastien Han 82877f0c02 ceph: fix script IP parsing
The script wasn't allowing IPs like 192.168.0.2, 0 has part of the
subnet is valid.

Signed-off-by: Sébastien Han <seb@redhat.com>
2020-06-16 16:04:45 +02:00
Arun Kumar Mohan 2f195bbdfa Ceph: Added the missing double quotes in JSON output
Without the double quotes, operator is unable to parse the json output from the script

Signed-off-by: Arun Kumar Mohan <arun.iiird@gmail.com>
2020-05-29 02:01:55 +05:30
Sébastien Han 362086d16c script: add 2 new SC
* Clarify the helper for the run-as-user argument
* Add 2 new storage class and put the data so we stick with the same
pattern as the Secret and ConfigMap

Signed-off-by: Sébastien Han <seb@redhat.com>
2020-05-13 16:27:33 +02:00
Arun Kumar Mohan 23d2191147 ceph: Python script to generate needed external cluster resources in JSON format
This script will generate JSON format of all the needed resources.
Script can also generate the output in Shell script format.

Signed-off-by: Arun Kumar Mohan <arun.iiird@gmail.com>
2020-05-11 20:39:10 +05:30