Commit Graph
386 Commits
Author SHA1 Message Date
travisn 754f073aa5 monitoring: service monitor should not use mgr_role label
The service monitor selectors need to match the mgr service labels.
Since the mgr service labels don't use the mgr_role (only the mgr
service selectors use the mgr_role), the mgr_role should be removed
from the service monitor.

Signed-off-by: travisn <tnielsen@redhat.com>
2023-05-22 14:20:19 -06:00
parth-gr ec2681f82b external: fix rgw check if no multisite flag is passed
if there is no multisite config pass, it will still checks for
the zones and zones group and not able to query anything

Signed-off-by: parth-gr <paarora@redhat.com>
2023-05-16 20:10:29 +05:30
Travis Nielsen 27504b0a25 Merge pull request #12190 from parth-gr/doc-update-rulenamespace
docs: update ruleNamesapce to rulesNamespaceOverride
2023-05-11 11:02:22 -06:00
parth-gr 060bd00281 docs: update ruleNamesapce to rulesNamespaceOverride
there were some places where rulenamesapce was present updated to rulesNamespaceOverride

Closes: rook#12163
Signed-off-by: parth-gr <paarora@redhat.com>
2023-05-11 17:26:04 +05:30
travisn 92a0ab37e3 monitoring: configurable option to disable prometheus metrics
The prometheus mgr module and ceph exporter can now be optionally
disabled by the monitoring.metricsDisabled setting in the
CephCluster CR. These will not be disabled by default, rather
than the mgr module being disabled by default from v1.11.4.

Signed-off-by: travisn <tnielsen@redhat.com>
2023-05-05 16:04:51 -06:00
parth-grandSergio Pérez Fernández c50c308abe external: fix rgw multisite config check
the check validate_rgw_multisite was always checking for realm
updated it to check the specific config

fixed validate_rgw_endpoint pool validation

added missing realm zonegroup and zone while interacting with user resources

Co-authored-by: Sergio Pérez Fernández <sergioperez794@gmail.com>
Signed-off-by: parth-gr <paarora@redhat.com>
2023-05-05 00:56:18 +05:30
Blaine Gardner 6500c11d57 nfs: pare down config file volume sources
Pare down the available volume sources for NFS config files so that the
CRD isn't unnecessarily huge. This allows us to recommend
`kubectl apply` again in the upgrade doc.

Size of the NFS CRD is reduced by approximately 60%.

Signed-off-by: Blaine Gardner <blaine.gardner@redhat.com>
2023-05-02 11:34:24 -06:00
subhamkrai ad068d966a core: update k8s module to lastet version
updating k8s dependencies like clien-go and
others to v0.26.4

Signed-off-by: subhamkrai <srai@redhat.com>
2023-05-02 22:06:21 +05:30
Travis Nielsen 46e6b7366a Merge pull request #12132 from parth-gr/dotpool-update
external: check for pool and cluster name is provided
2023-04-25 08:02:14 -06:00
parth-gr e02942ab77 external: check for pool and cluster name is provided
While adding the support for dot and special rbd pools
the check for pool and cluster name check was removed,
Adding it back as it is needed
https://github.com/rook/rook/pull/12056

Signed-off-by: parth-gr <paarora@redhat.com>
2023-04-25 18:48:27 +05:30
travisn db04b127b0 core: remove obsolete journal size config value
The journal size was only applicable to the filestore OSD
format which has not been supported by rook since v1.2.
Remove the remaining obsolete setting from the examples and
code.

Signed-off-by: travisn <tnielsen@redhat.com>
2023-04-24 15:54:53 -06:00
Travis Nielsen eaf3e3662d Merge pull request #12037 from parth-gr/external-multisite-zone
external: add support for multisite in external cluster script
2023-04-13 07:55:44 -06:00
Travis Nielsen 6103cb93dd Merge pull request #12061 from neoaggelos/feat/external
external: do not enforce need for monitoring endpoint
2023-04-12 16:08:54 -06:00
Angelos Kolaitis 9e4a6ddee5 external: do not enforce need for monitoring endpoint
Add --skip-monitoring-endpoint to create-external-cluster-resources.py
to allow the script to work with Ceph clusters without an enabled
prometheus module.

Document the new flag in external-cluster.md and add relevant unit tests

Signed-off-by: Angelos Kolaitis <neoaggelos@gmail.com>
2023-04-12 21:04:48 +03:00
Travis Nielsen 9e55bbcc7c Merge pull request #12056 from parth-gr/external-restricted-dotpool
external: add alias rbd pool name to support . pools name
2023-04-12 09:42:52 -06:00
parth-gr 6c3dabcf5f external: add alias rbd pool name to support . pools name
if restricted permission was on the . was appended to k8s secret and
failed to create the secret so added a alias name is user wan't to suuport
pool with . in name

Signed-off-by: parth-gr <paarora@redhat.com>
2023-04-12 19:26:20 +05:30
travisn 609ac91cb1 core: update default image to ceph v17.2.6
With the release of ceph v17.2.6, the examples and the base
image for the operator are updated to pick up the latest
and greatest.

Signed-off-by: travisn <tnielsen@redhat.com>
2023-04-11 14:07:11 -06:00
sp98 aefe0054c4 core: add clusterID to MCS spec
ClusterID uniquely identifies a cluster. It is used as a prefix to
nslookup exported services.
For example: <clusterid>.<svc>.<ns>.svc.clusterset.local

Signed-off-by: sp98 <sapillai@redhat.com>
2023-04-11 15:17:21 +05:30
parth-gr b60da0b8c1 external: add support for multisite in external cluster
Add support for realm, zone and zonegroup

Signed-off-by: parth-gr <paarora@redhat.com>
2023-04-10 20:03:16 +05:30
Mathieu Parent 1578d55b4d helm: drop snapshot.storage.k8s.io/v1beta1
v1 exists since k8s v1.20

Signed-off-by: Mathieu Parent <mathieu.parent@insee.fr>
2023-04-08 21:18:35 +02:00
Travis Nielsen 36138fcebe Merge pull request #12028 from parth-gr/external-enforce
external: do not enforce rbd, cephfs and rgw flags for the external cluster
2023-04-06 08:52:44 -06:00
parth-gr 626d1c44ff external: name correction of validate_rgw_metadata_ec_pool_name function
The function is used for rbd so it should be name to validate_rbd_metadata_ec_pool_name

Signed-off-by: parth-gr <paarora@redhat.com>
2023-04-05 20:54:13 +05:30
parth-gr e734911532 external: do not enforce rbd, cephfs and rgw flags for the external cluster
there might be a user who only wants to use rbd, so don't enforce them
to to create all the pools and pass the flags

Closes: https://github.com/rook/rook/issues/11846
Signed-off-by: parth-gr <paarora@redhat.com>
2023-04-05 17:21:04 +05:30
travisn 558732d0ae ci: canary test should enable the prometheus module
The canary test is waiting for the prometheus module,
which is now disabled by default. For the canary test,
we need to enable the prometheus module for the external
cluster test.

Signed-off-by: travisn <tnielsen@redhat.com>
2023-04-03 15:32:11 -06:00
Travis Nielsen 12badbe4c3 Merge pull request #11947 from parth-gr/external-seprate-rgw
external: make rgw call separate from cephfs and rbd
2023-03-31 09:35:26 -06:00
xiaobaowen e7254c2a1b mgr: disable the prometheus module by crds
Signed-off-by: xiaobaowen <xiaobaowen@deeproute.ai>
2023-03-31 20:49:22 +08:00
parth-gr e44df84687 external: make rgw call separate from cephfs and rbd
if the rge endint is not reachable don't block the creation
of rbd and cephfs sc, just print the error instead of raising exception

Signed-off-by: parth-gr <paarora@redhat.com>
2023-03-30 19:54:33 +05:30
Travis Nielsen 4a23260955 Merge pull request #11845 from rkachach/fix_issue_11844
mgr: use mgr_role dynamic label to tag the active ceph manager
2023-03-28 13:08:18 -06:00
Redouane Kachach f00bd790a8 mgr: using dynamic mgr_role label to implement mgr HA
Closes: https://github.com/rook/rook/issues/11844

Signed-off-by: Redouane Kachach <rkachach@redhat.com>
2023-03-27 18:38:55 +02:00
Travis Nielsen 4811bb1b22 Merge pull request #11899 from Madhu-1/fix-11805
csi: make AttachRequired as configurable
2023-03-22 07:59:39 -06:00
Madhu Rajanna 4c710de791 csi: make AttachRequired as configurable
adding a option to make AttachRequired field
as configurable and added a comment to explain
the consequences of changing the default value

resolves: #11805

Signed-off-by: Madhu Rajanna <madhupr007@gmail.com>
2023-03-22 12:55:32 +01:00
Madhu Rajanna 4bdab21db0 nfs: add csi-attacher to NFS provisioner
Add attacher sidecar to NFS provisioner pod
to avoid mounting RWO volumes on two nodes

details: https://github.com/rook/rook/issues/10692

Signed-off-by: Madhu Rajanna <madhupr007@gmail.com>
2023-03-22 12:55:32 +01:00
travisn cd94ed7ddc core: set key rotation default in code instead of crds
The defaults in CRDs cause an update and trigger a new
reconcile if the value is not set. For the key rotation
setting, the default was only being updated when the kms
feature was enabled. This update was causing the reconcile
to fail in the kms tests. With the default now in code,
the default can remain empty and no cr update will trigger
a new reconcile unexpectedly.

Signed-off-by: travisn <tnielsen@redhat.com>
2023-03-21 11:03:56 -06:00
Travis Nielsen 5832d56476 Merge pull request #11885 from Sheetalpamecha/issue_11769
external: use f-strings for formatting
2023-03-17 09:10:38 -06:00
Travis Nielsen e3fa098c1d Merge pull request #11908 from thenamehasbeentake/enableRGWDashboard_by_custom
rgw: enableRGWDashboard can be configured by custom
2023-03-17 08:18:52 -06:00
Sheetal Pamecha 6dbbc9d71c external: use f-strings for formatting
Replace the old formatting method with the f-string
and fix few pylint errors

Signed-off-by: Sheetal Pamecha <spamecha@redhat.com>
2023-03-17 11:20:26 +05:30
Matt 8bdabf85a8 external: pool and metadata ec pools were reversed in scripts
Pool and Metadata Pool Appear to be reversed.

dataPool needs to contain the EC Data pool
pool needs to contain the Metadata Pool
Closes: https://github.com/rook/rook/issues/11918

Signed-off-by: Matt P <dragon@fbdragon.co.uk>
2023-03-16 22:33:23 +00:00
root 253d4123f6 rgw: allow the rgw dashboard to be disabled
The rgw dashboard can be disabled by the setting in the
CephObjectStore `gateway.dashboardEnabled` if set to false.

Signed-off-by: xiaobaowen <xiaobaowen@deeproute.ai>
2023-03-16 22:58:32 +08:00
Blaine Gardner ef4c4f909a Merge pull request #11777 from taxilian/feature/nfs-hostnetwork
nfs: network mode can be set separately for cephcluster and nfs
2023-03-13 12:14:08 -06:00
Vincent Kling bd857cc5c5 manifest: add missing quote
Signed-off-by: Vincent Kling <v.kling@vinniict.nl>
2023-03-11 11:44:58 +01:00
xiaobaowen df95c1add0 core: add fsid to the additionalPrinterColumns on cephcluster custom resource
Signed-off-by: xiaobaowen <xiaobaowen@deeproute.ai>
2023-03-09 21:47:22 +08:00
Travis Nielsen cb4133e7a5 Merge pull request #11814 from travisn/deviceclass-doc
docs: Clarify device class use on all pools
2023-03-08 12:19:46 -07:00
Rakshith R 340dbe05b4 docs: add documentation for encryption key rotation
Signed-off-by: Rakshith R <rar@redhat.com>
2023-03-08 12:07:26 +05:30
Rakshith R f39a32fcdb osd: add capability to reconcile key rotation cron jobs
This commits adds code to reconcile key rotation cron jobs.

Signed-off-by: Rakshith R <rar@redhat.com>
2023-03-08 12:07:26 +05:30
Rakshith R 71e011f731 osd: add rotate-key functionality to rook's key-management cmd
This commit adds functionality to be able to rotate
key encryption key of encrypted PVC backed OSDs.
Necessary changes such as adding update functionality
to kms and rbac changes are made as well.

Signed-off-by: Rakshith R <rar@redhat.com>
2023-03-08 12:07:26 +05:30
Rakshith R 46dd2eb5ff core: add KeyRotationSpec to cephcluster CR
This commit adds KeyRotationSpec to cephcluster CR
to support encryption key rotation feature.
If enabled Rook will create a cronjob for each
encrypted PVC based OSD with given schedule set
to rotate their respective key encryption key.

Signed-off-by: Rakshith R <rar@redhat.com>
2023-03-08 12:07:26 +05:30
travisn 38981f2649 docs: clarify device class use on all pools
If the device class property is specified on any pool,
it must be specified on all pools so the pg autoscaler
will remain healthy.

Signed-off-by: travisn <tnielsen@redhat.com>
2023-03-07 16:04:24 -07:00
Redouane Kachach 456a0c328c Revert "mgr: remove mgr sidecar"
This reverts commit ff75ec96b7.

Signed-off-by: Redouane Kachach <rkachach@redhat.com>
2023-03-07 13:12:50 +01:00
travisn fd25eeecf1 monitoring: remove alerts that don't apply to rook
When the alerts were updated from the ceph repo, the cephadm
alerts were removed, now we also remove two other alerts that
don't apply to rook clusters. The pool growth warning alert
and prometheus job missing alerts need to be removed
as also seen in https://github.com/rook/rook/pull/10109.

Signed-off-by: travisn <tnielsen@redhat.com>
2023-03-06 14:46:33 -07:00
Travis Nielsen cbd91f7e13 Merge pull request #11804 from gauravsitlani/whitespace-fix
manifest: fix whitespace issues
2023-03-03 10:44:32 -07:00