feedc0de/my-rook-config
1
0
Fork 0
forked from rook/rook
Code Pull Requests Activity
11,997 Commits 38 Branches 289 Tags
4eed2a644f9bf2eaffceff85a68fbe86471c2b77
Commit Graph
3 Commits
Author SHA1 Message Date
travisn 6f8e42422d core: fix golang linter issues with variables in loops 
Loop variables cannot be reliably uses since they will
change with each iteration. Update these loop variable
uses to be safe by indexing the slice rather than
using the loop variable directly.

Also suppress the linter issues for passwords used
in tests.

Signed-off-by: travisn <tnielsen@redhat.com>
 2023-12-05 14:14:58 -07:00
Divyansh Kamboj 9008409f87 core: add context parameter to functions 
This commit adds context parameter to various functions, and remove the
usage of context.TODO.

Closes: https://github.com/rook/rook/issues/8701
Signed-off-by: Divyansh Kamboj <dkamboj@redhat.com>
 2022-03-22 08:19:07 +05:30
Yuval Lifshitz f2b065a3ae rgw: refactor bucket notification code 
this should make sure code reuse between the OBC label controller and
the CephBucketNotification controller.
done as part of the cleanup work from:
https://github.com/rook/rook/pull/8426

this also include adding unit tests for:
- topic controller
- notification controller
- obc label controller

Signed-off-by: Yuval Lifshitz <ylifshit@redhat.com>
 2021-12-07 18:24:46 +02:00