Commit Graph
163 Commits
Author SHA1 Message Date
Madhu Rajanna 02b9f199d7 csi: add volumeattachment list rbac
rbd nodeplugin need volumeattachment RBAC
to remount the volume incase of the nbd driver
is used to mount the volume.
Signed-off-by: Madhu Rajanna <madhupr007@gmail.com>
2022-05-31 15:09:34 +05:30
parth-gr cbda9f2f7d csi: update cephfs osd caps
Currently cephfs caps are data=filesystemname,
which only have write access, but not the read access
changing it to *=filesystemname so we can read data also

Signed-off-by: parth-gr <paarora@redhat.com>
2022-05-25 18:56:54 +05:30
Travis Nielsen 1fe71fc76f Merge pull request #10271 from humblec/rbac-cleanup-2
Adjust PV object RBAC  for CSI PODs
2022-05-17 07:26:00 -06:00
Travis Nielsen 362e3a6578 Merge pull request #10247 from Madhu-1/remove-cephfs-node-rbac
csi: Remove extra cephfs node rbac
2022-05-16 08:40:16 -06:00
Humble Chirammal 34e88776e7 csi: remove unwanted verbs for pv object
pv object patch verb is enough for the csi sidecar to function.

Signed-off-by: Humble Chirammal <hchiramm@redhat.com>
2022-05-16 14:35:34 +05:30
Humble Chirammal 0812d08a75 csi: remove watch verb from csi-snapshottter sidecar RBAC
The `watch` verb is not required for the csi-snapshotter sidecar
to function, removing it from the deployment

Signed-off-by: Humble Chirammal <hchiramm@redhat.com>
2022-05-16 13:21:42 +05:30
Madhu Rajanna e4133857e9 csi: remove extra cephfs RBAC
Remove unwanted cephfs clusterRole
RBAC.

Signed-off-by: Madhu Rajanna <madhupr007@gmail.com>
2022-05-16 10:52:21 +05:30
Sébastien Han 9b6143baa7 Merge pull request #10006 from parth-gr/rgw-external
rgw: validate rgw endpoint ip
2022-05-13 14:28:10 +02:00
Travis Nielsen 5e0d896a69 Merge pull request #10232 from parth-gr/external-fqdn
rgw: support FQDN for RGW endpoint
2022-05-12 11:52:24 -06:00
Travis Nielsen 9b5191b3db Merge pull request #10242 from ttyS0/master
docs: update tolerations name from controlplane to control-plane
2022-05-12 10:30:55 -06:00
Sean Johnson 30667157ab docs: update tolerations name from controlplane to control-plane
Signed-off-by: ttyS0 <sean@skj.dev>
2022-05-12 10:04:55 -05:00
parth-gr 624400ff93 rgw: support FQDN for RGW endpoint
Now rgw can be pass by FQDN too,
to avoid problems where it is required
The format should be similar to
Ip(<IP>:<PORT> format), <FQDN>:<PORT> format

Signed-off-by: parth-gr <paarora@redhat.com>
2022-05-12 18:31:35 +05:30
Travis Nielsen bb5812316d Merge pull request #10244 from y1r/add-psp
build: add psp for missing roles
2022-05-11 11:55:45 -06:00
parth-gr b97bc74f45 csi: update the upgrade flag description
Currently it was mention we are updating the csi-user
But more precisely we go and update the keyrings
which auto update users so replacing it

Signed-off-by: parth-gr <paarora@redhat.com>
2022-05-11 19:52:38 +05:30
parth-gr cf29043f4d rgw: donot validate prefix rgw pools when prefix is default
Signed-off-by: parth-gr <paarora@redhat.com>
2022-05-11 19:52:38 +05:30
parth-gr 09d52511ad rgw: validate rgw endpoint ip
The ceph-external-cluster-details-exporter.py
generates the json output even with
rgw-endpoint IP from different cluster
Added a check validate_rgw_endpoint which will validate
the above rgw_endpoint Ip by matching the cluster fsid

Signed-off-by: parth-gr <paarora@redhat.com>
2022-05-11 19:52:30 +05:30
Yuichiro Ueno 1ccc185a79 build: add psp for missing roles
This commit adds psp RoleBindings to rook-ceph-rgw role and
rook-ceph-purge-osd role. Without this commit, I cannot perform
rook-ceph-purge-osd job on PSP-enabled cluster.

Signed-off-by: Yuichiro Ueno <ueno@preferred.jp>
2022-05-11 13:50:37 +09:00
Madhu Rajanna 19f77c6174 csi: remove unwanted RBAC of csi driver
Removed unwanted RBAC from the
previous versions of driver.

Signed-off-by: Madhu Rajanna <madhupr007@gmail.com>
2022-05-11 10:16:37 +05:30
Travis Nielsen 60b72b6d48 operator: increase memory limit of operator
The operator is very bursty and when starting up may need more memory
to reconcile all the CRs initially before it calms down.
The default of 256Mi was not sufficient for many clusters, so now
we bump up the limit to 512Mi.

This is a follow-up from the same change to the helm chart in
https://github.com/rook/rook/pull/10195.

Signed-off-by: Travis Nielsen <tnielsen@redhat.com>
2022-05-03 07:54:53 -06:00
Rakshith R d0b67af23b build: fix csi nfs rbac csv generation
Added hack in generate-rook-csv for proper
generation of csi nfs rbac in csv.
Added placeholder clusterrole and binding for
nfs nodeplugin sa, since operator-sdk
does not include sa without rules.

Signed-off-by: Rakshith R <rar@redhat.com>
2022-04-28 19:42:24 +05:30
Travis Nielsen 318205026d Merge pull request #10139 from travisn/optional-realm
core: RGW realm pull spec is optional
2022-04-25 07:49:43 -06:00
Sébastien Han 1093b0a166 csi: update cephcsi to v3.6.1 release
A new Ceph-CSI release is out so let's use it.

Signed-off-by: Sébastien Han <seb@redhat.com>
2022-04-25 10:26:10 +02:00
Travis Nielsen 1dd343ed7e build: add a placeholder rule to rgw rbac
With https://github.com/rook/rook/pull/10108 a placeholder role
and role binding were added for the rgw service account so
the csv generation would generate the service account. That
workaround also requires a rule to be added to the role or else
the generation is invalid. Now a rule is added to avoid that
issue. In the future we need to remove this role and binding
when the operator sdk is updated as explained in
https://github.com/rook/rook/issues/10141

Signed-off-by: Travis Nielsen <tnielsen@redhat.com>
2022-04-22 10:38:58 -06:00
Travis Nielsen 7f709776b5 core: rgw realm pull spec is optional
The endpoint on the rgw realm pull spec is causing a failure
if not specified even when it is not expected to be
required. Now the endpoint has the json property to be
ommitted if not specified.

Signed-off-by: Travis Nielsen <tnielsen@redhat.com>
2022-04-22 08:08:12 -06:00
Travis Nielsen 622f3c09b8 Merge pull request #10023 from subhamkrai/update-cntrl-runtime
core: update controller-runtime version to v0.11.2
2022-04-20 11:52:46 -06:00
Travis Nielsen d3c036c90c Merge pull request #10108 from travisn/rgw-serviceaccount-csv
build: Add a placeholder rgw role for csv generation
2022-04-20 11:51:30 -06:00
subhamkrai 13cc698566 core: update controller-runtime version to v0.11.2
update controller-runtime version to v0.11.2

Signed-off-by: subhamkrai <srai@redhat.com>
2022-04-20 22:30:16 +05:30
Travis Nielsen 09c7b305c7 Merge pull request #10059 from Madhu-1/update-nfs-image-reg
csi: use k8s.gcr.io for csi nfsplugin image
2022-04-20 08:01:47 -06:00
Travis Nielsen e1550e7551 build: add a placeholder rgw role for csv generation
The csv will not properly include the rook-ceph-rgw service
account unless there is a role and binding that references
the service account. No roles are needed yet for the rgw
daemon, so this will add a placeholder only for the purposes
of csv generation.

Signed-off-by: Travis Nielsen <tnielsen@redhat.com>
2022-04-20 07:53:17 -06:00
Travis Nielsen d172030238 Merge pull request #10096 from travisn/default-prio-class
core: Examples set default priority class names
2022-04-20 07:39:08 -06:00
Travis Nielsen fb86955f01 core: examples set default priority class names
By default, we should set the priority class to one of the built-in
priority class names to ensure that pods critical to the storage
will be able to remain running when resources are low. Otherwise,
critical rook pods could be evicted and affect many other pods
that rely on the storage to continue functioning. The options have
been available in the CRs, but until now we have just not set the
defaults in the examples. Critical rook components are now set to
the priority class system-node-critical if they are generally pinned
to a node, and system-cluster-critical if they are critical to the storage.
Some pods such as the operator and crash collector do not have a
default priority class set in the examples since they don't affect
the data path.

Signed-off-by: Travis Nielsen <tnielsen@redhat.com>
2022-04-19 16:09:34 -06:00
Travis Nielsen 0a25af78dc monitoring: remove cephadm specific alerts
The ceph adm alerts were included in the latest prometheus
rules. With rook these alerts will never be triggered, so
we remove them.

Signed-off-by: Travis Nielsen <tnielsen@redhat.com>
2022-04-19 16:03:54 -06:00
Travis Nielsen e45781d0d3 monitoring: disable new alerts that are not applicable to rook
The new alerts picked up for Rook v1.9 directly from the ceph repo
were not all rook-compliant. The alert for the prometheus job not
running is not needed since Rook and K8s go to great lengths to
keep the mgr pod running already.

The alert for the cluster filling up soon is also disabled
until we find how to get the formula working in rook clusters.

Signed-off-by: Travis Nielsen <tnielsen@redhat.com>
2022-04-19 14:57:05 -06:00
Travis Nielsen 299d6cf4eb Merge pull request #10089 from yuvalman/resources-fix
helm: fix missing default resources in rook components
2022-04-19 10:34:36 -06:00
Yuval Manor 5f01456dae helm: fix missing default resources in rook components
1. Add csi-snapshotter resources for csiCephFSProvisioner
2. Add csi-omap-generator resources for csiRBDProvisioner (only is omap generator is enabled)

Closes: https://github.com/rook/rook/issues/10083
Signed-off-by: Yuval Manor <yuvalman958@gmail.com>
2022-04-19 18:37:25 +03:00
Travis Nielsen 6cd1de4776 Merge pull request #9940 from Rakshith-R/csi/add-kms-support
csi: add CSI encryption support
2022-04-19 09:26:52 -06:00
Travis Nielsen 4d23911fd9 Merge pull request #10074 from Madhu-1/make-rpc-timeout-configurable
csi: make GRPC timeout configurable
2022-04-19 07:54:50 -06:00
Blaine Gardner 398d1b046a Merge pull request #10076 from BlaineEXE/nfs-add-missed-scc
docs: fix nfs permission on openshift example
2022-04-14 08:43:29 -06:00
Blaine Gardner 1311bf870a docs: fix nfs permission on openshift example
Fix a small permission (RBAC) issue with the operator-on-openshift.yaml
example's SecurityContextConstraint. A ServiceAccount reference for the
Ceph CSI NFS provisioner was missing.

Signed-off-by: Blaine Gardner <blaine.gardner@redhat.com>
2022-04-14 08:32:09 -06:00
Madhu Rajanna 54de442e22 csi: make GRPC timeout configurable
setting the GRPC timeout configurable helps
in some cases where ceph cluster takes more time
to respond.

Signed-off-by: Madhu Rajanna <madhupr007@gmail.com>
2022-04-14 18:15:00 +05:30
Blaine Gardner a950feb01e docs: update NFS docs including latest CSI work
Update the NFS docs with the latest available info for Ceph Quincy
including the CSI provisioner driver.

Signed-off-by: Blaine Gardner <blaine.gardner@redhat.com>
2022-04-13 15:02:16 -06:00
Travis Nielsen 221fc5d81b Merge pull request #10046 from Madhu-1/webhook-rados
ceph: add webhooks to reject update on subvolume group and radosnamespace
2022-04-13 11:06:20 -06:00
Rakshith R 2e18d5bbaa csi: add CSI encryption support
Ceph-CSI supports LUKS encryption for RBD volumes.
This commit adds support for the same by adding capability
of mounting required `rook-ceph-csi-kms-config` configmap
into csi-rbdplugin-provisioner and nodeplugin pods.
Required documentations, helm charts and examples yamls
are also updated.

Resolved: #7032

Signed-off-by: Rakshith R <rar@redhat.com>
2022-04-13 19:52:51 +05:30
Madhu Rajanna 52c8211e43 csi: use k8s.gcr.io for csi nfsplugin image
use k8s.gcr.io like other kubernetes sidecar
image to pull the nfsplugin image.

Signed-off-by: Madhu Rajanna <madhupr007@gmail.com>
2022-04-13 11:54:35 +05:30
Madhu Rajanna 024c034a95 core: add code to update the webhook configurations
As we are adding new webhook configuration we
need to update the webhooks validations.

Signed-off-by: Madhu Rajanna <madhupr007@gmail.com>
2022-04-13 10:38:38 +05:30
Blaine Gardner bca2f128ab build: generate a separate NFS CSI RBAC manifest
Because the NFS CSI driver is optional and rarely deployed, make RBAC
for this driver an optional example that is generated by the helm chart.

Signed-off-by: Blaine Gardner <blaine.gardner@redhat.com>
2022-04-12 16:57:11 -06:00
Blaine Gardner 254a7adb4c nfs: create config pool by default
Create the ".nfs" config pool by default so that users aren't required
to create it via CephBlockPool.

Signed-off-by: Blaine Gardner <blaine.gardner@redhat.com>
2022-04-12 12:05:43 -06:00
Blaine Gardner 0d2e43bd77 Merge pull request #9927 from Rakshith-R/csi/add-nfs-nodeplugin
csi: add nfs nodeplugin & provisioner
2022-04-12 11:37:55 -06:00
Travis Nielsen 38dc2fae2d Merge pull request #10003 from rexagod/9711
core: support arbitrary node affinity inputs
2022-04-12 10:31:58 -06:00
Pranshu Srivastava 6e49a090a3 core: support arbitrary node affinity inputs
Adds support for valid arbitrary NodeAffinity JSON input by the user while
maintaining backward compatibility with the older parsing code.

Signed-off-by: Pranshu Srivastava <rexagod@gmail.com>
2022-04-12 21:11:01 +05:30