Commit Graph
680 Commits
Author SHA1 Message Date
Travis Nielsen 29b7bd9715 Merge pull request #13718 from subhamkrai/remove-namespace-from-networkFence
core: Delete networkFence CRs during cluster removal
2024-02-13 14:54:36 -07:00
subhamkrai 5bff860380 core: remove namespace/ownerRef from networkFence
since networkFence is a cluster-based resource so that we don't need
the namespace and ownerReferences as it cause garbage-collector errors.
Also, now we create the networkFence with clusteUID label so when doing
cleanup we match the cephCluster uid and networkFence label clusterUID.

Signed-off-by: subhamkrai <srai@redhat.com>
2024-02-13 21:47:04 +05:30
Michael Adam 25aa15e6c1 network: disallow legacy hostNetwork together with non-default provider
Fixes: #13692

Since the introduction of the "host" network provider, the  legacy
"hostNetwork" setting is intended to be used only in combination with
the default network provider (""), but the code did not enforce this.

This change adds the required validation checks to throw errors
in invalid constellations.

These checks are added both in the operator's input  validation code
and as kubernetes x-validation admission policies in the Cepcluster CRD.

Signed-off-by: Michael Adam <obnox@samba.org>
2024-02-12 22:22:48 +01:00
subham rai a2ba8da0b3 Merge pull request #12973 from raghavendra-talur/rtalur-support-context
import-external-cluster.sh: allow specifying the kubernetes context
2024-02-12 22:28:49 +05:30
Travis Nielsen 5ce7fd97bd Merge pull request #13736 from Madhu-1/csi-3.10.2
csi: update cephcsi image to 3.10.2
2024-02-09 11:20:10 -07:00
Travis Nielsen 142ac703d7 Merge pull request #13665 from iPraveenParihar/remove/CSI_ENABLE_READ_AFFINITY
csi: remove CSI_ENABLE_READ_AFFINITY
2024-02-09 07:46:27 -07:00
Madhu Rajanna c22597a32c csi: update cephcsi image to 3.10.2
Updating the cephcsi image to 3.10.2
which is the latest released one.

Signed-off-by: Madhu Rajanna <madhupr007@gmail.com>
2024-02-09 08:21:05 +01:00
travisn 27265ff279 helm: remove cpu limits from all pods
When CPU requests and limits are assigned to a pod,
the pod will be guaranteed the requests, up to the limits.
Even if there are spare CPU cycles, the pod cannot use
them. Thus, pods can be unnecessarily denied compute
when they need to burst if the limits are set.

Therefore, it is not recommended to set CPU limits
since the CPU requests are already guaranteeing that
no pod will be starved at least for its requests.

Signed-off-by: travisn <tnielsen@redhat.com>
2024-02-07 17:36:59 -07:00
Travis Nielsen 2d745280b0 Merge pull request #13405 from Javlopez/feature/Allow-defining-multiple-cephECStorageClass
helm: allow defining multiple cephEcStorageClass
2024-02-07 13:34:56 -07:00
Raghavendra Talur cb702d3d52 external: allow specifying the kubernetes context
If the import script is run on a system that has many kubernetes configs
in the kubeconfig file, it is useful to be able to specify the context
to use.

Signed-off-by: Raghavendra Talur <raghavendra.talur@gmail.com>
2024-02-06 12:52:02 -05:00
Praveen M d28febaa61 csi: remove CSI_ENABLE_READ_AFFINITY
This commit removes the `CSI_ENABLE_READ_AFFINITY` since
it is no longer utilized after addition of the read affinity
option per cluster via CSIDriverSpec.

Signed-off-by: Praveen M <m.praveen@ibm.com>
2024-02-06 20:21:57 +05:30
Blaine Gardner 60cc943197 Merge pull request #13610 from rkachach/fix_issue_pvc_minikube_test
test: updating spec by an extra disk and the .mgr pool configuration
2024-01-30 09:56:18 -07:00
parth-gr 75fcffd08c ci: reformat the python scripts
currently there is a new release of black
formatter so updating it with new release

Closes: https://github.com/rook/rook/issues/13630

Signe-off-by: parth-gr <partharora1010@gmail.com>
Signed-off-by: parth-gr <paarora@redhat.com>
2024-01-30 20:17:49 +05:30
Javier 95ae42c2bd helm: allow defining multiple cephEcStorageClass
This update modifies the Helm chart rook-ceph-cluster
to allow define cephStorageClass as part of the blokpool
also the documentation was updated for cephECBlockPool definition

Signed-off-by: Javier <sjavierlopez@gmail.com>
2024-01-29 19:23:18 -06:00
Travis Nielsen 3b1a428688 Merge pull request #13622 from Madhu-1/csi-name-prefix
csi: option to customize csi driver name prefix
2024-01-29 10:55:55 -07:00
Redouane Kachach 02f86dea24 test: adding a clarification note about this spec file usage
Signed-off-by: Redouane Kachach <rkachach@redhat.com>
2024-01-29 17:30:42 +01:00
Madhu Rajanna c35a8532aa csi: option to customize csi driver name prefix
For now we are using the operator namespace name
as the prefix for the csi driver, This PR provides
an option for the users if someone wants to have
their own prefix for the csi driver, if someone tries
to change the prefix for existing csi driver rook
operator will fail to reconcile the csi driver.

Signed-off-by: Madhu Rajanna <madhupr007@gmail.com>
2024-01-29 10:54:25 +01:00
travisn ca28887403 operator: increase cpu limits
The operator needs to burst significantly when reconciling,
then will quiet down and nearly not consume any cpu.
Therefore, we allow the operator to burst to more than
a full cpu instead of limiting it to a half cpu.

Signed-off-by: travisn <tnielsen@redhat.com>
2024-01-25 10:12:55 -07:00
Redouane Kachach 7884b2a3ed test: updating spec by an extra disk and the .mgr pool configuration
Signed-off-by: Redouane Kachach <rkachach@redhat.com>
2024-01-23 16:23:00 +01:00
Erik Berg 2a225ac718 helm: remove duplicate key for toolbox keyring
We set `ceph_secret=${ROOK_CEPH_SECRET}` just a couple lines above,
and this duplicate is probably just an oversight.

This duplicate key is not present in the similar scripts in
  examples/toolbox.yaml
  examples/toolbox-operator-image.yaml

Signed-off-by: Erik Berg <erikberg@usit.uio.no>
2024-01-23 11:54:00 +01:00
Erik Berg 9a2d8505e7 helm: fix indentation/whitespace
Removing whitespace for consistency and wrong indentation level.
There's one actual "oopsie-fix" in here for CSI_ENABLE_READ_AFFINITY

Signed-off-by: Erik Berg <erikberg@usit.uio.no>
2024-01-23 11:53:46 +01:00
travisn f0c30e2edb manifest: remove pg_autoscaler from mgr modules examples
The pg_autoscaler mgr module is no longer possible to disable.
Ceph requires the module to always be enabled. Now the
autoscaling configuration is done with a per-pool setting.

Now the rook module is shown as an example to enable.

Signed-off-by: travisn <tnielsen@redhat.com>
2024-01-19 14:26:41 -07:00
Travis Nielsen f46c0845ee Merge pull request #13573 from Madhu-1/fix-13475
csi: make leader election flags configurable
2024-01-18 11:55:38 -07:00
Madhu Rajanna 85b86efee1 csi: update csi provisioner to 3.6.3
updating csi provisioner to 3.6.3 to
as we have a bug in 3.6.2

resolves: #13475

Signed-off-by: Madhu Rajanna <madhupr007@gmail.com>
2024-01-17 11:02:08 +01:00
Madhu Rajanna 9b418d24a1 csi: make leader election flags configurable
This commit adds the flexibility to configure
leader election flags as per the user
requirement and also keeps the existing values
as the default one.

resolve: #13475

Signed-off-by: Madhu Rajanna <madhupr007@gmail.com>
2024-01-17 10:02:49 +01:00
Travis Nielsen 2ba90e9072 Merge pull request #13258 from iPraveenParihar/csi/update-cmdline-args
csi: update cmdline args as used by ceph-csi
2024-01-16 12:29:52 -07:00
Praveen M a80396df1b csi: update cmdline args as used by ceph-csi
This commit adds cmdline args to enable
1. RecoverVolumeExpansionFailure
2. PreventVolumeModeConversion
3. HonorPVReclaimPolicy

Signed-off-by: Praveen M <m.praveen@ibm.com>
2024-01-12 15:24:07 +05:30
travisn 98816ad79f mds: increase max limit of mds active daemons
The mds max daemons had been set arbitrarily to 10.
Allow more mds daemons for clusters that have a
scenario for large numbers of mds to manage the
filesystem metadata.

Signed-off-by: travisn <tnielsen@redhat.com>
2024-01-11 12:24:20 -07:00
parth-gr 8e4ec01cbb external: honour support of cluster-name legacy flag
we have changed the --cluster-name flag to --k8s-cluster-name
but to support automation while upgrade we should support
the legacy flag

Signed-off-by: parth-gr <partharora1010@gmail.com>
2024-01-09 21:20:16 +05:30
travisn 3c1b0692e4 manifest: shorten crd descriptions to 100 chars
Long CRD descriptions were pushing the size of the CRDs manifest
over 1MB, which causes issues when creating the CRDs. To shorten
the manifest, the descriptions are now limited to 100 chars.
This still gives some ability for dev tools to show a brief
description if needed. The generated CRD docs still contain
the full descriptions for reference.

Signed-off-by: travisn <tnielsen@redhat.com>
2024-01-05 09:10:36 -07:00
dependabot[bot] f56f06f955 build(deps): bump the k8s-dependencies group with 4 updates
Bumps the k8s-dependencies group with 4 updates: [k8s.io/api](https://github.com/kubernetes/api), [k8s.io/apiextensions-apiserver](https://github.com/kubernetes/apiextensions-apiserver), [k8s.io/cli-runtime](https://github.com/kubernetes/cli-runtime) and [k8s.io/cloud-provider](https://github.com/kubernetes/cloud-provider).

Updates `k8s.io/api` from 0.28.4 to 0.29.0
- [Commits](https://github.com/kubernetes/api/compare/v0.28.4...v0.29.0)

Updates `k8s.io/apiextensions-apiserver` from 0.28.4 to 0.29.0
- [Release notes](https://github.com/kubernetes/apiextensions-apiserver/releases)
- [Commits](https://github.com/kubernetes/apiextensions-apiserver/compare/v0.28.4...v0.29.0)

Updates `k8s.io/cli-runtime` from 0.28.4 to 0.29.0
- [Commits](https://github.com/kubernetes/cli-runtime/compare/v0.28.4...v0.29.0)

Updates `k8s.io/cloud-provider` from 0.28.4 to 0.29.0
- [Commits](https://github.com/kubernetes/cloud-provider/compare/v0.28.4...v0.29.0)

---
updated-dependencies:
- dependency-name: k8s.io/api
  dependency-type: direct:production
  update-type: version-update:semver-minor
  dependency-group: k8s-dependencies
- dependency-name: k8s.io/apiextensions-apiserver
  dependency-type: direct:production
  update-type: version-update:semver-minor
  dependency-group: k8s-dependencies
- dependency-name: k8s.io/cli-runtime
  dependency-type: direct:production
  update-type: version-update:semver-minor
  dependency-group: k8s-dependencies
- dependency-name: k8s.io/cloud-provider
  dependency-type: direct:production
  update-type: version-update:semver-minor
  dependency-group: k8s-dependencies
...

Signed-off-by: dependabot[bot] <support@github.com>
2024-01-05 09:08:53 -07:00
Blaine Gardner cd253d0218 multus: use nginx-unprivileged image from quay
Use Quay as the source for the nginx-unprivileged image used for the
Multus validation tool because Quay does not rate limit image pulls,
which are a common complaint for users of the tool.

Signed-off-by: Blaine Gardner <blaine.gardner@ibm.com>
2024-01-04 14:25:40 -07:00
travisn 56a3370d83 docs: update all examples to ceph v18.2.1
Since v18.2.1 is the default recommendation for the ceph version,
update all the docs and examples to that version.

Signed-off-by: travisn <tnielsen@redhat.com>
2024-01-03 14:37:11 -07:00
travisn 5f60d2dfac helm: update default ceph version to v18.2.1
In the cluster chart, set the default ceph version
to v18.2.1.

Signed-off-by: travisn <tnielsen@redhat.com>
2024-01-03 14:35:17 -07:00
Riya Singhal ef1ee6ebae csi: update default cephcsi version to 3.10.1
This commit updates default cephcsi driver version
to v3.10.1

Signed-off-by: Riya Singhal <rsinghal@redhat.com>
2023-12-19 23:42:26 +05:30
Travis Nielsen 5c3ff3ae81 Merge pull request #13411 from nixpanic/csi-addons/v0.8.0
csi: update the CSI-Addons sidecar to v0.8.0
2023-12-19 08:39:39 -07:00
Travis Nielsen 0db1477db9 Merge pull request #13418 from jfcoz/fix/operator_tolerations
helm: Fix duplicate tolerations
2023-12-18 13:00:42 -07:00
Blaine Gardner 01d7b22cf1 build: update base and manifests to ceph v18.2.1
Update Rook operator base image and example manifests to the latest Ceph
version released late last week v18.2.1.

Signed-off-by: Blaine Gardner <blaine.gardner@ibm.com>
2023-12-18 11:27:52 -07:00
Julien Francoz 1171b60862 helm: fix duplicate tolerations
Fix duplicates tolerations in operator Deployment

Resolves https://github.com/rook/rook/issues/13416

Signed-off-by: Julien Francoz <julien-github@francoz.net>
2023-12-18 17:59:44 +00:00
Blaine Gardner 61d0922010 Merge pull request #12369 from sp98/mon-failover
mon: allow changing hostNetwork settings
2023-12-18 08:54:59 -07:00
sp98 42ea2897cf mon: allow changing hostNetwork settings
Allow changing spec.network.hostNetwork settings on a running cluster
by failing over the mons

Signed-off-by: sp98 <sapillai@redhat.com>
2023-12-18 10:30:48 +05:30
Charlie Haley 0768eb125b helm: allow configuring monitoring interval
Signed-off-by: Charlie Haley <charlie.haley@hotmail.com>
2023-12-15 14:56:09 +00:00
Niels de Vos 1ca1257c65 csi: update the CSI-Addons sidecar to v0.8.0
Quite some improvements have been included in the recently released
v0.8.0 of the CSI-Addons sidecar for Kubernetes. Rook users will benefit
from running the latest version of the sidecar when deploying Ceph-CSI.

See-also: https://github.com/csi-addons/kubernetes-csi-addons/releases/tag/v0.8.0
Signed-off-by: Niels de Vos <ndevos@ibm.com>
2023-12-15 15:13:42 +01:00
Travis Nielsen 1e9c160cd6 Merge pull request #13383 from parth-gr/external-run-as-a-user
external: fix the run as a user flag
2023-12-13 11:17:36 -07:00
parth-gr 8d89faf615 external: fix the run as a user flag
there is a hardcoded value of "client.healthchecker"
which needs to be replaced by self.run_as_user

Signed-off-by: parth-gr <partharora1010@gmail.com>
2023-12-13 14:18:42 +05:30
parth-gr 098f1fe5e8 build: add cel rule to make resource immutable
added the cel rules at sunvolumgroup and rados
namesapce spec

closes: #13315

Signed-off-by: parth-gr <partharora1010@gmail.com>
2023-12-12 21:40:35 +05:30
parth-gr c9fd382c13 subvolumegroup: add pinning spec in subvolumegroup CRD
subvolumegroup can be pinned by pintype and pinsetting
So adding the spec to enhance its functionality

Closes: https://github.com/rook/rook/issues/12607

Signed-off-by: parth-gr <paarora@redhat.com>
2023-12-11 21:54:25 +05:30
Travis Nielsen 41404c131c Merge pull request #13347 from parth-gr/svg-add-cr
subvolumegroup: add default csi svg CR to filesystem CR
2023-12-11 08:36:37 -07:00
parth-gr 31bd3bcf96 subvolumegroup: add default csi svg CR to filesystem CR
Add the default csi svg cr to exmaples.yaml and helm

Closes: https://github.com/rook/rook/issues/13040

Signed-off-by: parth-gr <paarora@redhat.com>
2023-12-11 14:11:23 +05:30
Blaine Gardner 0db942eb52 doc: update example manifests to ceph v18/v18.2.0
Update sample manifests to use Ceph v18 or v18.2.0 as appropriate now
that Reef is found to be stable.

Signed-off-by: Blaine Gardner <blaine.gardner@ibm.com>
2023-12-08 14:18:47 -07:00