This reverts commit ceec0bc48c. The build
is failing to push images to master. This is not a critical update so
let's remove.
Signed-off-by: Sébastien Han <seb@redhat.com>
The toolbox can now interact with S3 gateways using the `s5cmd` tool.
The binary is only 12M so this does not add up too much to the operator
image size.
Closes: https://github.com/rook/rook/issues/4968
Signed-off-by: Sébastien Han <seb@redhat.com>
Fixes issues with the `build/run` tooling, notably for publishing images
where `build/run make <args>` would only result in `make` being called
without args.
Signed-off-by: Blaine Gardner <blaine.gardner@redhat.com>
we are adding new linter for shellcheck.
As we are writing more shell scripts this
will help maintain quality.
Also, doing all the changes required in
bash files to pass this shellcheck.
Closes: https://github.com/rook/rook/issues/8431
Signed-off-by: subhamkrai <srai@redhat.com>
Rook CephObjectStore S3 connections may be affected by CVE-2021-34558.
This is fixed in Go v1.16.6, so we update to the latest Go version
available to ensure this is fixed in future builds.
Signed-off-by: Blaine Gardner <blaine.gardner@redhat.com>
No need to include darwin and windows in the list of platforms
since rook is only containerized and expected to run in a linux
environment.
Signed-off-by: Travis Nielsen <tnielsen@redhat.com>
With the release of go 1.16, we update the tools. The -i flag is
now deprecated, no longer necessary for building in a private directory.
The go modules are cleaned up at the same time.
Signed-off-by: Travis Nielsen <tnielsen@redhat.com>
Update the cross build container to use golang 1.15.7 instead
of 1.13.8. The update to build with 1.15 had only been made in the
AMI, and is now updated in the container as well.
Signed-off-by: Travis Nielsen <tnielsen@redhat.com>
Automatically detect Podman if Docker is not available.
This allows me to run make and complete it succesfully without Docker
and without the need to set the DOCKERCMD env. variable.
Closes: https://github.com/rook/rook/issues/5335
Signed-off-by: Yaniv Kaul <ykaul@redhat.com>
In the image makefiles use the "DOCKERCMD" variable in place of
calls to docker command line tool. This allows custom paths
to docker or other docker-compatible tools to be used for builds.
Signed-off-by: John Mulligan <jmulligan@redhat.com>
Many of the `rook/images/<image>/` directory Makefiles defined a
variable called `IMAGES`, which was unused and causing some developer
confusion with the feature adding the ability to specify which backend
images to build. Remove these unused instances.
Signed-off-by: Blaine Gardner <blaine.gardner@suse.com>
Instead of adding Ceph packages to Rook's base image, use
ceph-container's base image, which has Ceph packages preinstalled. Rook
now benefits from the testing the ceph-container project does, and the
scope of the Rook project no longer has to maintain builds of base
images containing Ceph packages.
The only ARM builds of ceph-container are CentOS, and as switching to
CentOS was already a thought, that is easily done at the same time as
this change.
Signed-off-by: Blaine Gardner <blaine.gardner@suse.com>
While ceph can build fine on armhf it is not a tested configuration
today nor are debian packages for ceph published. Also ceph requires
more horsepower than is typically available on armhf machines.
We are dropping armhf support for now. arm64 is still supported.
Sébastien Han
snyk-bot
Blaine Gardner
subhamkrai
Travis Nielsen
Ma Xinjian
Yaniv Kaul
moricho
John Mulligan
Michael Goff
Fan, Shang Xiang
Ganesh Maharaj Mahalingam
Bassam Tabbara
Blaine Gardner
Jared Watts
Bassam Tabbara
Bassam Tabbara
Ian Lovett