The integration tests were creating several namespace-specific resources
in the system namespace instead of the namespace with the cluster. This
was only affecting the rook-ceph-osd and rook-ceph-mgr service accounts,
which hadn't been exercised until the nodes were queried by osds for
topology awareness.
Signed-off-by: Travis Nielsen <tnielsen@redhat.com>
The guide for configuring object stores has a new flow for creating
buckets in the object store. This requires a new approach instead of
asking the user to create user creds and a bucket with other commands
such as s3cmd.
Signed-off-by: Travis Nielsen <tnielsen@redhat.com>
We removed the topologyAware CRD option since it was redundant with the
use of an OSD being backed by a PVC.
So now, if an OSD is backed by a PVC we assume the topology aware
decision and will discover zone and region labels on that host.
Signed-off-by: Sébastien Han <seb@redhat.com>
This fixes the conditional for the `rbdGrpcMetricsPort` option.
Previously the `rbdGrpcMetricsPort` was useless as it was not used,
instead the Helm chart looked for `cephfsrbdGrpcMetricsPort` option.
Signed-off-by: Alexander Trost <galexrt@googlemail.com>
This is the first phase miscellaneous part of three phases to improve and
rework the Rook documentation for better user accessibility to the Rook
projects and with that the storage providers.
Phase two is about automatic generation of CRD documentation and phase
three is about reworking the docs themselves and, e.g., examples for
CRDs and certain use cases.
Signed-off-by: Alexander Trost <galexrt@googlemail.com>
This is the first phase YugabyteDB part of three phases to improve and
rework the Rook documentation for better user accessibility to the Rook
projects and with that the storage providers.
Phase two is about automatic generation of CRD documentation and phase
three is about reworking the docs themselves and, e.g., examples for
CRDs and certain use cases.
Signed-off-by: Alexander Trost <galexrt@googlemail.com>
This is the first phase EdgeFS part of three phases to improve and
rework the Rook documentation for better user accessibility to the Rook
projects and with that the storage providers.
Phase two is about automatic generation of CRD documentation and phase
three is about reworking the docs themselves and, e.g., examples for
CRDs and certain use cases.
Signed-off-by: Alexander Trost <galexrt@googlemail.com>
This is the first phase CockroachDB part of three phases to improve and
rework the Rook documentation for better user accessibility to the Rook
projects and with that the storage providers.
Phase two is about automatic generation of CRD documentation and phase
three is about reworking the docs themselves and, e.g., examples for
CRDs and certain use cases.
Signed-off-by: Alexander Trost <galexrt@googlemail.com>
This is the first phase Ceph part of three phases to improve and rework
the Rook documentation for better user accessibility to the Rook
projects and with that the storage providers.
Phase two is about automatic generation of CRD documentation and phase
three is about reworking the docs themselves and, e.g., examples for
CRDs and certain use cases.
Signed-off-by: Alexander Trost <galexrt@googlemail.com>
This is the first phase Ceph part of three phases to improve and rework
the Rook documentation for better user accessibility to the Rook
projects and with that the storage providers.
Phase two is about automatic generation of CRD documentation and phase
three is about reworking the docs themselves and, e.g., examples for
CRDs and certain use cases.
Signed-off-by: Alexander Trost <galexrt@googlemail.com>
The node labels were already supported for zones and regions to add to
the CRUSH map. Now all layers of the CRUSH map will be supported
with the new labels such as topology.rook.io/rack.
The labels will be detected at the osd startup time
similar to the zone and region labels already being detected.
Signed-off-by: Travis Nielsen <tnielsen@redhat.com>
The block integration tests are a source of intermittent failures
in the CI. The PVCs were not being confirmed as removed before the
pools were deleted. Then the pool would not be removed since there
might still be a block image from the PVC that wasn't deleted yet.
Now the tests will ensure the PVCs and their block images are
removed before the pool is deleted.
Signed-off-by: Travis Nielsen <tnielsen@redhat.com>
- Implement exportable TolerationSet with the following differences:
- Change map key to a string to ensure it is deterministic.
The old key was a struct that included a pointer.
- Sort the outputted list by this key to ensure the order is deterministic.
- Get the tolerations from the deployment instead of the pod as pod tolerations
are sometimes modified by the system. We only want user provided tolerations
in our deployment.
- Modify tests to try duplicate keys from different structs. The old way tested duplicate
keys using the same structs.
Signed-off-by: Rohan CJ <rohantmp@gmail.com>
**Description of your changes:**
Include missing rollebindings present in common.yaml file and not in the
rolebindings file for the Ceph Helm chart.
Resolves #
Signed-off-by: Juan Miguel Olmo Martínez <jolmomar@redhat.com>
when running OSD on PVC, orchestration should not be started again if there is any change in the device config
map. Added a check to skip orchestration on device CM update when StorageClassDeviceSets are available,
that is, when running osd on pvc.
Signed-off-by: Santosh Pillai <sapillai@redhat.com>
If the cluster has previously been initialized and the operator
is restarted, the operator needs to perform the first orchestration
to confirm basic cluster health, then start watching for CR events.
If there was a single mon pod in a failed or pending pod state, the
orchestration was blocked even if just one mon was in this state.
The scenario is when a node is lost and a mon and the operator happen
to be running on that node. The operator will restart, but the mon
will not restart because it is tied to the node that died (unless running
on a PVC). The mon would remain in a pending state while attempting
to schedule on the node that is down indefinitely and the operator would
be blocked indefinitely. Now we will just log the error and attempt
to continue.
Signed-off-by: Travis Nielsen <tnielsen@redhat.com>
Some testing on OpenShift has shown that enabling Hostnetworking causes
issues with ceph-volume creating OSD.
This is a pure Red Hat OpenShift downstream issue.
This is meant to be temporary while we are waiting for the Selinux team
to get back to us.
Signed-off-by: Sébastien Han <seb@redhat.com>
Change the canaries to use the rook image instead of the busybox image to
run `sleep infinity`. This removes our dependency on an external image that
we do not control.
Signed-off-by: Rohan CJ <rohantmp@gmail.com>
Generating keyrings after deployments created a race condition
resulting in intermittent OSD pod failure on the first attempt.
This change creates keyrings prior to creation of OSD deployments
and updates the owner after the creation of a deployment.
Partially fixes: rook#4089
Signed-off-by: egafford <egafford@redhat.com>
Issues are already being closed if there is no activity for 90 days.
Pull requests have not been closed automatically. This change will cause
pull requests to be closed after six months of inactivity. If there is
no further activity, the PR will be closed after one more month.
Signed-off-by: Travis Nielsen <tnielsen@redhat.com>
Both issues were already merged in Kubespray, so hopefully irrelevant anymore.
Co-authored-by: Yaniv Kaul <ykaul@redhat.com>
Signed-off-by: Travis Nielsen <tnielsen@redhat.com>
PR #3611 added the possibility of using something other
than docker as the container CLI, but the readme wasn't
updated.
[skip ci]
Signed-off-by: Kristoffer Grönlund <kgronlund@suse.com>
Travis Nielsen
d-luu
Jiffin Tony Thottan
Sébastien Han
Alexander Trost
Rohan CJ
Juan Miguel Olmo Martínez
Santosh Pillai
egafford
Dmitry Yusupov
Kristoffer Grönlund
Ashley Williams
Sebastian Wagner
Anton Skriptsov