feedc0de/my-rook-config
1
0 Fork 0
forked from rook/rook
Code Pull Requests Activity
12,577 Commits 38 Branches 289 Tags
9ebef6a11ba0ebfefb4e045903c00a88492efdd7
Commit Graph
4784 Commits
Author SHA1 Message Date
Joshua Hoblitt fc392248c6 object: simplify obc storageclass lookup 
obc was using an internal exponential backup for the lookup of the sc.
This is somewhat of an anti-pattern when using controller-runtime as it
implements retrying logic. If the sc doesn't exist, the reconcile
attempt should fail immediately and controller-runtime will handle the
back-off policy.

Signed-off-by: Joshua Hoblitt <josh@hoblitt.com>
(cherry picked from commit 80da084732)
 2025-08-04 15:06:41 +00:00
Joshua Hoblitt 7b65e17599 object: fix bucket policy in sync detection 
A typo was causing the operator to attempt to sync bucket policy when
the state was already in sync. This resulted in the operator carrying
out unnecessary work and logging activity with no user visible change
resulting.

Signed-off-by: Joshua Hoblitt <josh@hoblitt.com>
(cherry picked from commit fbc60608ed)
 2025-08-01 19:27:10 +00:00
mergify[bot] 60ffd2991e Merge pull request #16218 from rook/mergify/bp/release-1.18/pr-16210 
exporter: automate rotate exporter cephx keys (backport #16210)
 2025-08-01 17:20:35 +00:00
parth-gr 3df15cacef exporter: automate rotate exporter cephx keys 
rotate cephx keys based on keyRotationPolicy
and update cephxStatus for the ceph exporter daemon pods.

Signed-off-by: parth-gr <partharora1010@gmail.com>
(cherry picked from commit 9ec7a767c3)
 2025-08-01 16:11:14 +00:00
Blaine Gardner 55de1bcb38 osd: implement automated cephx key rotation for osds 
Implement automated CephX key rotation for OSDs.

OSDs have marshalled CephX statuses applied as an annotation on the OSD
pod spec, which differs from other Rook Ceph daemons for a two reasons:

A large cluster could have hundreds or thousands of OSDs, so it is more
critical that Rook avoid rotating OSD keys more than once in the event a
CephCluster reconcile restarts partway through OSD creation/updation.

OSDs do not have their CephX keys stored in K8s Secrets, whose resource
version is used for enforcing the desired restart behavior other daemon
pods like RGWs.

Signed-off-by: Blaine Gardner <blaine.gardner@ibm.com>
(cherry picked from commit 4189a196c1)
 2025-08-01 16:09:14 +00:00
Oded Viner 5992415b36 core: improve cleanup of /var/lib/rook during cluster teardown 
extend StartHostPathCleanup to remove additional directories
under /var/lib/rook

Signed-off-by: Oded Viner <oviner@redhat.com>
 2025-07-31 19:14:24 +03:00
Santosh Pillai fd2b4333e8 Merge pull request #16171 from parth-gr/cephx-crashcollector 
core: automate rotate crashcollector  cephx keys
 2025-07-31 13:41:13 +05:30
parth-gr fd6d22fcfe core: automate rotate crashcollector keys 
rotate cephx keys based on keyRotationPolicy
and update cephxStatus for the crashcollector
daemon pods.

Signed-off-by: parth-gr <partharora1010@gmail.com>
 2025-07-31 11:30:55 +05:30
dependabot[bot] a324a680f9 build(deps): bump the k8s-dependencies group across 1 directory with 7 updates 
Bumps the k8s-dependencies group with 6 updates in the / directory:

| Package | From | To |
| --- | --- | --- |
| [k8s.io/apiextensions-apiserver](https://github.com/kubernetes/apiextensions-apiserver) | `0.32.3` | `0.33.3` |
| [k8s.io/cli-runtime](https://github.com/kubernetes/cli-runtime) | `0.32.3` | `0.33.3` |
| [k8s.io/cloud-provider](https://github.com/kubernetes/cloud-provider) | `0.32.3` | `0.33.3` |
| [sigs.k8s.io/controller-runtime](https://github.com/kubernetes-sigs/controller-runtime) | `0.20.3` | `0.21.0` |
| [sigs.k8s.io/mcs-api](https://github.com/kubernetes-sigs/mcs-api) | `0.1.0` | `0.2.0` |
| [sigs.k8s.io/yaml](https://github.com/kubernetes-sigs/yaml) | `1.4.0` | `1.6.0` |

Updates `k8s.io/apiextensions-apiserver` from 0.32.3 to 0.33.3
- [Release notes](https://github.com/kubernetes/apiextensions-apiserver/releases)
- [Commits](https://github.com/kubernetes/apiextensions-apiserver/compare/v0.32.3...v0.33.3)

Updates `k8s.io/cli-runtime` from 0.32.3 to 0.33.3
- [Commits](https://github.com/kubernetes/cli-runtime/compare/v0.32.3...v0.33.3)

Updates `k8s.io/client-go` from 0.32.3 to 0.33.3
- [Changelog](https://github.com/kubernetes/client-go/blob/master/CHANGELOG.md)
- [Commits](https://github.com/kubernetes/client-go/compare/v0.32.3...v0.33.3)

Updates `k8s.io/cloud-provider` from 0.32.3 to 0.33.3
- [Commits](https://github.com/kubernetes/cloud-provider/compare/v0.32.3...v0.33.3)

Updates `sigs.k8s.io/controller-runtime` from 0.20.3 to 0.21.0
- [Release notes](https://github.com/kubernetes-sigs/controller-runtime/releases)
- [Changelog](https://github.com/kubernetes-sigs/controller-runtime/blob/main/RELEASE.md)
- [Commits](https://github.com/kubernetes-sigs/controller-runtime/compare/v0.20.3...v0.21.0)

Updates `sigs.k8s.io/mcs-api` from 0.1.0 to 0.2.0
- [Release notes](https://github.com/kubernetes-sigs/mcs-api/releases)
- [Changelog](https://github.com/kubernetes-sigs/mcs-api/blob/master/RELEASE.md)
- [Commits](https://github.com/kubernetes-sigs/mcs-api/compare/v0.1.0...v0.2.0)

Updates `sigs.k8s.io/yaml` from 1.4.0 to 1.6.0
- [Release notes](https://github.com/kubernetes-sigs/yaml/releases)
- [Changelog](https://github.com/kubernetes-sigs/yaml/blob/master/RELEASE.md)
- [Commits](https://github.com/kubernetes-sigs/yaml/compare/v1.4.0...v1.6.0)

---
updated-dependencies:
- dependency-name: k8s.io/apiextensions-apiserver
  dependency-version: 0.33.3
  dependency-type: direct:production
  update-type: version-update:semver-minor
  dependency-group: k8s-dependencies
- dependency-name: k8s.io/cli-runtime
  dependency-version: 0.33.3
  dependency-type: direct:production
  update-type: version-update:semver-minor
  dependency-group: k8s-dependencies
- dependency-name: k8s.io/client-go
  dependency-version: 0.33.3
  dependency-type: direct:production
  update-type: version-update:semver-minor
  dependency-group: k8s-dependencies
- dependency-name: k8s.io/cloud-provider
  dependency-version: 0.33.3
  dependency-type: direct:production
  update-type: version-update:semver-minor
  dependency-group: k8s-dependencies
- dependency-name: sigs.k8s.io/controller-runtime
  dependency-version: 0.21.0
  dependency-type: direct:production
  update-type: version-update:semver-minor
  dependency-group: k8s-dependencies
- dependency-name: sigs.k8s.io/mcs-api
  dependency-version: 0.2.0
  dependency-type: direct:production
  update-type: version-update:semver-minor
  dependency-group: k8s-dependencies
- dependency-name: sigs.k8s.io/yaml
  dependency-version: 1.6.0
  dependency-type: direct:production
  update-type: version-update:semver-minor
  dependency-group: k8s-dependencies
...

Signed-off-by: dependabot[bot] <support@github.com>
 2025-07-30 17:20:50 -06:00
Travis Nielsen f22984a9b2 Merge pull request #16159 from rook/dependabot/go_modules/github-dependencies-907e36c764 
build(deps): bump the github-dependencies group across 1 directory with 8 updates
 2025-07-30 17:13:33 -06:00
dependabot[bot] 0b0dfc285d build(deps): bump the github-dependencies group across 1 directory with 8 updates 
Bumps the github-dependencies group with 6 updates in the / directory:

| Package | From | To |
| --- | --- | --- |
| [github.com/aws/aws-sdk-go-v2/config](https://github.com/aws/aws-sdk-go-v2) | `1.29.14` | `1.29.18` |
| [github.com/aws/aws-sdk-go-v2/service/sns](https://github.com/aws/aws-sdk-go-v2) | `1.34.3` | `1.34.8` |
| [github.com/k8snetworkplumbingwg/network-attachment-definition-client](https://github.com/k8snetworkplumbingwg/network-attachment-definition-client) | `1.7.6` | `1.7.7` |
| [github.com/prometheus-operator/prometheus-operator/pkg/apis/monitoring](https://github.com/prometheus-operator/prometheus-operator) | `0.81.0` | `0.84.0` |
| [github.com/prometheus-operator/prometheus-operator/pkg/client](https://github.com/prometheus-operator/prometheus-operator) | `0.81.0` | `0.84.0` |
| [github.com/spf13/pflag](https://github.com/spf13/pflag) | `1.0.6` | `1.0.7` |

Updates `github.com/aws/aws-sdk-go-v2/config` from 1.29.14 to 1.29.18
- [Release notes](https://github.com/aws/aws-sdk-go-v2/releases)
- [Changelog](https://github.com/aws/aws-sdk-go-v2/blob/main/changelog-template.json)
- [Commits](https://github.com/aws/aws-sdk-go-v2/compare/config/v1.29.14...config/v1.29.18)

Updates `github.com/aws/aws-sdk-go-v2/credentials` from 1.17.67 to 1.17.71
- [Release notes](https://github.com/aws/aws-sdk-go-v2/releases)
- [Changelog](https://github.com/aws/aws-sdk-go-v2/blob/main/changelog-template.json)
- [Commits](https://github.com/aws/aws-sdk-go-v2/compare/credentials/v1.17.67...credentials/v1.17.71)

Updates `github.com/aws/aws-sdk-go-v2/service/sns` from 1.34.3 to 1.34.8
- [Release notes](https://github.com/aws/aws-sdk-go-v2/releases)
- [Changelog](https://github.com/aws/aws-sdk-go-v2/blob/main/changelog-template.json)
- [Commits](https://github.com/aws/aws-sdk-go-v2/compare/service/amp/v1.34.3...service/sns/v1.34.8)

Updates `github.com/aws/smithy-go` from 1.22.3 to 1.22.4
- [Release notes](https://github.com/aws/smithy-go/releases)
- [Changelog](https://github.com/aws/smithy-go/blob/main/CHANGELOG.md)
- [Commits](https://github.com/aws/smithy-go/compare/v1.22.3...v1.22.4)

Updates `github.com/k8snetworkplumbingwg/network-attachment-definition-client` from 1.7.6 to 1.7.7
- [Release notes](https://github.com/k8snetworkplumbingwg/network-attachment-definition-client/releases)
- [Commits](https://github.com/k8snetworkplumbingwg/network-attachment-definition-client/compare/v1.7.6...v1.7.7)

Updates `github.com/prometheus-operator/prometheus-operator/pkg/apis/monitoring` from 0.81.0 to 0.84.0
- [Release notes](https://github.com/prometheus-operator/prometheus-operator/releases)
- [Changelog](https://github.com/prometheus-operator/prometheus-operator/blob/main/CHANGELOG.md)
- [Commits](https://github.com/prometheus-operator/prometheus-operator/compare/v0.81.0...v0.84.0)

Updates `github.com/prometheus-operator/prometheus-operator/pkg/client` from 0.81.0 to 0.84.0
- [Release notes](https://github.com/prometheus-operator/prometheus-operator/releases)
- [Changelog](https://github.com/prometheus-operator/prometheus-operator/blob/main/CHANGELOG.md)
- [Commits](https://github.com/prometheus-operator/prometheus-operator/compare/v0.81.0...v0.84.0)

Updates `github.com/spf13/pflag` from 1.0.6 to 1.0.7
- [Release notes](https://github.com/spf13/pflag/releases)
- [Commits](https://github.com/spf13/pflag/compare/v1.0.6...v1.0.7)

---
updated-dependencies:
- dependency-name: github.com/aws/aws-sdk-go-v2/config
  dependency-version: 1.29.18
  dependency-type: direct:production
  update-type: version-update:semver-patch
  dependency-group: github-dependencies
- dependency-name: github.com/aws/aws-sdk-go-v2/credentials
  dependency-version: 1.17.71
  dependency-type: direct:production
  update-type: version-update:semver-patch
  dependency-group: github-dependencies
- dependency-name: github.com/aws/aws-sdk-go-v2/service/sns
  dependency-version: 1.34.8
  dependency-type: direct:production
  update-type: version-update:semver-patch
  dependency-group: github-dependencies
- dependency-name: github.com/aws/smithy-go
  dependency-version: 1.22.4
  dependency-type: direct:production
  update-type: version-update:semver-patch
  dependency-group: github-dependencies
- dependency-name: github.com/k8snetworkplumbingwg/network-attachment-definition-client
  dependency-version: 1.7.7
  dependency-type: direct:production
  update-type: version-update:semver-patch
  dependency-group: github-dependencies
- dependency-name: github.com/prometheus-operator/prometheus-operator/pkg/apis/monitoring
  dependency-version: 0.84.0
  dependency-type: direct:production
  update-type: version-update:semver-minor
  dependency-group: github-dependencies
- dependency-name: github.com/prometheus-operator/prometheus-operator/pkg/client
  dependency-version: 0.84.0
  dependency-type: direct:production
  update-type: version-update:semver-minor
  dependency-group: github-dependencies
- dependency-name: github.com/spf13/pflag
  dependency-version: 1.0.7
  dependency-type: direct:production
  update-type: version-update:semver-patch
  dependency-group: github-dependencies
...

Signed-off-by: dependabot[bot] <support@github.com>
 2025-07-30 16:38:46 -06:00
chentao.2022 62631d2614 osd: exclude labels with a value of null from the topology string 
Avoid the OSD startup failing to parse crush_location when
the topology label is empty.

Signed-off-by: chentao.2022 <chentao.2022@bytedance.com>
 2025-07-30 16:07:13 -06:00
Travis Nielsen 79a7a3c01f rgw: increase timeout for admin user creation 
Creating the rgw admin user is taking on the order of two
minutes instead of the expected seconds, thus the command
was timing out and cause the object store user creation
to fail. The increased timeout allows the admin user creation
to complete, and other users to be created as well.

Signed-off-by: Travis Nielsen <tnielsen@redhat.com>
 2025-07-30 12:22:07 -06:00
Travis Nielsen 7b2dfdba17 Merge pull request #16150 from OdedViner/log_panics_controller 
core: log panics in controller reconcile functions
 2025-07-29 09:59:27 -06:00
Oded Viner cf13deee6f core: log panics in controller reconcile functions 
add RecoverAndLogException() helper to log panics with stack trace.
added defer call in all rook controller Reconcile() methods for
better error visibility in operator logs

Signed-off-by: Oded Viner <oviner@redhat.com>
 2025-07-29 13:20:38 +03:00
Santosh Pillai c615967fa8 Merge pull request #16040 from subhamkrai/rotate-csi-keyrings 
csi: automate CSI cephx key rotation
 2025-07-29 11:09:50 +05:30
Blaine Gardner 7ccf8f61d0 Merge pull request #16146 from xose/livenessprobe-sh 
mds: use bash for executing liveness probe script
 2025-07-28 15:03:03 -06:00
Travis Nielsen 55e02436da Merge pull request #16102 from Madhu-1/add-clusterID 
Provide option to set the clusterID in the RNS and SVG CR
 2025-07-28 08:48:38 -06:00
José Martínez e421623fd0 mds: use bash for executing liveness probe script 
This script includes bash features and will fail if sh is not a symlink to bash.

Signed-off-by: José Martínez <xose@google.com>
 2025-07-28 14:24:18 +00:00
Madhu Rajanna 21220ea81f core: add clusterID to subvolume group CRD 
Providing an option for user to specify the clusterID
they want to use in the storageclass while creating
the subvolume group.

Signed-off-by: Madhu Rajanna <madhupr007@gmail.com>
 2025-07-28 08:29:51 +02:00
Madhu Rajanna 2a41afcb28 core: add clusterID to rados namespace CRD 
Providing an option for user to specify the clusterID
they want to use in the storageclass while creating
the radosnamespace.

Signed-off-by: Madhu Rajanna <madhupr007@gmail.com>
 2025-07-28 08:29:51 +02:00
Travis Nielsen f1aa5390e8 Merge pull request #16113 from subhamkrai/upgrade-csi-operator-to-v1 
csi: update csi-operator yaml to v1
 2025-07-25 11:08:32 -06:00
subhamkrai 6d5401c50d csi: automate CSI cephx key rotation 
This PR implements the CSI cephx key rotation feature,
which follows overlapping rotation for non-daemon keys.
Refer to the cephx rotation API from design PR 15915 for details.

Signed-off-by: subhamkrai <srai@redhat.com>
 2025-07-25 15:39:00 +05:30
Blaine Gardner 3cc77f8777 Merge pull request #16142 from sp98/mds-key-rotation 
mds: rotate cephx keys
 2025-07-24 12:17:05 -06:00
subhamkraiandMadhu Rajanna fb1047eb10 rbdmirror: with multus gen file on remote container 
In case of RDR with multus, the file which contains peer
connection details need to generated on mgr proxy remote
since rbd commands in multus, commands are run via mgr
proxy container and not the rook operator pod.

Co-Authored-by: Madhu Rajanna <madhupr007@gmail.com>
Signed-off-by: subhamkrai <srai@redhat.com>
 2025-07-24 12:27:52 +05:30
Santosh Pillai 69a7e88382 mds: better error handling on status update 
Improves error handling when `updatestatus` function is called in
Filesystem controller. Retry logic is added incase of any conflicts and
update error is handled.

Signed-off-by: Santosh Pillai <sapillai@redhat.com>
 2025-07-24 07:31:14 +05:30
Santosh Pillai f795d9ab57 mds: rotate cephx keys 
Rotate cephx keys for all the MDS daemons based on the cephxConfig in
teh cephCluster CR. Update the cephxStatus in the cephCluster CR and
cephfileSystem CR.

Signed-off-by: Santosh Pillai <sapillai@redhat.com>
 2025-07-24 06:59:05 +05:30
subhamkrai 6df727b91a csi: update csi-operator yaml to v1 
this commit updates the csi-operator complete deployment
file csi-operator.yaml to v1 from v1alpha1.

Signed-off-by: subhamkrai <srai@redhat.com>
 2025-07-23 21:02:59 +05:30
subhamkrai 1bde614eb5 core: migrate from v1.Endpoints to discoveryv1.EndpointSlice 
This change updates the codebase to replace the deprecated
v1.Endpoints API with discoveryv1.EndpointSlice.
The v1.Endpoints API has been deprecated in Kubernetes v1.33+

Signed-off-by: subhamkrai <srai@redhat.com>
 2025-07-23 21:02:02 +05:30
Blaine Gardner af6545d79f Merge pull request #16157 from Madhu-1/fix-16156 
csi: update ceph-csi to 3.14.2
 2025-07-22 14:21:16 -06:00
subham rai 1e489fd6ae Merge pull request #16143 from OdedViner/upgrade_go_1_24_new 
core: update rook to go 1.24.3
 2025-07-22 17:18:24 +05:30
Santosh Pillai 28db9740de Merge pull request #16127 from sp98/mgr-key-rotate 
mgr: rotate cephx keys
 2025-07-21 15:29:32 +05:30
Madhu Rajanna 052fe4a9af csi: update ceph-csi to 3.14.2 
Updating the ceph-csi image to 3.14.2
release.

Signed-off-by: Madhu Rajanna <madhupr007@gmail.com>
 2025-07-21 11:24:05 +02:00
Santosh Pillai b486e308c3 mgr: rotate cephx keys 
rotate cephx keys based on keyRotationPolicy and update cephxStatus for
the MGR daemon pods.

Signed-off-by: Santosh Pillai <sapillai@redhat.com>
 2025-07-21 12:31:35 +05:30
Blaine Gardner e4da184ce3 Merge pull request #16132 from parth-gr/fix-rgwstatus-err 
rgw: fail reconcile on status update error
 2025-07-16 14:51:36 -06:00
Blaine Gardner 0488f6dec8 Merge pull request #16060 from parth-gr/cephclient-cephx 
core: automate cephclient cephx key rotation
 2025-07-16 13:35:28 -06:00
Blaine Gardner 22ef8043f9 Merge pull request #16133 from cobaltcore-dev/multus-rgw-zone-json-fix 
multus: support copy file to cmd-proxy container for rgw zone set
 2025-07-16 10:28:50 -06:00
Oded Viner 51e9ddc3f5 core: fix nil pointer panic when startupProbe is set in cephfilesystem 
fixes a nil pointer dereference in GetProbeWithDefaults when
startupProbe is set in cephfilesystem and currentProbe is nil.
adds panic recovery in cephfilesystem reconcile loop to improve
error visibility and avoid silent reconcile restarts.

Signed-off-by: Oded Viner <oviner@redhat.com>
 2025-07-16 18:23:06 +03:00
Oded Viner 67925c9bbe core: update rook to go 1.24.3 
update rook to go 1.24.3

Signed-off-by: Oded Viner <oviner@redhat.com>
 2025-07-16 12:24:50 +03:00
parth-gr 6ffbec7308 core: automate cephclient cephx key rotation 
Ceph has a new ceph auth rotate command currently
present in ceph:main

Add a cephclient api support to rotate the
cephx keys genrated by cephclient

Signed-off-by: parth-gr <partharora1010@gmail.com>
 2025-07-16 14:43:18 +05:30
parth-gr b8517eb54f rgw: fail reconcile on status update error 
if the status update is failed, return an error
and do a new reconcile for the rgw controller

Signed-off-by: parth-gr <partharora1010@gmail.com>
 2025-07-16 14:37:03 +05:30
Artem Torubarov c88e6ea952 multus: support copy file to cmd-proxy container for rgw zone set commands 
Signed-off-by: Artem Torubarov <artem.torubarov@sap.com>
 2025-07-16 10:45:42 +02:00
Travis Nielsen 24b0b866ab core: update go modules to latest except for go 1.24 
Update all the go modules to the latest, except for the modules
that require go 1.24. Those modules will be updated in a
follow-up change.

Signed-off-by: Travis Nielsen <tnielsen@redhat.com>
 2025-07-15 14:13:12 -06:00
Santosh Pillai 615ac4af6d Merge pull request #16087 from elias-dbx/pdb_missing_node 
osd: treat non existing OSD nodes as drained
 2025-07-15 21:47:50 +05:30
Oded Viner e089092092 pool: remove redundant stats pools info log 
remove unnecessary info-level log for enableStatsForPools;
detailed debug log already exists

Signed-off-by: Oded Viner <oviner@redhat.com>
 2025-07-14 12:31:31 +03:00
Blaine Gardner a156f27f34 Merge pull request #16115 from sp98/clusterCephxStatus-uninitialized 
core: init cephxStatus on cephCluster
 2025-07-11 13:52:31 -06:00
Travis Nielsen 7de769c060 Merge pull request #16056 from travisn/mon-failover-host-net 
mon: Failover with host network must use different node
 2025-07-10 10:49:53 -06:00
Travis Nielsen 009e8eb254 Merge pull request #15666 from puskunalis/cleanup-fix-disk-shredding 
osd: fix cleanup job disk shredding
 2025-07-10 10:28:46 -06:00
Travis Nielsen aa61ddb57e mon: failover with host network must use different node 
When a mon is failed over, the old mon is left in mon quorum
until the new quorum is confirmed in quorum. When host networking
is enabled, this may result in two mons being in quorum with the
same ip, if the new mon is scheduled on the same node as the
down mon. This results in daemon crashes in the cluster since
they are confused by multiple of the same ip in the mon map.

The solution is to avoid scaling down the bad mon when host networking
is enabled. This will ensure the new mon is not scheduled on the
same node as the previous mon. With host networking, either another
node is necessary or the original mon must come back online to
restore quorum.

Signed-off-by: Travis Nielsen <tnielsen@redhat.com>
 2025-07-10 10:13:17 -06:00
Santosh Pillai a07f2478f3 core: init cephxStatus on cephCluster 
Set cephXStatus on the CephCluster status to Uninitialized when the
cluster is first created.

Signed-off-by: Santosh Pillai <sapillai@redhat.com>
 2025-07-10 20:43:58 +05:30