Commit Graph
11 Commits
Author SHA1 Message Date
Joshua Hoblitt 48dacb1894 ci: fix shellcheck issues in composite actions
actionlint only understands workflow files, so the .github/actionlint.yaml
ignore keeps the composite action definitions out of `make lint.workflows`.
Apply the same shellcheck fixes there anyway, found by running shellcheck over
their run: blocks directly:

- quote unquoted variable expansions (SC2086): the $GITHUB_ENV writes in
  collect-logs, tmate_debug and upterm_debug, and ${ARCH} in the cri-dockerd
  install in integration-test-setup-cluster-resources
- split `export BLOCK=$(...)` into a separate assignment and export so a
  failing command substitution is not masked (SC2155) in
  encryption-pvc-kms-ibm-kp

Signed-off-by: Joshua Hoblitt <josh@hoblitt.com>
2026-06-22 16:04:55 -07:00
Joshua Hoblitt b6eacdc539 ci: bump and/or pin github action versions
Signed-off-by: Joshua Hoblitt <josh@hoblitt.com>
2026-05-21 13:28:34 -07:00
Michael Adam 19b5efd542 ci: add upterm debugging as an alternative to tmate
This enables interactive debugging of ci checks
with the upterm tool as an alternative to the tmate tool which does not
work entirely anymore.
see https://github.com/rook/rook/issues/16131

addition to tmate, upterm debugging is now enabled via the debug-ci label on
PRs

Signed-off-by: Michael Adam <obnox@samba.org>
2025-11-05 14:57:34 +01:00
Oded Viner e58d0bd1c2 ci: fix typo in debug-ci input for tmate action
fixes a typo in the 'required' field of the debug-ci input in the
tmate_debug action. this prevented the input from being recognized
correctly by github actions.

Signed-off-by: Oded Viner <oviner@redhat.com>
2025-07-07 17:07:15 +03:00
Satoru Takeuchi 47ca3fd245 doc: avoid always enabling tmate session
tmate session is always enabled by mistake. This bug is
introduced in the following PR.

https://github.com/rook/rook/pull/14934

We should enable this if `inputs.debug-ci` is `true`.

Signed-off-by: Satoru Takeuchi <satoru.takeuchi@gmail.com>
2024-10-31 06:00:49 +00:00
Satoru Takeuchi 448f42ab12 test: make debug-ci label work again
cmoposite workflow can't use `github` variable.

close: https://github.com/rook/rook/issues/14898

Signed-off-by: Satoru Takeuchi <satoru.takeuchi@gmail.com>
2024-10-30 01:44:07 +00:00
subhamkrai a223b6777b ci: enable tmate when in debug mode
we don't want to wait for extra 10min once the ci passed,
so we'll add a check if `debug-ci` label is added or debug runner
is triggered from UI then only start tmate. Also, updaing the
development doc and rook test doc.

Signed-off-by: subhamkrai <srai@redhat.com>
2023-08-26 11:14:08 +05:30
subhamkrai f171e1c037 ci: add detached mode in tmate
with detached mode, we don't need to wait for the
tests to complete. Now, we can get inside tmate before
the tests start and we can monitor the tests.

By default, this mode will wait at the end of the job for
a user to connect and then to terminate the tmate session.
If no user has connected within 10 minutes after the post-job step started,
it will terminate the tmate session and quit gracefully.

Signed-off-by: subhamkrai <srai@redhat.com>
2023-07-25 16:54:14 +05:30
subhamkrai ab297afa0e ci: fix tmate access issue
we need make `limit-access-to-actor: false` and also
in the right place where tmate `uses` is called for
composite yaml.

Signed-off-by: subhamkrai <srai@redhat.com>
2023-07-07 21:57:58 +05:30
Deepika Upadhyay fef11fa6a6 ci: timeout-minutes has a known issue with composite
use timeout for the step in main workflow instead

https://github.com/actions/runner/issues/1979
https://github.com/metabase/metabase/pull/24554/files

once support for timeout-minutes is added we can remove these steps

Signed-off-by: Deepika Upadhyay <deepika@koor.tech>
2023-02-21 15:57:00 +05:30
Deepika Upadhyay 01b4ad9eec ci: use composite action for tmate session debugging
this will help deduplicate tmate debug code throughout.

Signed-off-by: Deepika Upadhyay <deepika@koor.tech>
2023-02-20 21:07:20 +05:30