Added unit test for probes changes and
did re-naming of liveness probes file
as it will contain multiple types of probes
Signed-off-by: parth-gr <paarora@redhat.com>
Based on my testing with the guide above,
the original value in the sample code here:
`VAULT_BACKEND_PATH: rook/ver1`
...did not work and resulted in
a Vault path error when Rook attempted
to provision the OSD filesystem.
When I simplified it to:
`VAULT_BACKEND_PATH: rook`
... then it worked.
I also took the opportunity to add
a comment/clarification about the `VAULT_ADDR` URL.
Co-authored-by: Shahak Nagiel <snagiel@yahoo.com>
Signed-off-by: parth-gr <paarora@redhat.com>
Two test jobs were collecting artifacts to the same artifact name, which
can cause race conditions and failures to upload artifacts.
Signed-off-by: Blaine Gardner <blaine.gardner@redhat.com>
The docs have links pointing /design directory in the codebase which
hidden in https://rook.io so change them to rook github repo links.
Fixes: #9768
Signed-off-by: Jiffin Tony Thottan <jthottan@redhat.com>
If Rook is run on a developer machine, devices may accidentally
be consumed by rook and cause data loss.
Signed-off-by: Travis Nielsen <tnielsen@redhat.com>
currently if multisite is not configured Rook sets values for
zone/zonegroup/realm as object store name which is only valid for
internal ceph object store. This may not exists for rgw running in
external cluster.
Signed-off-by: Jiffin Tony Thottan <thottanjiffin@gmail.com>
PR #9546 missed updating the daily-nightly CI jobs, and logs are no
longer properly collected from the upgrade jobs there.
Signed-off-by: Blaine Gardner <blaine.gardner@redhat.com>
Users have reported some problems understanding the teardown
"Zapping Devices" section. Break the section in to per-disk and
all-disks-on-host parts, and clarify that they are not one-size-fits-all
scripts.
Resolves#9542Resolves#9764
Signed-off-by: Blaine Gardner <blaine.gardner@redhat.com>
We don't need to validate the name of Ceph-CSI secret, simply because
the names can be different. The default example have default names but
since the secret can be created by the administrator we should not
assume anything. This check will fail if the secret names are different
for whatever reason. This is especially true for external mode. In
converged mode Rook creates the secrets on its own if needed to ease the
integration with the default StorageClass examples.
Signed-off-by: Sébastien Han <seb@redhat.com>
The external code has its own mechanism to look up the clusterInfo so
let's move this to the non-external condition to clarify the code.
Signed-off-by: Sébastien Han <seb@redhat.com>
This is fixing a potential race where the context is canceled and the
external cluster is trying to fetch the cluster info. If the context is
canceled then the loop will be stuck forever. Now we check for the
canceled context and return appropriately.
Signed-off-by: Sébastien Han <seb@redhat.com>
Instead of setting the default values in the Rook
we should use the defaults provided by the ceph
it self. This configuration is causing problem
for the rbd image creation, this is not allowing
the rbd images to have default image features
which comes with librbd.
Signed-off-by: Madhu Rajanna <madhupr007@gmail.com>
The upgrade function doesn't seem to be that smart
for now so it can update the new auth caps listed
with the existing one, it only compares the value of
the current cap with the MIN_USER_CAP_PERMISSIONS,
Modified the upgrade flag functionality so we can use
this while upgrading the cluster clients
Closes: https://github.com/rook/rook/issues/9589
Signed-off-by: parth-gr <paarora@redhat.com>
The OSD prepare job was succeeding even if the OSDs failed to be listed
by ceph-volume. These errors should be returned and fail the job, resulting
in a retry to retrieve the OSDs. Otherwise, the failure is masked and
the admin needs to dig through logs to find why the OSDs were not configured
on that node.
Signed-off-by: Travis Nielsen <tnielsen@redhat.com>
The backend path was added with additional `transit` to it.
Also added PR test case to check transit engine
Signed-off-by: Jiffin Tony Thottan <thottanjiffin@gmail.com>
When a node is being skipped for creation of OSDs, log a message
that indicates whether it was from the node being unschedulable,
the node is not ready, or the node does not meet the placement
criteria specified in the cluster CR.
Signed-off-by: Travis Nielsen <tnielsen@redhat.com>
Blaine Gardner
Arun Kumar Mohan
Travis Nielsen
Sébastien Han
parth-gr
Jiffin Tony Thottan
Jiffin Tony Thottan
Satoru Takeuchi
bootjp / Yoshiaki Ueda
Madhu Rajanna
Shinya Hayashi
subhamkrai