feedc0de/my-rook-config
1
0 Fork 0
forked from rook/rook
Code Pull Requests Activity
13,292 Commits 38 Branches 289 Tags
c1a892396a94de281cddfa088945b91ae8a6f33a
Commit Graph
13292 Commits
This Branch
This Branch
All Branches
Author SHA1 Message Date
Travis Nielsen 5dde16fcf7 Merge pull request #8180 from subhamkrai/mds-resource-limit 
ceph: give resource request preference for mds_cache_memory_limit
 2021-07-01 09:08:17 -06:00
subhamkrai d41878cb9e ceph: give resource request preference for mds_cache_memory_limit 
earlier, for mds, when resource limit is not defined it has
default limit of `"mds_cache_memory_limit": "4294967296"`
even if resouce.request is defined.

Now, resource request will be given preference when both
request and limit is defined and if only limit is defined
it will be applied or otherwise.

Closes: https://github.com/rook/rook/issues/8143
Signed-off-by: subhamkrai <srai@redhat.com>
 2021-07-01 19:54:07 +05:30
Sébastien Han 8c589a3785 ceph: silence harmless errors 
Let's not look at misleading errors if the operator is still
initializing.

Signed-off-by: Sébastien Han <seb@redhat.com>
 2021-07-01 15:37:08 +02:00
Jiffin Tony Thottan 9e3cf68d04 test: ci test for TLS objectstore 
Extend the object store smoke test to include TLS configurations.

Signed-off-by: Jiffin Tony Thottan <thottanjiffin@gmail.com>
 2021-07-01 18:50:27 +05:30
Sébastien Han b68cac34cb Merge pull request #8222 from sp98/update-block-pool-channels 
ceph: update blockPoolChannel before starting the mirror monitoring
 2021-07-01 14:10:17 +02:00
Santosh Pillai 8d48a9e10a ceph: update blockPoolChannel before starting the mirror monitoring 
update blockPoolChannel monitoringRunning field to `true` before
starting the goroutine to monitor mirroring

Signed-off-by: Santosh Pillai <sapillai@redhat.com>
 2021-07-01 15:27:37 +05:30
Sébastien Han 048b75c254 Merge pull request #8226 from leseb/fix-secetion-pending-note 
docs: add news feature in the features section
 2021-07-01 11:38:27 +02:00
Sébastien Han 647cccf1d0 docs: add news feature in the features section 
New features were in the "breaking changes" section.

Signed-off-by: Sébastien Han <seb@redhat.com>
 2021-07-01 10:57:48 +02:00
Sébastien Han 2baac8372f Merge pull request #8172 from sp98/hybrid-storage-pools 
ceph: add support for hybrid Storage Pools
 2021-07-01 09:15:16 +02:00
Jiffin Tony Thottan 560f44b07e ceph: enable debug for adminops client if the rook loglevel <= debug 
The debug for adminOps client can be enabled by setting `Debug` flag.
In this PR, it is enabled for OBC and cephobjectstore not healthchecker.
Also add similar changes while calling `NewS3Agent` in the bucket
provisioner code path.

Signed-off-by: Jiffin Tony Thottan <thottanjiffin@gmail.com>
 2021-07-01 11:36:51 +05:30
Santosh Pillai 4041868e2e ceph: hybrid Storage Pools 
Creates hybrid crush rule for choosing Primary OSD for
high performing SSD devices and remaining OSD for low performance HDD devices.

Signed-off-by: Santosh Pillai <sapillai@redhat.com>
 2021-07-01 11:16:54 +05:30
Blaine Gardner 037945aabc Merge pull request #8112 from BlaineEXE/dependencies-2-son-of-dependencies 
ceph: block delete object store when buckets and/or users exist
 2021-06-30 12:45:58 -06:00
Travis Nielsen 03f6dddcfd Merge pull request #8170 from subhamkrai/update-helm-version 
ci: remove read access from kube config
 2021-06-30 11:29:35 -06:00
Blaine Gardner 53459bbb44 Merge pull request #8195 from BlaineEXE/ignore-atari-partitions 
ceph: ignore atari partitions when provisioning OSDs
 2021-06-30 11:26:56 -06:00
Blaine Gardner 7f516b9e3d ceph: ignore atari partitions when scanning disks 
Ceph bluestore raw disks can sometimes appear as though they have Atari
(AHDI) partitions on them. If a disk has Atari partitions, we just
ignore them as though they don't exist. This should be a safe assumption
since the hardware was last manufactured in 1992 and likely can't run
Kubernetes.

If we don't ignore the Atari partitions, Rook can create a new OSD on a
disk that is already running an OSD, corrupting the first and possibly
also the latest OSD. This can happen an arbitrary number of times per
disk.

More info: https://github.com/rook/rook/issues/7940

Signed-off-by: Blaine Gardner <blaine.gardner@redhat.com>
 2021-06-30 09:42:33 -06:00
Travis Nielsen c77a9a9aa8 Merge pull request #8219 from leseb/bz-1964467-upstream 
ceph: do not require rgw 'instances' spec
 2021-06-30 07:24:00 -06:00
Sébastien Han e25e0e8103 ceph: do not require rgw 'instances' spec 
When the cluster is external we don't have any instances of rgw running
so let's not have this as a required field in the spec.

Signed-off-by: Sébastien Han <seb@redhat.com>
 2021-06-30 11:24:09 +02:00
Sébastien Han d3ff3b4c50 Merge pull request #8092 from leseb/external-mode-rgw-ssl 
ceph: add tls support to external rgw endpoint
 2021-06-30 09:30:45 +02:00
Satoru Takeuchi 644039bb9a Merge pull request #8213 from leseb/retry-build-on-network-failure 
ci: retry build on network failures
 2021-06-30 09:12:50 +09:00
Blaine Gardner c22f545ebf ceph: block delete object store when buckets exist 
Block deletion of CephObjectStore resources when buckets exist in the
object store.

Signed-off-by: Blaine Gardner <blaine.gardner@redhat.com>
 2021-06-29 14:31:39 -06:00
Sébastien Han d645152743 ceph: ability pass rgw certificate to external mode 
We now have a new option called --rgw-tls-cert-path to specify a
certificate path for the rgw external mode.

Example output:

```
[root@rook-ceph-tools-78cdfd976c-25942 /]# python3 /etc/ceph/create-external-cluster-resources.py --rbd-data-pool-name device_health_metrics --monitoring-endpoint 172.17.0.11 --rgw-tls-cert-path my-cert --rgw-endpoint 10.108.182.47:80
[{"name": "rook-ceph-mon-endpoints", "kind": "ConfigMap", "data": {"data": "a=10.100.223.211:6789", "maxMonId": "0", "mapping": "{}"}}, {"name": "rook-ceph-mon", "kind": "Secret", "data": {"admin-secret": "admin-secret", "fsid": "5cd5684c-8b8b-4d59-a98a-525f63ae69a3", "mon-secret": "mon-secret"}}, {"name": "rook-ceph-operator-creds", "kind": "Secret", "data": {"userID": "client.healthchecker", "userKey": "AQBnx9BgnH9kDxAAb6T0nmMpetfmwNw5gKgA2w=="}}, {"name": "rook-csi-rbd-node", "kind": "Secret", "data": {"userID": "csi-rbd-node", "userKey": "AQAe0bhgVvahJxAAGJLuP/Tajh2fz6ExqxYT/A=="}}, {"name": "ceph-rbd", "kind": "StorageClass", "data": {"pool": "device_health_metrics"}}, {"name": "monitoring-endpoint", "kind": "CephCluster", "data": {"MonitoringEndpoint": "172.17.0.11", "MonitoringPort": "9283"}}, {"name": "rook-csi-rbd-provisioner", "kind": "Secret", "data": {"userID": "csi-rbd-provisioner", "userKey": "AQAe0bhgkpHWGhAAJNPrBBD5OfbQvGRAYUrbCg=="}}, {"name": "ceph-rgw-tls-cert", "kind": "Secret", "data": {"cert": "-----BEGIN CERTIFICATE-----\nMIIFODCCAyCgAwIBAgIRAJW+FqD3LkbxezmCcvqLzZYwDQYJKoZIhvcNAQEFBQAw\nNzEUMBIGA1UECgwLVGVsaWFTb25lcmExHzAdBgNVBAMMFlRlbGlhU29uZXJhIFJv\nb3QgQ0EgdjEwHhcNMDcxMDE4MTIwMDUwWhcNMzIxMDE4MTIwMDUwWjA3MRQwEgYD\nVQQKDAtUZWxpYVNvbmVyYTEfMB0GA1UEAwwWVGVsaWFTb25lcmEgUm9vdCBDQSB2\nMTCCAiIwDQYJKoZIhvcNAQEBBQADggIPADCCAgoCggIBAMK+6yfwIaPzaSZVfp3F\nVRaRXP3vIb9TgHot0pGMYzHw7CTww6XScnwQbfQ3t+XmfHnqjLWCi65ItqwA3GV1\n7CpNX8GH9SBlK4GoRz6JI5UwFpB/6FcHSOcZrr9FZ7E3GwYq/t75rH2D+1665I+X\nZ75Ljo1kB1c4VWk0Nj0TSO9P4tNmHqTPGrdeNjPUtAa9GAH9d4RQAEX1jF3oI7x+\n/jXh7VB7qTCNGdMJjmhnXb88lxhTuylixcpecsHHltTbLaC0H2kD7OriUPEMPPCs\n81Mt8Bz17Ww5OXOAFshSsCPN4D7c3TxHoLs1iuKYaIu+5b9y7tL6pe0S7fyYGKkm\ndtwoSxAgHNN/Fnct7W+A90m7UwW7XWjH1Mh1Fj+JWov3F0fUTPHSiXk+TT2YqGHe\nOh7S+F4D4MHJHIzTjU3TlTazN19jY5szFPAtJmtTfImMMsJu7D0hADnJoWjiUIMu\nsDor8zagrC/kb2HCUQk5PotTubtn2txTuXZZNp1D5SDgPTJghSJRt8czu90VL6R4\npgd7gUY2BIbdeTXHlSw7sKMXNeVzH7RcWe/a6hBle3rQf5+ztCo3O3CLm1u5K7fs\nslESl1MpWtTwEhDcTwK7EpIvYtQ/aUN8Ddb8WHUBiJ1YFkveupD/RwGJBmr2X7KQ\narMCpgKIv7NHfirZ1fpoeDVNAgMBAAGjPzA9MA8GA1UdEwEB/wQFMAMBAf8wCwYD\nVR0PBAQDAgEGMB0GA1UdDgQWBBTwj1k4ALP1j5qWDNXr+nuqF+gTEjANBgkqhkiG\n9w0BAQUFAAOCAgEAvuRcYk4k9AwI//DTDGjkk0kiP0Qnb7tt3oNmzqjMDfz1mgbl\ndxSR651Be5kqhOX//CHBXfDkH1e3damhXwIm/9fH907eT/j3HEbAek9ALCI18Bmx\n0GtnLLCo4MBANzX2hFxc469CeP6nyQ1Q6g2EdvZR74NTxnr/DlZJLo961gzmJ1Tj\nTQpgcmLNkQfWpb/ImWvtxBnmq0wROMVvMeJuScg/doAmAyYp4Db29iBT4xdwNBed\nY2gea+zDTYa4EzAvXUYNR0PVG6pZDrlcjQZIrXSHX8f8MVRBE+LHIQ6e4B4N4cB7\nQ4WQxYpYxmUKeFfyxiMPAdkgS94P+5KFdSpcc41teyWRyu5FrgZLAMzTsVlQ2jqI\nOylDRl6XK1TOU2+NSueW+r9xDkKLfP0ooNBIytrEgUy7onOTJsjrDNYmiLbAJM+7\nvVvrdX3pCI6GMyx5dwlppYn8s3CQh3aP0yK7Qs69cwsgJirQmz1wHiRszYd2qReW\nt88NkvuOGKmYSdGe/mBEciG5Ge3C9THxOUiIkCR1VBatzvT4aRRkOfujuLpwQMcn\nHL/EVlP6Y2XQ8xwOFvVrhlhNGNTkDY6lnVuR3HYkUD/GKvvZt5y11ubQ2egZixVx\nSK236thZiNSQvxaz2emsWWFUyBy6ysHK4bkgTI86k4mloMy/0/Z1pHWWbVY=\n-----END CERTIFICATE-----"}}]
```

Signed-off-by: Sébastien Han <seb@redhat.com>
 2021-06-29 09:46:50 +02:00
Sébastien Han 9738131010 ci: retry on network build failures 
We have seen cases where the build might fail due to a small network
hiccup so let's retry up to 3 times if this is the case.

Signed-off-by: Sébastien Han <seb@redhat.com>
 2021-06-29 09:18:56 +02:00
Sébastien Han e6734304cd ci: format helper using standard 2 spaces indent 
Bash common indent is 2 spaces so let's use it.
See: https://google.github.io/styleguide/shellguide.html

Signed-off-by: Sébastien Han <seb@redhat.com>
 2021-06-29 09:18:56 +02:00
subhamkrai d3190c3755 ci: remove read access from kube config 
this commit remove read access from kube
config file for group and others.

Signed-off-by: subhamkrai <srai@redhat.com>
 2021-06-28 21:37:11 +05:30
Travis Nielsen e1a6333f79 Merge pull request #8207 from subhamkrai/revert-helm-changes 
ci: downgrade minikube version from helm suite
 2021-06-28 07:55:55 -06:00
Satoru Takeuchi c37f992830 Merge pull request #8206 from cybozu-go/ceph-fix-livenessprobe-when-config 
ceph: fix overwriting shared livenessProbe
 2021-06-28 20:46:36 +09:00
Yuji Ito d7c46d70d3 ceph: fix overwriting shared livenessProbe 
When the Operator set the livenessProbe of the POD, it overwrote the contents of the shared
desiredProbe. Therefore, the wrongly configured livenessProbe was applied to other PODs,
resulting in a CrashLoop. In this PR, I created another instance to avoid overwriting the
desiredProbe.

Closes: https://github.com/rook/rook/issues/8196
Signed-off-by: Yuji Ito <llamerada.jp@gmail.com>
 2021-06-28 09:54:33 +00:00
subhamkrai 279fbb0b93 ci: downgrade minikube version from helm suite 
this commit downgrades minikube version
from release test for helm suite as
test are failing.

closes: https://github.com/rook/rook/issues/8202
Signed-off-by: subhamkrai <srai@redhat.com>
 2021-06-28 10:51:56 +05:30
Satoru Takeuchi 66609f01b4 Merge pull request #8203 from sebastian-philipp/stale-disable-forks 
ci: disable stale workflow on forks
 2021-06-28 09:25:05 +09:00
Sebastian Wagner a411aa015f ci: disable stale workflow on forks 
Running the stale workflow is a waste of resources.

Signed-off-by: Sebastian Wagner <sewagner@redhat.com>
 2021-06-27 16:59:47 +02:00
Travis Nielsen 06a889fd46 Merge pull request #8199 from travisn/topology-spread-osd-prepare 
ceph: Update cluster-on-pvc example for proper OSD scheduling
 2021-06-25 13:33:30 -06:00
Travis Nielsen 9f6615033d ceph: update cluster-on-pvc example for proper OSD scheduling 
The topology spread constraint example allowed scheduling even
if the TSC could not be satisfied when scheduling the osd prepare
jobs. This could lead to unevenly spread OSDs especially when
the cluster was not using the zone labels. Now the topology will be
required for scheduling, to ensure proper spread of the OSDs.

Signed-off-by: Travis Nielsen <tnielsen@redhat.com>
 2021-06-25 12:20:35 -06:00
Sébastien Han 507f913376 Merge pull request #8191 from leseb/fix-loop-break 
ceph: fix ineffective break statement
 2021-06-25 17:12:53 +02:00
Sébastien Han 23298ba62d ceph: fix ineffective break statement 
The `break` statement is not necessary, especially since we don't want
to break out of the outerloop.

Signed-off-by: Sébastien Han <seb@redhat.com>
 2021-06-25 16:23:23 +02:00
Sébastien Han 36bedf68b2 Merge pull request #8182 from subhamkrai/update-versions 
ci: update versions in the gh action
 2021-06-25 08:54:24 +02:00
Travis Nielsen 259d046ff8 Merge pull request #8190 from Rakshith-R/upd/csi-driver-registrar 
ceph: update csi node-driver-registrar to latest release
 2021-06-24 12:38:39 -06:00
subhamkrai f90050c5b2 ci: update versions in the gh action 
this commit update the versions in the
action. example minikube, python, commitlint
and others.

Signed-off-by: subhamkrai <srai@redhat.com>
 2021-06-24 23:07:47 +05:30
Sébastien Han dfa7dbee54 Merge pull request #7926 from leseb/peer-secret-pool-list 
ceph: append additional info in the rbd-mirror bootstrap peer token
 2021-06-24 11:37:04 +02:00
Rakshith R 2baf50771e ceph: update csi node-driver-registrar to latest release 
This commit updates csi node-driver-registrar to latest
release v2.2.0.
https://github.com/kubernetes-csi/node-driver-registrar/releases

Signed-off-by: Rakshith R <rar@redhat.com>
 2021-06-24 10:22:51 +05:30
Blaine Gardner edb94fd349 core: clean up ApplyMultus() 
In pkg/operator/k8sutil/network.go:ApplyMultus(), be more explicit about
the intended behavior in both var names, code comments, and unit tests.
Additionally fix a logic bug that could cause errors in the future if
more "cluster network apps" are identified in the future.

Signed-off-by: Blaine Gardner <blaine.gardner@redhat.com>
 2021-06-23 11:50:39 -06:00
Travis Nielsen 077ed3f444 Merge pull request #8183 from subhamkrai/timeout-tmate 
ci: set tmate for 120min in case of ci failure
 2021-06-23 10:52:28 -06:00
Sébastien Han 153f1d661c ceph: append additional info in the rbd-mirror bootstrap peer token 
We know append additional information to the rbd-mirror bootstrap peer
token. It is useful for disaster recovery scenario where the other
cluster is reading the peer token and needs to know the pool_id as well
as the namespace.

Signed-off-by: Sébastien Han <seb@redhat.com>
 2021-06-23 18:49:39 +02:00
Travis Nielsen 58e3cbcbdb Merge pull request #8181 from travisn/evict-same-node-mon 
ceph: Evict a mon if colocated with another mon
 2021-06-23 10:47:18 -06:00
Sébastien Han bf7ac3cd69 Merge pull request #8185 from leseb/fix-7728 
ci: try to mitigate runner I/O errors
 2021-06-23 17:29:40 +02:00
Travis Nielsen b1c1e296dd ceph: evict a mon if colocated with another mon 
In a production cluster we never should have two mons running on
the same node. However, if two mons have ended up on the same node,
whether from a bug or some other unintentional event, the operator
will evict one of them and failover to a new mon. This only applies
when allowMultiplePerNode is false.

Signed-off-by: Travis Nielsen <tnielsen@redhat.com>
 2021-06-23 09:29:04 -06:00
Sébastien Han 5e3d5026ab Merge pull request #8184 from leseb/fix-8126 
ci: wait for the ceph-mgr IP to be available
 2021-06-23 10:59:13 +02:00
Sébastien Han 8804b7c79d ci: try to mitigate runner I/O errors 
Hoping to solve some flappy OSD preparation in the CI.
More information in the issue.

Closes: https://github.com/rook/rook/issues/7728
Signed-off-by: Sébastien Han <seb@redhat.com>
 2021-06-23 10:16:29 +02:00
Sébastien Han ba04b3eeef ci: wait for the ceph-mgr IP to be available 
The ceph-mgr needs some time to come up so we need to wait for an IP
address to be available.

Closes: https://github.com/rook/rook/issues/8126
Signed-off-by: Sébastien Han <seb@redhat.com>
 2021-06-23 09:39:12 +02:00
subhamkrai fb7f4ce33b ci: set tmate for 120min in case of ci failure 
this commit enable tmate session for every ci failure
with 120min timeout.

Signed-off-by: subhamkrai <srai@redhat.com>
 2021-06-23 12:31:54 +05:30
Blaine Gardner 76e82e419a Merge pull request #8146 from BlaineEXE/debug-canary-integration 
test: add xtrace logging to github actions
 2021-06-22 11:55:08 -06:00