Commit Graph
13292 Commits
Author SHA1 Message Date
Travis Nielsen ffe12a8ba2 ceph: remove obsolete csi driver cleanup code
The csi driver is no longer removed based on the deletion
of a configmap. Removing obsolete code.

Signed-off-by: Travis Nielsen <tnielsen@redhat.com>
2020-05-29 15:14:19 -06:00
Travis Nielsen 001178fff9 Merge pull request #5551 from travisn/roadmap-1.4
core: update the Rook roadmap for 1.4 and beyond
2020-05-29 10:17:30 -06:00
Travis Nielsen 4781aeb556 core: update rook roadmap for 1.4
The roadmap was severely out of date from Rook v1.2. The
roadmap is updated to target 1.4 features as well
as a better list of features planned, but may not be
targeted for a particular rook release.

Signed-off-by: Travis Nielsen <tnielsen@redhat.com>
2020-05-29 10:06:03 -06:00
Travis Nielsen a8ca5fbffe Merge pull request #5562 from aruniiird/fixDataQuotesInExternalResourceScript
Ceph: Added the missing double quotes in JSON output
2020-05-29 09:33:15 -06:00
subhamkrai 4378a30c64 ceph: updated initializeBlockPVC method and added unit tests
Updated initializeBlockPVC method to add
crushDeviceClass along with
immediateExecuteArgs instead of
metadataArg. Also added unit tests for this method.

Signed-off-by: subhamkrai <subhamkumarrai03@gmail.com>
2020-05-29 12:30:19 +05:30
Travis Nielsen c1ee1104c8 docs: fix indentation on the commit prefixes
The list of commit prefixes in the doc were rendering on
a single line instead of as a list.

Signed-off-by: Travis Nielsen <tnielsen@redhat.com>
2020-05-28 17:02:12 -06:00
Travis Nielsen 0d1c83c9c3 docs: update the obc provisioner name
The OBC provisioner name changed recently to include the namespace
as a prefix, but the docs were not updated.

Signed-off-by: Travis Nielsen <tnielsen@redhat.com>
2020-05-28 17:01:17 -06:00
Travis Nielsen 2a6d4d4cef Merge pull request #5556 from travisn/node-failure-cleanup
Handle node failure more gracefully
2020-05-28 15:44:48 -06:00
Arun Kumar Mohan 2f195bbdfa Ceph: Added the missing double quotes in JSON output
Without the double quotes, operator is unable to parse the json output from the script

Signed-off-by: Arun Kumar Mohan <arun.iiird@gmail.com>
2020-05-29 02:01:55 +05:30
Travis Nielsen 3ab060965c ceph: force restart mon pods if on bad node
If a mon is stuck in terminating state on a failed node,
force delete the pod so it can attempt to restart. If
the mon is backed by a PV the mon can start on another
node as well.

Signed-off-by: Travis Nielsen <tnielsen@redhat.com>
2020-05-28 12:11:05 -06:00
Travis Nielsen ff6a3f80cd ceph: improve osd update logging
The operator should only print helpful info messages
when an OSD is going to be updated. If the OSD hasn't
changed it is just a debug message.

Signed-off-by: Travis Nielsen <tnielsen@redhat.com>
2020-05-28 10:05:51 -06:00
Travis Nielsen 07f095c772 ceph: set osd health check interval to 60s
The osd health check every 5 min is not frequent enough to respond
quickly enough to osds going down. Reducing the time interval
to one minute for faster response time.

Signed-off-by: Travis Nielsen <tnielsen@redhat.com>
2020-05-28 10:05:51 -06:00
Travis Nielsen 171910707b ceph: refactor pod deletion to k8sutil package
The pod deletion is needed by other daemons besides the osds,
so we move the helper method into the k8sutil package.

Signed-off-by: Travis Nielsen <tnielsen@redhat.com>
2020-05-28 10:05:50 -06:00
Sébastien Han ff90fa7098 Merge pull request #5549 from leseb/semantic
add commitlint github action
2020-05-28 17:41:30 +02:00
Sébastien Han dea423fedd Merge pull request #5557 from cybozu-go/ceph-add-how-to-know-whether-filesystem-exist-on-top-of-device
ceph: add the description how to know whether there is a filesystem on top of a device
2020-05-28 17:38:11 +02:00
Sébastien Han db57455ba2 docs: update contribution guideline
Reflect the recent changes with the replacement of the commitlint bot
by the commitlint github action.

Signed-off-by: Sébastien Han <seb@redhat.com>
2020-05-28 17:36:08 +02:00
Sébastien Han d680b00ad7 bot: change PR template
Reflect the change from commitlint bot to commitlint action check.

Signed-off-by: Sébastien Han <seb@redhat.com>
2020-05-28 17:36:04 +02:00
Satoru Takeuchi c3a2677883 ceph: add the description how to know whether there is a filesystem on top of a device
It's better to tell users to know whether their devices can be used as OSD
in the quick start guide.

Signed-off-by: Satoru Takeuchi <satoru.takeuchi@gmail.com>
2020-05-28 15:06:57 +00:00
Diego Abelenda e3b51bf944 csv: Make csv generation work with operator-sdk 0.15.0 and later, remove support for previous versions.
Newer versions of operator-sdk (since 0.15.0, released Jan 2020) have a different command line to generate CSV. Make changes to the script generating the CSV so that it works with these new versions.
Use the newer manifest format to be compatible with bundles in the future.

Signed-off-by: Diego Abelenda <diego.abelenda@gmail.com>
2020-05-28 17:04:33 +02:00
Sébastien Han 7fa606b6a7 Merge pull request #5555 from cybozu-go/ceph-fix-regressions-in-the-integration-tests
ceph: fix regressions in the integration tests
2020-05-28 16:48:59 +02:00
Travis Nielsen d43b061d3b Merge pull request #5532 from travisn/updated-approvers
Governance: Added reviewers for Ceph
2020-05-28 08:27:49 -06:00
Sébastien Han 2b47117fc7 bot: add commitlint gh action
We now use a github action to perform commit linting instead of the old
deprecated commitlint bot.

Closes: https://github.com/rook/rook/issues/5547
Signed-off-by: Sébastien Han <seb@redhat.com>
2020-05-28 12:12:57 +02:00
Sébastien Han d8949ec945 Merge pull request #5545 from leseb/osd-wipe-simple
ceph: enhancement cleanup with disks
2020-05-28 09:32:40 +02:00
Satoru Takeuchi 43296ef36a ceph: make OSD on PVC test work again
OSD on PVC test doesn't work at all because "manual" storage class doesn't
exist here.

It's a regression caused by the following commit.
https://github.com/rook/rook/commit/e96009c26dab8d06e6d3e45efe55b9783028b359

Signed-off-by: Satoru Takeuchi <satoru.takeuchi@gmail.com>
2020-05-28 06:18:59 +09:00
Travis Nielsen f5c394aa3a governance: yugabytedb members are reviewers instead of approvers
There was a typo in the approvers list. The YugabyteDB members
don't yet have push access to the repo as approvers. The intention
was to start with reviewer access.

Signed-off-by: Travis Nielsen <tnielsen@redhat.com>
2020-05-27 15:09:32 -06:00
Travis Nielsen ccaf590979 governance: add satoru and madhu as ceph approvers
Given the significant contributions by Satoru and Madhu,
as approvers they can continue to support project maintainers
through the additional role.

Signed-off-by: Travis Nielsen <tnielsen@redhat.com>
2020-05-27 15:09:27 -06:00
Jiffin Tony Thottan 9a3ffbaab2 obc: Do not delete user for retain policy if it is owner
When obc is deleted, the attached ceph user will be also removed
This will cause obc creation failure for the same bucket since user
was missing. With this patch the user will be retained revoking his permissions

Also removed 'GetBucketPolicy' permission from Allowed action. The same set of
permission is used for denying the owner/old user of OBC. So that in the next
obc request for the bucket, owner can set polciy for the new user

Closes: https://github.com/rook/rook/issues/5510
Signed-off-by: Jiffin Tony Thottan <thottanjiffin@gmail.com>
2020-05-27 22:58:08 +05:30
Sébastien Han c799e11032 ceph: enhancement cleanup with disks
Now, we can not only cleanup monitor data, logs and crashes but the
disks too. As part of the cleanupPolicy CR spec, we have a new setting
called sanitizeDisks which holds more details:

* confirmation: the confirmation message to sanitize disks,
use "yes-really-sanitize-disks" to confirm

This will **only** wipe the metadata, so it's a fast cleanup allowing
you to re-install later but won't remove all the data from the drive.

Signed-off-by: Sébastien Han <seb@redhat.com>
2020-05-27 18:14:02 +02:00
Sébastien Han edca1e9205 Merge pull request #5522 from akraitman/patch-1
Enabling buildDiscarder
2020-05-27 10:47:58 +02:00
Travis Nielsen e9348070a7 Merge pull request #5533 from gyant/ryanthompson/fix-cassandra-annotations
cassandra: Adds json struct tags to fix cassandra annotations
2020-05-26 15:34:24 -06:00
Travis Nielsen 1b2ff6573a Merge pull request #5334 from binoue/update-helm-version
ceph: update helm version
2020-05-26 14:23:35 -06:00
Satoru Takeuchi 206e45facd ceph: fix the wrong condition in the cluster health check
There are the following problems in the cluster health check.

- If the cluster is healthy: Unnecessary long time before exiting from
  the health check loop. The test succeeds thanks to the succeeding
  assertion by luck.
- If the cluster is unhealthy: Exit from the health check loop immediately.
  The test fails in the succeeding assertion by luck too.

It's a regression that is introduced in the following commit.
https://github.com/rook/rook/commit/c0c0dc4ed977a6b373b1884c5b76c9588f0be077

Signed-off-by: Satoru Takeuchi <satoru.takeuchi@gmail.com>
2020-05-27 05:20:24 +09:00
Sébastien Han 1d61812f37 Merge pull request #5548 from leseb/crash-perm
ceph: add missing security context to crash collector
2020-05-26 18:45:07 +02:00
Adam Kraitman 1731f9cb25 build: Enabling buildDiscarder
Enabling buildDiscarder which keeps only the newest 200 builds

Signed-off-by: Adam Kraitman <akraitma@redhat.com>
2020-05-26 17:43:15 +03:00
Sébastien Han 0ed8e73942 ceph: add missing security context to crash collector
The crash collector was missing the security context to properly run on
OCP, thus crashing when trying to post a crash dump.

Signed-off-by: Sébastien Han <seb@redhat.com>
2020-05-26 16:35:11 +02:00
Ahmad Nurus S 714d654ec4 design: rename nfs object kind
This commit rename nfs object kind with actually implemented name `NFSServer`
instead of `NetworkFileSystem`. This commit also fix some bad url.

Signed-off-by: Ahmad Nurus S <prksu.sh@gmail.com>
2020-05-25 23:31:28 +07:00
Sébastien Han 3ffda5645a Merge pull request #5518 from aruniiird/fixGenCSVScript
Ceph: A minor fix to 'generate-rook-csv.sh' script
2020-05-25 10:24:19 +02:00
binoue a86b060849 ceph: update helm version
Currently, Helm v2.5.1 is used, but this version is released in 2017
and a little outdated.
To use the latest version of helm v2.x.x would be beneficial
as we can use more useful Helm commands like `helm template`.

This commit updates Helm version and stop using `helm lint`
with `--strict` option because Helm v2.16.7 does not allow
to use undefined values in values.yaml and
the Helm upstream is now stopping using the `--strict` option.

Signed-off-by: binoue <banji-inoue@cybozu.co.jp>
2020-05-24 16:48:05 +09:00
Arun Kumar Mohan bb770bb0d1 Ceph: A minor fix to 'generate-rook-csv.sh' script
A square bracket check on <shell_command> return status
will not work in an 'if' condition.

Signed-off-by: Arun Kumar Mohan <arun.iiird@gmail.com>
2020-05-23 23:36:37 +05:30
Ryan Thompson 36db509747 cassandra: Adds json struct tags to fix cassandra annotations
x ClusterSpec
x RackSpec

The lack of the json tag required manifests to use 'Annotations' rather than 'annotations' to propogate annotations to the stateful set pods. This change will allow the software to function as documented.

Closes: https://github.com/rook/rook/issues/5097
Signed-off-by: Ryan Thompson <ryan@zengyant.com>
2020-05-22 22:26:50 -07:00
Sébastien Han 643a2aff27 Merge pull request #5531 from leseb/mergify-highlight
mergify: ping user if PR has conflicts
2020-05-22 17:18:43 +02:00
Sébastien Han 67a8959e0a mergify: ping user if PR has conflicts
That rule posts a comment as soon as a pull request is in conflict, notifying the pull request author that they need to intervene!

Signed-off-by: Sébastien Han <seb@redhat.com>
2020-05-22 16:49:08 +02:00
Sébastien Han 3dfe08cb9f Merge pull request #5529 from leseb/rm-osd-memory-target
ceph: do not enforce osd-memory-target
2020-05-22 12:38:04 +02:00
Sébastien Han 062e58e053 ceph: do not enforce osd-memory-target
As of Nautilus Ceph auto-tunes its osd_memory_target on the fly so we don't need to force it.
ROok does not support Mimic anymore so this can be removed.

Signed-off-by: Sébastien Han <seb@redhat.com>
2020-05-22 11:09:02 +02:00
Travis Nielsen f8256f8f01 Merge pull request #5524 from travisn/data-name-default
ceph: default the device set template name to data
2020-05-21 13:53:00 -06:00
Travis Nielsen 8bb4f603e6 ceph: default the device set template name to data
In 1.3 we added support for the metadata pvcs, thus requiring the name
to be set on the templates to differentiate between data and metadata.
For backward compatibility we need to assume the template is for data
if it is not set.

Signed-off-by: Travis Nielsen <tnielsen@redhat.com>
2020-05-21 11:33:16 -06:00
Sébastien Han 2576674648 Merge pull request #5515 from leseb/lvm-verbose
ceph: fix lvm arg
2020-05-20 17:13:47 +02:00
Sébastien Han 712c958202 ceph: fix lvm arg
Add the valid verbose flags back.

Signed-off-by: Sébastien Han <seb@redhat.com>
2020-05-20 13:03:51 +02:00
Sébastien Han 757e040e75 Merge pull request #5513 from travisn/delete-resized-pool
Pool resize test hangs during cleanup with latest v15.2.2
2020-05-20 08:54:19 +02:00
Travis Nielsen e1a9a9039b ceph: pool resize test hangs during cleanup
In Octopus 15.2.2 there is an rbd change that causes the rbd ls command
to hang if there are not sufficient OSDs to meet the replica requirement.
The smoke suite just started hanging today since the 15.2.2 image was
released with this change. Therefore, the test that resizes the pool
to replica 3 must resize back to 1 before cleaning up.

Signed-off-by: Travis Nielsen <tnielsen@redhat.com>
2020-05-19 22:02:37 -06:00